Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: pkg/dev_compiler/lib/src/compiler/code_generator.dart

Issue 2827333003: Tighten up handling of JS types and add test. (Closed)
Patch Set: Tighten up handling of JS types. Fix bug where helpers in js_mirrors were specifying name had type … Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/lib/src/compiler/code_generator.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/code_generator.dart b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
index e24dce52e3e059d672b4e0ddcc8c594df115cef4..12bd4371b93bd0de779ea936b04ec875dc6021a3 100644
--- a/pkg/dev_compiler/lib/src/compiler/code_generator.dart
+++ b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
@@ -437,9 +437,7 @@ class CodeGenerator extends Object
return _jsInteropStaticMemberName(e.getter, name: e.name) ??
_jsInteropStaticMemberName(e.setter, name: e.name);
}
- if (e is ExecutableElement &&
- e.isExternal &&
- findAnnotation(e, isPublicJSAnnotation) != null) {
+ if (e is ExecutableElement && e.isExternal) {
return getAnnotationName(e, isPublicJSAnnotation) ?? name ?? e.name;
}
return null;

Powered by Google App Engine
This is Rietveld 408576698