Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2827263006: Revert "Refactor ContentViewClient (6/6)" (Closed)

Created:
3 years, 8 months ago by Jinsuk Kim
Modified:
3 years, 8 months ago
Reviewers:
amineer
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, Peter Beverloo, shuchen+watch_chromium.org, lcwu+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, agrieve+watch_chromium.org, alokp+watch_chromium.org, James Su, android-webview-reviews_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Revert "Refactor ContentViewClient (6/6)" https://crbug.com/713924 This reverts commit a52e8dc5d782827ce7e426ebde5537949ef4cb01. Revert "Migrate IME state update flow" This reverts commit e4f39f538c7a9fe52a635d4fc4c92e3a5c82fe8a. NOTRY=true NOPRESUBMIT=true BUG=713924 TBR=boliu@chromium.org,tedchoc@chromium.org,halliwell@chromium.org Review-Url: https://codereview.chromium.org/2827263006 Cr-Commit-Position: refs/branch-heads/3071@{#111} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/5bcc8e36d6317c72e9d95deb63247be39da74bcf

Patch Set 1 #

Patch Set 2 : Revert "Let ImeAdapterAndroid have the same lifecycle as its Java peer" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+689 lines, -1149 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 9 chunks +55 lines, -26 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabViewAndroidDelegate.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsActivity.java View 3 chunks +4 lines, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 3 chunks +17 lines, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 4 chunks +59 lines, -2 lines 0 comments Download
M content/browser/android/ime_adapter_android.h View 1 1 chunk +0 lines, -130 lines 0 comments Download
M content/browser/android/ime_adapter_android.cc View 1 1 chunk +0 lines, -443 lines 0 comments Download
A + content/browser/renderer_host/ime_adapter_android.h View 1 7 chunks +15 lines, -29 lines 0 comments Download
A + content/browser/renderer_host/ime_adapter_android.cc View 1 12 chunks +42 lines, -121 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 6 chunks +5 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 9 chunks +17 lines, -22 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/android/BUILD.gn View 4 chunks +2 lines, -2 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 1 chunk +40 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 22 chunks +210 lines, -28 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java View 1 3 chunks +5 lines, -1 line 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/ViewUtils.java View 1 chunk +0 lines, -24 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 30 chunks +142 lines, -247 lines 0 comments Download
D content/public/android/java/src/org/chromium/content_public/browser/ImeEventObserver.java View 1 chunk +0 lines, -22 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java View 1 2 chunks +9 lines, -7 lines 0 comments Download
A content/public/android/javatests/src/org/chromium/content/browser/input/TestImeAdapterDelegate.java View 1 chunk +42 lines, -0 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/Shell.java View 4 chunks +7 lines, -1 line 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/ShellManager.java View 3 chunks +3 lines, -1 line 0 comments Download
M content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java View 1 chunk +0 lines, -11 lines 0 comments Download
M ui/android/view_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/android/view_android.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827263006/1
3 years, 8 months ago (2017-04-21 01:33:55 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 01:41:52 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5bcc8e36d6317c72e9d95deb6324...

Powered by Google App Engine
This is Rietveld 408576698