chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java - Issue 2827263006: Revert "Refactor ContentViewClient (6/6)"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java

Issue 2827263006: Revert "Refactor ContentViewClient (6/6)" (Closed)

Patch Set: Revert "Let ImeAdapterAndroid have the same lifecycle as its Java peer" Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabViewAndroidDelegate.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java

index a5f0706b07fd4655ba8f315292b5133d9e49a292..5192e81431014153c4aa3eaa42d5d83a08ee9d6b 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/OSKOverscrollTest.java

@@ -151,7 +151,8 @@ public class OSKOverscrollTest extends ChromeActivityTestCaseBase<ChromeActivity

// Verify that the size of the viewport before the OSK show is equal to the size of

// the viewport after the OSK show plus the size of the keyboard.

int viewportHeightAfterCss = getViewportHeight(webContentsRef.get());

- int keyboardHeight = getActivity().getActivityTab().getSystemWindowInsetBottom();

+ int keyboardHeight =

+ viewCoreRef.get().getContentViewClient().getSystemWindowInsetBottom();

int priorHeight = (int) (viewportHeightBeforeCss * cssToDevicePixFactor);

int afterHeightPlusKeyboard =