Change default style of menu[type=context]

Change default style of menu[type=context]

This CL changes menu[type=context] style to display:none.
https://html.spec.whatwg.org/multipage/rendering.html#hidden-elements

BUG=713429
Review-Url: https://codereview.chromium.org/2827243002
Cr-Commit-Position: refs/heads/master@{#466810}
Committed: https://chromium.googlesource.com/chromium/src/+/9380b0c8dbb73b5421652c5f5e1472307e51cfcf

[yuzuchan, 2017-04-20 07:23:18]

Description was changed from

==========
Enter a description of the change.
Change default style of menu[type=context]

BUG=713429
==========

to

==========
Change default style of menu[type=context]

This CL changes menu[type=context] style to display:none.

BUG=713429
==========

[yuzuchan, 2017-04-20 07:23:23]

The CQ bit was checked by yuzus@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 07:23:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 09:05:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 09:05:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yuzuchan, 2017-04-24 02:49:24]

The CQ bit was checked by yuzus@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 02:49:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yuzuchan, 2017-04-24 04:17:58]

Description was changed from

==========
Change default style of menu[type=context]

This CL changes menu[type=context] style to display:none.

BUG=713429
==========

to

==========
Change default style of menu[type=context]

This CL changes menu[type=context] style to display:none.
https://html.spec.whatwg.org/multipage/rendering.html#hidden-elements
BUG=713429
==========

[yuzuchan, 2017-04-24 04:18:06]

Description was changed from

==========
Change default style of menu[type=context]

This CL changes menu[type=context] style to display:none.
https://html.spec.whatwg.org/multipage/rendering.html#hidden-elements
BUG=713429
==========

to

==========
Change default style of menu[type=context]

This CL changes menu[type=context] style to display:none.
https://html.spec.whatwg.org/multipage/rendering.html#hidden-elements

BUG=713429
==========

[commit-bot: I haz the power, 2017-04-24 04:41:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 04:41:57]

Dry run: This issue passed the CQ dry run.

[yuzuchan, 2017-04-24 05:04:59]

yuzus@chromium.org changed reviewers:
+ tkent@chromium.org

[yuzuchan, 2017-04-24 05:05:00]

PTAL :) 

This is how I feel about this patch: http://i.imgur.com/JvFfLH0.gif

[tkent, 2017-04-24 05:17:39]

tkent@chromium.org changed reviewers:
+ dmazzoni@chromium.org, je_julie.kim@chromium.org

[tkent, 2017-04-24 05:20:18]

The code change looks ok.  We need comments from ax people.

https://codereview.chromium.org/2827243002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html
(right):

https://codereview.chromium.org/2827243002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html:57:
<menu type="toolbar" role="presentation">
I'm not sure if this change is safe.
+je_julie.kim@ and dmazzoni@ who made and reviewed
https://codereview.chromium.org/1039873002 .

[dmazzoni, 2017-04-24 15:54:50]

lgtm

https://codereview.chromium.org/2827243002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html
(right):

https://codereview.chromium.org/2827243002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html:57:
<menu type="toolbar" role="presentation">
On 2017/04/24 05:20:18, tkent wrote:
> I'm not sure if this change is safe.
> +je_julie.kim@ and dmazzoni@ who made and reviewed
> https://codereview.chromium.org/1039873002 .

This seems fine. At the time the test was written, <menu type="context"> wasn't
display:none.

[tkent, 2017-04-24 22:59:09]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-04-24 22:59:10]

lgtm

[commit-bot: I haz the power, 2017-04-24 22:59:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 23:04:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493074749735630,
"parent_rev": "12b000b53d9f17fe443e7ff10a57f00f9ff17045", "commit_rev":
"9380b0c8dbb73b5421652c5f5e1472307e51cfcf"}

[commit-bot: I haz the power, 2017-04-24 23:04:18]

Description was changed from

==========
Change default style of menu[type=context]

This CL changes menu[type=context] style to display:none.
https://html.spec.whatwg.org/multipage/rendering.html#hidden-elements

BUG=713429
==========

to

==========
Change default style of menu[type=context]

This CL changes menu[type=context] style to display:none.
https://html.spec.whatwg.org/multipage/rendering.html#hidden-elements

BUG=713429

Review-Url: https://codereview.chromium.org/2827243002
Cr-Commit-Position: refs/heads/master@{#466810}
Committed:
https://chromium.googlesource.com/chromium/src/+/9380b0c8dbb73b5421652c5f5e14...
==========

[commit-bot: I haz the power, 2017-04-24 23:04:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9380b0c8dbb73b5421652c5f5e14...