third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html - Issue 2827243002: Change default style of menu[type=context]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html

Issue 2827243002: Change default style of menu[type=context] (Closed)

Patch Set: Fix failing tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG ('k') | third_party/WebKit/LayoutTests/html/menu_menuitem/custom-context-menu-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html

diff --git a/third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html b/third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html

index 3d770e57b8b592f1f26ebdfd11d56db9d99601a7..991011e057aed904cce5e538094e5190fca45e12 100644

--- a/third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html

+++ b/third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html

@@ -54,7 +54,7 @@

<div>The menu items except button have a static text role because it has a presentation role and is disabled.<br>

Button has a button role because it has an explicit role.</div>

-<menu type="context" role="presentation">

+<menu type="toolbar" role="presentation">

tkent 2017/04/24 05:20:18 I'm not sure if this change is safe. +je_julie.kim

dmazzoni 2017/04/24 15:54:50 This seems fine. At the time the test was written,

<input type="checkbox" name="vehicle" value="Bike" disabled> I have a bike

<input type="radio" name="gender" value="male" disabled> Male