Remove URLRequestJob::GetResponseCode implementations outside of net/.

Remove URLRequestJob::GetResponseCode implementations outside of net/.

URLRequestJob itself now has a default implementation, which gets
the response code from the headers returned by GetResponseInfo.
We eventually want to remove this method, since it's redundant,
and has weird behavior for just when it is and is not safe to
call.

BUG=688481
Review-Url: https://codereview.chromium.org/2827233005
Cr-Commit-Position: refs/heads/master@{#466631}
Committed: https://chromium.googlesource.com/chromium/src/+/ec95f5b430aac7baff41e4b34cda43116a438905

[mmenke, 2017-04-21 16:40:17]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 16:40:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 16:46:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 16:46:51]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[mmenke, 2017-04-21 17:26:12]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 17:26:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 17:35:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 17:35:06]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[mmenke, 2017-04-21 17:45:54]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 17:46:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 17:55:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 17:55:39]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[mmenke, 2017-04-21 18:06:35]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 18:06:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-04-21 18:49:13]

Patchset #3 (id:40001) has been deleted

[mmenke, 2017-04-21 18:56:06]

mmenke@chromium.org changed reviewers:
+ lazyboy@chromium.org, marq@chromium.org, nhiroki@chromium.org,
sorin@chromium.org

[mmenke, 2017-04-21 18:56:07]

[+sorin] Please review components/update_client/url_request_post_interceptor.cc
[+lazyboy]:  Please review extensions/
[+marq]:  Please review ios/
[+nhiroki]:  Please review storage/browser/fileapi (Sorry, missed that file on
my earlier CL)

The response code is now pulled from the headers returned by GetResponseInfo, by
default, so we can get rid of this method.

[commit-bot: I haz the power, 2017-04-21 19:13:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 19:13:46]

Dry run: This issue passed the CQ dry run.

[Sorin Jianu, 2017-04-21 19:56:27]

lgtm

Thank you!

component updater lgtm

https://codereview.chromium.org/2827233005/diff/60001/components/update_clien...
File components/update_client/url_request_post_interceptor.cc (right):

https://codereview.chromium.org/2827233005/diff/60001/components/update_clien...
components/update_client/url_request_post_interceptor.cc:38: std::string headers
=
can be declared const.

https://codereview.chromium.org/2827233005/diff/60001/components/update_clien...
components/update_client/url_request_post_interceptor.cc:40: info->headers = new
net::HttpResponseHeaders(
Most likely, we could use base::MakeShared to avoid the call to the new
operator, which is frown upon, in general.

[mmenke, 2017-04-21 20:03:03]

Thanks for the feedback!

https://codereview.chromium.org/2827233005/diff/60001/components/update_clien...
File components/update_client/url_request_post_interceptor.cc (right):

https://codereview.chromium.org/2827233005/diff/60001/components/update_clien...
components/update_client/url_request_post_interceptor.cc:38: std::string headers
=
On 2017/04/21 19:56:27, Sorin Jianu wrote:
> can be declared const.

Done.

https://codereview.chromium.org/2827233005/diff/60001/components/update_clien...
components/update_client/url_request_post_interceptor.cc:40: info->headers = new
net::HttpResponseHeaders(
On 2017/04/21 19:56:27, Sorin Jianu wrote:
> Most likely, we could use base::MakeShared to avoid the call to the new
> operator, which is frown upon, in general.

Done.

[Sorin Jianu, 2017-04-21 20:04:44]

lgtm

Thank you so much!

[lazyboy, 2017-04-21 20:35:39]

extension_protocols.cc lgtm.

[nhiroki, 2017-04-22 02:26:52]

fileapi lgtm

[marq (ping after 24h), 2017-04-24 07:44:38]

ios/ LGTM

[mmenke, 2017-04-24 12:49:00]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-04-24 12:49:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 15:33:36]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493038140836150,
"parent_rev": "c4cb0d38f0bd26578120775e9c09be813b5215c0", "commit_rev":
"ec95f5b430aac7baff41e4b34cda43116a438905"}

[commit-bot: I haz the power, 2017-04-24 15:33:57]

Description was changed from

==========
Remove URLRequestJob::GetResponseCode implementations outside of net/.

URLRequestJob itself now has a default implementation, which gets
the response code from the headers returned by GetResponseInfo.
We eventually want to remove this method, since it's redundant,
and has weird behavior for just when it is and is not safe to
call.

BUG=688481
==========

to

==========
Remove URLRequestJob::GetResponseCode implementations outside of net/.

URLRequestJob itself now has a default implementation, which gets
the response code from the headers returned by GetResponseInfo.
We eventually want to remove this method, since it's redundant,
and has weird behavior for just when it is and is not safe to
call.

BUG=688481

Review-Url: https://codereview.chromium.org/2827233005
Cr-Commit-Position: refs/heads/master@{#466631}
Committed:
https://chromium.googlesource.com/chromium/src/+/ec95f5b430aac7baff41e4b34cda...
==========

[commit-bot: I haz the power, 2017-04-24 15:33:58]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ec95f5b430aac7baff41e4b34cda...