Remove URLRequestJob::GetResponseCode implementations outside of net/.

components/update_client/url_request_post_interceptor.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/update_client/url_request_post_interceptor.h"
 
 #include <memory>
 
 #include "base/files/file_util.h"
 #include "base/macros.h"
 #include "base/strings/stringprintf.h"
 #include "components/update_client/test_configurator.h"
 #include "net/base/upload_bytes_element_reader.h"
 #include "net/base/upload_data_stream.h"
+#include "net/http/http_response_headers.h"
+#include "net/http/http_util.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_filter.h"
 #include "net/url_request/url_request_interceptor.h"
 #include "net/url_request/url_request_simple_job.h"
 #include "net/url_request/url_request_test_util.h"
 
 namespace update_client {
 
 // Returns a canned response.
 class URLRequestMockJob : public net::URLRequestSimpleJob {
  public:
   URLRequestMockJob(net::URLRequest* request,
                     net::NetworkDelegate* network_delegate,
                     int response_code,
                     const std::string& response_body)
       : net::URLRequestSimpleJob(request, network_delegate),
         response_code_(response_code),
         response_body_(response_body) {}
 
  protected:
-  int GetResponseCode() const override { return response_code_; }
+  void GetResponseInfo(net::HttpResponseInfo* info) override {
+    std::string headers =

[Sorin Jianu, 2017/04/21 19:56:27]

can be declared const.

[mmenke, 2017/04/21 20:03:03]

Done.

+        base::StringPrintf("HTTP/1.1 %i OK\r\n\r\n", response_code_);
+    info->headers = new net::HttpResponseHeaders(

[Sorin Jianu, 2017/04/21 19:56:27]

Most likely, we could use base::MakeShared to avoid the call to the new
operator, which is frown upon, in general.

[mmenke, 2017/04/21 20:03:03]

Done.

+        net::HttpUtil::AssembleRawHeaders(headers.c_str(), headers.length()));
+  }
 
   int GetData(std::string* mime_type,
               std::string* charset,
               std::string* data,
               const net::CompletionCallback& callback) const override {
     mime_type->assign("text/plain");
     charset->assign("US-ASCII");
     data->assign(response_body_);
     return net::OK;
   }
@@ skipping 247 matching lines @@
   return CreateInterceptorForPath(POST_INTERCEPT_PATH);
 }
 
 URLRequestPostInterceptor* InterceptorFactory::CreateInterceptorForPath(
     const char* url_path) {
   return URLRequestPostInterceptorFactory::CreateInterceptor(
       base::FilePath::FromUTF8Unsafe(url_path));
 }
 
 }  // namespace update_client