Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 2827203002: cros: Mount the existing eCryptfs vault to start migration. (Closed)

Created:
3 years, 8 months ago by fukino
Modified:
3 years, 8 months ago
Reviewers:
xiyuan, hashimoto
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

cros: Mount the existing eCryptfs vault to start migration. Before we call cryptohome's MigrateToDircrypto method, we need to mount existing eCryptfs valut to start migration by calling MountEx method with |to_migrate_from_ecryptfs| mount flag. Additionally, this CL removes |auth| argument from MigrateToDircrypto method, since it was removed from DBUS call in the latest cryptohome. https://chromium-review.googlesource.com/#/c/472409/6/cryptohome/cryptohome.xml BUG=711458 TBR=xiyuan@chromium.org,hashimoto@chromium.org Review-Url: https://codereview.chromium.org/2818393002 Cr-Commit-Position: refs/heads/master@{#464945} (cherry picked from commit d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813) Review-Url: https://codereview.chromium.org/2827203002 . Cr-Commit-Position: refs/branch-heads/3071@{#77} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/268dd43e110778c23fbf94ecac3171664589b751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -29 lines) Patch
M chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc View 2 chunks +27 lines, -7 lines 0 comments Download
M chromeos/cryptohome/cryptohome_parameters.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/cryptohome/homedir_methods.h View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/cryptohome/homedir_methods.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chromeos/cryptohome/mock_homedir_methods.h View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/dbus/cryptohome_client.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chromeos/dbus/cryptohome_client.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/dbus/fake_cryptohome_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/mock_cryptohome_client.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
3 years, 8 months ago (2017-04-20 03:07:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
268dd43e110778c23fbf94ecac3171664589b751.

Powered by Google App Engine
This is Rietveld 408576698