cros: Mount the existing eCryptfs vault to start migration.

cros: Mount the existing eCryptfs vault to start migration.

Before we call cryptohome's MigrateToDircrypto method, we need to mount
existing eCryptfs valut to start migration by calling MountEx method with
|to_migrate_from_ecryptfs| mount flag.

Additionally, this CL removes |auth| argument from MigrateToDircrypto method,
since it was removed from DBUS call in the latest cryptohome.
https://chromium-review.googlesource.com/#/c/472409/6/cryptohome/cryptohome.xml

BUG=711458
Review-Url: https://codereview.chromium.org/2818393002
Cr-Commit-Position: refs/heads/master@{#464945}
Committed: https://chromium.googlesource.com/chromium/src/+/d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813

[fukino, 2017-04-17 04:35:10]

Description was changed from

==========
cros: Mount the existing eCryptfs vault to start migration.

BUG=711458
==========

to

==========
cros: Mount the existing eCryptfs vault to start migration.

Before we call cryptohome's MigrateToDircrypto method, we need to mount
existing eCryptfs valut to start migration by calling MountEx method with
|to_migrate_from_ecryptfs| mount flag.

BUG=711458
==========

[fukino, 2017-04-17 04:36:37]

fukino@chromium.org changed reviewers:
+ hashimoto@chromium.org, xiyuan@chromium.org

[fukino, 2017-04-17 04:36:38]

xiyuan@, could you take a look as an owner review?
hashimoto@, could you check if the new flag is used properly in this CL?
Thanks!

[hashimoto, 2017-04-17 05:27:20]

lgtm

[hashimoto, 2017-04-17 06:30:12]

Sorry, one additional fix is needed.

https://codereview.chromium.org/2818393002/diff/40001/chrome/browser/ui/webui...
File
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
(right):

https://codereview.chromium.org/2818393002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:283:
cryptohome::Authorization(GetAuthKey()),
Authorization argument was removed from MigrateToDircrypto.
(https://chromium-review.googlesource.com/c/472409/6/cryptohome/cryptohome.xml)

Please remove this argument from CryptohommeClient and HomedirMethods.

[fukino, 2017-04-17 06:55:26]

Description was changed from

==========
cros: Mount the existing eCryptfs vault to start migration.

Before we call cryptohome's MigrateToDircrypto method, we need to mount
existing eCryptfs valut to start migration by calling MountEx method with
|to_migrate_from_ecryptfs| mount flag.

BUG=711458
==========

to

==========
cros: Mount the existing eCryptfs vault to start migration.

Before we call cryptohome's MigrateToDircrypto method, we need to mount
existing eCryptfs valut to start migration by calling MountEx method with
|to_migrate_from_ecryptfs| mount flag.
Additionally, this CL removes |auth| argument from MigrateToDircrypto method,
since it was removed from DBUS call in the latest cryptohome.
https://chromium-review.googlesource.com/#/c/472409/6/cryptohome/cryptohome.xml

BUG=711458
==========

[fukino, 2017-04-17 06:55:41]

Description was changed from

==========
cros: Mount the existing eCryptfs vault to start migration.

Before we call cryptohome's MigrateToDircrypto method, we need to mount
existing eCryptfs valut to start migration by calling MountEx method with
|to_migrate_from_ecryptfs| mount flag.
Additionally, this CL removes |auth| argument from MigrateToDircrypto method,
since it was removed from DBUS call in the latest cryptohome.
https://chromium-review.googlesource.com/#/c/472409/6/cryptohome/cryptohome.xml

BUG=711458
==========

to

==========
cros: Mount the existing eCryptfs vault to start migration.

Before we call cryptohome's MigrateToDircrypto method, we need to mount
existing eCryptfs valut to start migration by calling MountEx method with
|to_migrate_from_ecryptfs| mount flag.

Additionally, this CL removes |auth| argument from MigrateToDircrypto method,
since it was removed from DBUS call in the latest cryptohome.
https://chromium-review.googlesource.com/#/c/472409/6/cryptohome/cryptohome.xml

BUG=711458
==========

[fukino, 2017-04-17 06:56:59]

Thanks!

https://codereview.chromium.org/2818393002/diff/40001/chrome/browser/ui/webui...
File
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
(right):

https://codereview.chromium.org/2818393002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc:283:
cryptohome::Authorization(GetAuthKey()),
On 2017/04/17 06:30:12, hashimoto wrote:
> Authorization argument was removed from MigrateToDircrypto.
>
(https://chromium-review.googlesource.com/c/472409/6/cryptohome/cryptohome.xml)
> 
> Please remove this argument from CryptohommeClient and HomedirMethods.

Done.

[hashimoto, 2017-04-17 07:01:13]

chromeos/dbus lgtm, thanks!

https://codereview.chromium.org/2818393002/diff/60001/chromeos/dbus/cryptohom...
File chromeos/dbus/cryptohome_client.h (right):

https://codereview.chromium.org/2818393002/diff/60001/chromeos/dbus/cryptohom...
chromeos/dbus/cryptohome_client.h:577: // authorization to the new "dircrypto"
encryption.
nit: "using given authorization" is no longer relevant.

[fukino, 2017-04-17 07:05:16]

https://codereview.chromium.org/2818393002/diff/60001/chromeos/dbus/cryptohom...
File chromeos/dbus/cryptohome_client.h (right):

https://codereview.chromium.org/2818393002/diff/60001/chromeos/dbus/cryptohom...
chromeos/dbus/cryptohome_client.h:577: // authorization to the new "dircrypto"
encryption.
On 2017/04/17 07:01:12, hashimoto wrote:
> nit: "using given authorization" is no longer relevant.

Oops! Done.

[fukino, 2017-04-17 08:02:52]

The CQ bit was checked by fukino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 08:03:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 08:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 08:37:13]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-04-17 16:17:16]

lgtm

[fukino, 2017-04-17 17:34:34]

Thank you!

[fukino, 2017-04-17 17:34:41]

The CQ bit was checked by fukino@chromium.org

[fukino, 2017-04-17 17:34:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
hashimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2818393002/#ps80001
(title: "Fix a comment.")

[commit-bot: I haz the power, 2017-04-17 17:34:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 17:39:13]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492450481191530,
"parent_rev": "a51a79c74201875de7299e5daf61e0c297d64647", "commit_rev":
"d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813"}

[commit-bot: I haz the power, 2017-04-17 17:39:23]

Description was changed from

==========
cros: Mount the existing eCryptfs vault to start migration.

Before we call cryptohome's MigrateToDircrypto method, we need to mount
existing eCryptfs valut to start migration by calling MountEx method with
|to_migrate_from_ecryptfs| mount flag.

Additionally, this CL removes |auth| argument from MigrateToDircrypto method,
since it was removed from DBUS call in the latest cryptohome.
https://chromium-review.googlesource.com/#/c/472409/6/cryptohome/cryptohome.xml

BUG=711458
==========

to

==========
cros: Mount the existing eCryptfs vault to start migration.

Before we call cryptohome's MigrateToDircrypto method, we need to mount
existing eCryptfs valut to start migration by calling MountEx method with
|to_migrate_from_ecryptfs| mount flag.

Additionally, this CL removes |auth| argument from MigrateToDircrypto method,
since it was removed from DBUS call in the latest cryptohome.
https://chromium-review.googlesource.com/#/c/472409/6/cryptohome/cryptohome.xml

BUG=711458

Review-Url: https://codereview.chromium.org/2818393002
Cr-Commit-Position: refs/heads/master@{#464945}
Committed:
https://chromium.googlesource.com/chromium/src/+/d698c77f8ab3b0e0e61d3fe99bc5...
==========

[commit-bot: I haz the power, 2017-04-17 17:39:24]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d698c77f8ab3b0e0e61d3fe99bc5...