Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2827103003: Revert of Finish implementation of automation API hit testing for the desktop. (Closed)

Created:
3 years, 8 months ago by aboxhall
Modified:
3 years, 8 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, extensions-reviews_chromium.org, kalyank, sadrul, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, je_julie, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Finish implementation of automation API hit testing for the desktop. (patchset #2 id:20001 of https://codereview.chromium.org/2813083003/ ) Reason for revert: DesktopHitTest is failing on MSan builder: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=AutomationApiTest.DesktopHitTest Original issue's description: > Finish implementation of automation API hit testing for the desktop. > > This change finishes support for AX_ACTION_HIT_TEST in AXHostDelegate > so that you can send a hit test request on the root of the whole automation > tree and get a hit test on either views or web content. > > Switches Select-to-speak to use this new API. A follow-up change will > change the way select-to-speak works so that it sends the mouse event > to the extension and the hit test comes from there, but this is a > self-contained change that can land first. > > BUG=699617 > > Review-Url: https://codereview.chromium.org/2813083003 > Cr-Commit-Position: refs/heads/master@{#465716} > Committed: https://chromium.googlesource.com/chromium/src/+/28ac2d11e80db21b5b7a37968d558c7e95897ebf TBR=dtseng@chromium.org,dmazzoni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699617 Review-Url: https://codereview.chromium.org/2827103003 Cr-Commit-Position: refs/heads/master@{#465839} Committed: https://chromium.googlesource.com/chromium/src/+/b255728272ac622014b02d02f22d16d3f493f4ae

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
aboxhall
Created Revert of Finish implementation of automation API hit testing for the desktop.
3 years, 8 months ago (2017-04-20 01:01:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827103003/1
3 years, 8 months ago (2017-04-20 01:03:07 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 01:03:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b255728272ac622014b02d02f22d...

Powered by Google App Engine
This is Rietveld 408576698