Finish implementation of automation API hit testing for the desktop.

Finish implementation of automation API hit testing for the desktop.

This change finishes support for AX_ACTION_HIT_TEST in AXHostDelegate
so that you can send a hit test request on the root of the whole automation
tree and get a hit test on either views or web content.

Switches Select-to-speak to use this new API.  A follow-up change will
change the way select-to-speak works so that it sends the mouse event
to the extension and the hit test comes from there, but this is a
self-contained change that can land first.

BUG=699617
Review-Url: https://codereview.chromium.org/2813083003
Cr-Commit-Position: refs/heads/master@{#465716}
Committed: https://chromium.googlesource.com/chromium/src/+/28ac2d11e80db21b5b7a37968d558c7e95897ebf

[dmazzoni, 2017-04-12 19:26:22]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 19:27:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-04-12 19:34:52]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[dmazzoni, 2017-04-12 19:34:52]

This was split off from a previous change,
I think it will be simpler to review by itself.

[commit-bot: I haz the power, 2017-04-12 21:09:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 21:09:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2017-04-17 15:11:20]

https://codereview.chromium.org/2813083003/diff/1/chrome/browser/chromeos/acc...
File chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
(right):

https://codereview.chromium.org/2813083003/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc:126:
ui::AXHostDelegate* delegate =
I still don't think this is the right direction. We're splitting the
implementation of Select to Speak arbitrarily between js and native. I would
prefer we do it all in native or all in js (with concrete api's in native). If
the latter, the above could be done by installing mouse event handlers and
calling a perform action for hit testing.

[dmazzoni, 2017-04-18 15:59:05]

https://codereview.chromium.org/2813083003/diff/1/chrome/browser/chromeos/acc...
File chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
(right):

https://codereview.chromium.org/2813083003/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc:126:
ui::AXHostDelegate* delegate =
On 2017/04/17 15:11:20, David Tseng wrote:
> I still don't think this is the right direction. We're splitting the
> implementation of Select to Speak arbitrarily between js and native. I would
> prefer we do it all in native or all in js (with concrete api's in native). If
> the latter, the above could be done by installing mouse event handlers and
> calling a perform action for hit testing.

I'm sorry if I wasn't clear in my response, but I agree
and that's exactly the state we'll be in after this
follow-up lands:

https://codereview.chromium.org/2814213002/

All I'm trying to do is split it up into pieces so
that each change isn't trying to do too many things
at the same time.

Also, that change is blocked and can't land yet.

Please take a look at both changes to see the big
picture and then consider whether this change is
reasonable in that context.

[David Tseng, 2017-04-18 18:23:19]

lgtm

https://codereview.chromium.org/2813083003/diff/1/chrome/browser/chromeos/acc...
File chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
(right):

https://codereview.chromium.org/2813083003/diff/1/chrome/browser/chromeos/acc...
chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc:126:
ui::AXHostDelegate* delegate =
Yes, sorry, I missed the other change.

This change is fine as a temporary step. The other change is definitely what I
wanted and thanks for doing it!

[dmazzoni, 2017-04-19 18:02:50]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2017-04-19 18:02:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/2813083003/#ps20001
(title: "Delete test that won't be relevant soon anyway")

[commit-bot: I haz the power, 2017-04-19 18:03:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 19:53:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492624970937320,
"parent_rev": "88d101dc26621ff440fc6a41f88ef932d48bb2b3", "commit_rev":
"28ac2d11e80db21b5b7a37968d558c7e95897ebf"}

[commit-bot: I haz the power, 2017-04-19 19:53:40]

Description was changed from

==========
Finish implementation of automation API hit testing for the desktop.

This change finishes support for AX_ACTION_HIT_TEST in AXHostDelegate
so that you can send a hit test request on the root of the whole automation
tree and get a hit test on either views or web content.

Switches Select-to-speak to use this new API.  A follow-up change will
change the way select-to-speak works so that it sends the mouse event
to the extension and the hit test comes from there, but this is a
self-contained change that can land first.

BUG=699617
==========

to

==========
Finish implementation of automation API hit testing for the desktop.

This change finishes support for AX_ACTION_HIT_TEST in AXHostDelegate
so that you can send a hit test request on the root of the whole automation
tree and get a hit test on either views or web content.

Switches Select-to-speak to use this new API.  A follow-up change will
change the way select-to-speak works so that it sends the mouse event
to the extension and the hit test comes from there, but this is a
self-contained change that can land first.

BUG=699617

Review-Url: https://codereview.chromium.org/2813083003
Cr-Commit-Position: refs/heads/master@{#465716}
Committed:
https://chromium.googlesource.com/chromium/src/+/28ac2d11e80db21b5b7a37968d55...
==========

[commit-bot: I haz the power, 2017-04-19 19:53:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/28ac2d11e80db21b5b7a37968d55...

[aboxhall, 2017-04-20 01:01:44]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2827103003/ by aboxhall@chromium.org.

The reason for reverting is: DesktopHitTest is failing on MSan builder:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=Au....