Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2826893003: Remove ScrollableArea::GetFrameViewBase and move ScheduleAnimation into subclasses. (Closed)
Patch Set: Remove UNREACHED Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index b5df8d33df311f14c23e02e6b2b424dcc3360931..84e1a73ecda8583b3cac9c897bade92fdeb3e0b8 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -164,11 +164,11 @@ class InspectorOverlay::InspectorOverlayChromeClient final
void InvalidateRect(const IntRect&) override { overlay_->Invalidate(); }
- void ScheduleAnimation(FrameViewBase* frame_view_base) override {
+ void ScheduleAnimation(LocalFrame* frame) override {
if (overlay_->in_layout_)
return;
- client_->ScheduleAnimation(frame_view_base);
+ client_->ScheduleAnimation(frame);
}
private:
@@ -401,10 +401,12 @@ void InspectorOverlay::ScheduleUpdate() {
return;
}
needs_update_ = true;
- FrameView* view = frame_impl_->GetFrameView();
LocalFrame* frame = frame_impl_->GetFrame();
- if (view && frame)
- frame->GetPage()->GetChromeClient().ScheduleAnimation(view);
+ if (frame) {
+ // TODO(joelhockey): Remove this check once all tests pass.
dcheng 2017/04/19 11:26:25 I don't think I understand this comment. Presumabl
joelhockey 2017/04/19 11:33:18 Thanks for picking this up. I'll send a fix now.
+ CHECK(frame_impl_->GetFrameView());
+ frame->GetPage()->GetChromeClient().ScheduleAnimation(frame);
+ }
}
void InspectorOverlay::RebuildOverlayPage() {

Powered by Google App Engine
This is Rietveld 408576698