third_party/WebKit/Source/web/WebPagePopupImpl.cpp - Issue 2826893003: Remove ScrollableArea::GetFrameViewBase and move ScheduleAnimation into subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2826893003: Remove ScrollableArea::GetFrameViewBase and move ScheduleAnimation into subclasses. (Closed)

Patch Set: Remove UNREACHED Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

index 5b57a8f4930be68a49ccad4d03003b6a5791e371..ab2b59a276f542057b8ac923b3e9a7477f15cc18 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

@@ -123,7 +123,7 @@ class PagePopupChromeClient final : public EmptyChromeClient {

popup_->WidgetClient()->DidInvalidateRect(paint_rect);

}

- void ScheduleAnimation(FrameViewBase*) override {

+ void ScheduleAnimation(LocalFrame*) override {

// Calling scheduleAnimation on m_webView so WebViewTestProxy will call

// beginFrame.

if (LayoutTestSupport::IsRunningLayoutTest())