Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2826893003: Remove ScrollableArea::GetFrameViewBase and move ScheduleAnimation into subclasses. (Closed)
Patch Set: Remove UNREACHED Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
index ba81ee3a20eb003130bbfc994b4c0251fd9e6afe..4c28a1abef6c366ce85b81abf1bf30a4b8fc5b08 100644
--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp
+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp
@@ -554,11 +554,8 @@ void ChromeClientImpl::InvalidateRect(const IntRect& update_rect) {
web_view_->InvalidateRect(update_rect);
}
-void ChromeClientImpl::ScheduleAnimation(FrameViewBase* frame_view_base) {
- DCHECK(frame_view_base->IsFrameView());
- FrameView* view = ToFrameView(frame_view_base);
- LocalFrame* frame = view->GetFrame().LocalFrameRoot();
-
+void ChromeClientImpl::ScheduleAnimation(LocalFrame* frame) {
+ frame = frame->LocalFrameRoot();
// If the frame is still being created, it might not yet have a WebWidget.
// FIXME: Is this the right thing to do? Is there a way to avoid having
// a local frame root that doesn't have a WebWidget? During initialization

Powered by Google App Engine
This is Rietveld 408576698