Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2826773002: Rename CanvasPathMethods to CanvasPath (Closed)

Created:
3 years, 8 months ago by fserb
Modified:
3 years, 8 months ago
Reviewers:
esprehn, Justin Novosad
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, Rik, chromium-reviews, dshwang, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename CanvasPathMethods to CanvasPath The spec calls this CanvasPath. Renaming to sync with spec. BUG=708195 Review-Url: https://codereview.chromium.org/2826773002 Cr-Commit-Position: refs/heads/master@{#465699} Committed: https://chromium.googlesource.com/chromium/src/+/e51782890830ad8e709199ad65ce66e52af90441

Patch Set 1 #

Patch Set 2 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -601 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/canvas-arc-negative-radius.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-ellipse-negative-radius.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/modules/canvas2d/CanvasPath.h View 3 chunks +6 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/modules/canvas2d/CanvasPath.cpp View 15 chunks +63 lines, -63 lines 0 comments Download
A + third_party/WebKit/Source/modules/canvas2d/CanvasPath.idl View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/modules/canvas2d/CanvasPathMethods.h View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/WebKit/Source/modules/canvas2d/CanvasPathMethods.cpp View 1 chunk +0 lines, -389 lines 0 comments Download
D third_party/WebKit/Source/modules/canvas2d/CanvasPathMethods.idl View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/Path2D.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/Path2D.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Path.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Path.cpp View 1 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
fserb
Present Fernando sending a gift to future Justin! Welcome back, future Justin!
3 years, 8 months ago (2017-04-18 20:23:12 UTC) #2
Justin Novosad
lgtm
3 years, 8 months ago (2017-04-19 01:46:54 UTC) #7
Justin Novosad
Reason for compile error on builds with DCHECKs disabled: https://cs.chromium.org/chromium/src/base/logging.h?type=cs&l=834 It seems DCHECK will compile ...
3 years, 8 months ago (2017-04-19 02:02:04 UTC) #8
fserb
On 2017/04/19 at 02:02:04, junov wrote: > Reason for compile error on builds with DCHECKs ...
3 years, 8 months ago (2017-04-19 17:16:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826773002/20001
3 years, 8 months ago (2017-04-19 17:16:41 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/415313)
3 years, 8 months ago (2017-04-19 17:27:26 UTC) #14
fserb
esprehn: third_party/WebKit/Source/modules/modules_idl_files.gni
3 years, 8 months ago (2017-04-19 17:34:36 UTC) #16
esprehn
lgtm
3 years, 8 months ago (2017-04-19 17:46:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826773002/20001
3 years, 8 months ago (2017-04-19 17:52:29 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 19:18:14 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e51782890830ad8e709199ad65ce...

Powered by Google App Engine
This is Rietveld 408576698