Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2826743003: Revert of Introduce mkgrokdump to update tools/v8heapconst.py. (Closed)

Created:
3 years, 8 months ago by Michael Achenbach
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Introduce mkgrokdump to update tools/v8heapconst.py. (patchset #21 id:390001 of https://codereview.chromium.org/2809653003/ ) Reason for revert: Test driver runs into assert: https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/17082 Original issue's description: > Introduce mkgrokdump to update tools/v8heapconst.py. > > - Migrate make grokdump to GYP and GN > - Move code from d8 into stand-alone execution > - Add test case to ensure it's up-to-date > > Review-Url: https://codereview.chromium.org/2809653003 > Cr-Original-Commit-Position: refs/heads/master@{#44687} > Committed: https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df5e42a > Review-Url: https://codereview.chromium.org/2809653003 > Cr-Commit-Position: refs/heads/master@{#44710} > Committed: https://chromium.googlesource.com/v8/v8/+/477f00557458d383bd9ebef281890ba485ee882a TBR=mstarzinger@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2826743003 Cr-Commit-Position: refs/heads/master@{#44711} Committed: https://chromium.googlesource.com/v8/v8/+/84b22eb29f5de16413ed109f47572256231887b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -610 lines) Patch
M Makefile View 2 chunks +7 lines, -0 lines 0 comments Download
M gypfiles/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/d8.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/d8.cc View 3 chunks +75 lines, -0 lines 0 comments Download
M src/heap/heap.h View 6 chunks +67 lines, -96 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/BUILD.gn View 3 chunks +0 lines, -10 lines 0 comments Download
M test/bot_default.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M test/default.isolate View 1 chunk +0 lines, -1 line 0 comments Download
D test/mkgrokdump/BUILD.gn View 1 chunk +0 lines, -27 lines 0 comments Download
D test/mkgrokdump/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D test/mkgrokdump/mkgrokdump.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D test/mkgrokdump/mkgrokdump.gyp View 1 chunk +0 lines, -46 lines 0 comments Download
D test/mkgrokdump/mkgrokdump.isolate View 1 chunk +0 lines, -17 lines 0 comments Download
D test/mkgrokdump/mkgrokdump.status View 1 chunk +0 lines, -10 lines 0 comments Download
D test/mkgrokdump/testcfg.py View 1 chunk +0 lines, -45 lines 0 comments Download
M tools/run-tests.py View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/v8heapconst.py View 6 chunks +227 lines, -217 lines 0 comments Download
A tools/v8heapconst.py.tmpl View 1 chunk +30 lines, -0 lines 0 comments Download
M tools/verify_source_deps.py View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of Introduce mkgrokdump to update tools/v8heapconst.py.
3 years, 8 months ago (2017-04-19 07:02:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826743003/1
3 years, 8 months ago (2017-04-19 07:02:53 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 07:03:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/84b22eb29f5de16413ed109f47572256231...

Powered by Google App Engine
This is Rietveld 408576698