Introduce mkgrokdump to update tools/v8heapconst.py.

Introduce mkgrokdump to update tools/v8heapconst.py.

- Migrate make grokdump to GYP and GN
- Move code from d8 into stand-alone execution
- Add test case to ensure it's up-to-date

Review-Url: https://codereview.chromium.org/2809653003
Cr-Original-Original-Commit-Position: refs/heads/master@{#44687}
Committed: https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df5e42a
Review-Url: https://codereview.chromium.org/2809653003
Cr-Original-Commit-Position: refs/heads/master@{#44710}
Committed: https://chromium.googlesource.com/v8/v8/+/477f00557458d383bd9ebef281890ba485ee882a
Review-Url: https://codereview.chromium.org/2809653003
Cr-Commit-Position: refs/heads/master@{#44738}
Committed: https://chromium.googlesource.com/v8/v8/+/9d71683e115d3ec9a99552580b47531b7147d626

[Yang, 2017-04-11 09:30:39]

yangguo@chromium.org changed reviewers:
+ machenbach@chromium.org, mstarzinger@chromium.org

[Yang, 2017-04-11 09:30:40]

Please take a look.

[Michael Starzinger, 2017-04-11 09:42:39]

https://codereview.chromium.org/2809653003/diff/1/test/v8heapconst/testcfg.py
File test/v8heapconst/testcfg.py (right):

https://codereview.chromium.org/2809653003/diff/1/test/v8heapconst/testcfg.py...
test/v8heapconst/testcfg.py:11: class V8HeapConst(testsuite.TestSuite):
How would you feel about calling this test suite (and the directory it resides
in) "grokdump" or "mkgrokdump" instead?

https://codereview.chromium.org/2809653003/diff/1/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/2809653003/diff/1/tools/run-tests.py#newcode66
tools/run-tests.py:66: # This needs to stay in sync with
test/bot_default.isolate.
According to this comment, something has to be kept in sync. Is this actionable
for this CL? I'll defer to Michael Achenbach on this.

https://codereview.chromium.org/2809653003/diff/1/tools/run-tests.py#newcode80
tools/run-tests.py:80: # This needs to stay in sync with test/default.isolate.
Likewise.

[Michael Achenbach, 2017-04-11 09:45:54]

https://codereview.chromium.org/2809653003/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2809653003/diff/1/BUILD.gn#newcode2670
BUILD.gn:2670: v8_executable("mkgrokdump") {
Note that due to GN's nature, this target will be built everywhere where all or
no target is specified. Also in Chromium.

Maybe also add it to:
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/archive/r...

https://codereview.chromium.org/2809653003/diff/1/BUILD.gn#newcode2706
BUILD.gn:2706: ":d8",
Maybe add it here if it's supposed to be always built.

https://codereview.chromium.org/2809653003/diff/1/test/v8heapconst/testcfg.py
File test/v8heapconst/testcfg.py (right):

https://codereview.chromium.org/2809653003/diff/1/test/v8heapconst/testcfg.py...
test/v8heapconst/testcfg.py:4: 
THis suite requires .isolate file and linkage to it in the three? isolate
configs in /test/. It also needs a gyp and gn target for swarming. The gyp is
often an extra file while the gn target can be listed in /test/BUILD.gn. See
some other recently added suite like debugger.

https://codereview.chromium.org/2809653003/diff/1/test/v8heapconst/v8heapcons...
File test/v8heapconst/v8heapconst.status (right):

https://codereview.chromium.org/2809653003/diff/1/test/v8heapconst/v8heapcons...
test/v8heapconst/v8heapconst.status:7: ['variant != default', {
nit: You could write it in one line:
variant != default or arch != x64

https://codereview.chromium.org/2809653003/diff/1/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/2809653003/diff/1/tools/run-tests.py#newcode68
tools/run-tests.py:68: "mkgrokdump",
How slow is this test? If it's faster than 1s, maybe rather move this to the
middle field, i.e. after webkit.

[Yang, 2017-04-11 09:57:21]

https://codereview.chromium.org/2809653003/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2809653003/diff/1/BUILD.gn#newcode2670
BUILD.gn:2670: v8_executable("mkgrokdump") {
On 2017/04/11 09:45:54, Michael Achenbach wrote:
> Note that due to GN's nature, this target will be built everywhere where all
or
> no target is specified. Also in Chromium.
> 
> Maybe also add it to:
>
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/archive/r...

Acknowledged.

https://codereview.chromium.org/2809653003/diff/1/BUILD.gn#newcode2706
BUILD.gn:2706: ":d8",
On 2017/04/11 09:45:54, Michael Achenbach wrote:
> Maybe add it here if it's supposed to be always built.

Done.

https://codereview.chromium.org/2809653003/diff/1/test/v8heapconst/testcfg.py
File test/v8heapconst/testcfg.py (right):

https://codereview.chromium.org/2809653003/diff/1/test/v8heapconst/testcfg.py...
test/v8heapconst/testcfg.py:11: class V8HeapConst(testsuite.TestSuite):
On 2017/04/11 09:42:38, Michael Starzinger wrote:
> How would you feel about calling this test suite (and the directory it resides
> in) "grokdump" or "mkgrokdump" instead?

Done.

https://codereview.chromium.org/2809653003/diff/1/test/v8heapconst/v8heapcons...
File test/v8heapconst/v8heapconst.status (right):

https://codereview.chromium.org/2809653003/diff/1/test/v8heapconst/v8heapcons...
test/v8heapconst/v8heapconst.status:7: ['variant != default', {
On 2017/04/11 09:45:54, Michael Achenbach wrote:
> nit: You could write it in one line:
> variant != default or arch != x64

Done.

https://codereview.chromium.org/2809653003/diff/1/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/2809653003/diff/1/tools/run-tests.py#newcode66
tools/run-tests.py:66: # This needs to stay in sync with
test/bot_default.isolate.
On 2017/04/11 09:42:38, Michael Starzinger wrote:
> According to this comment, something has to be kept in sync. Is this
actionable
> for this CL? I'll defer to Michael Achenbach on this.

Done.

https://codereview.chromium.org/2809653003/diff/1/tools/run-tests.py#newcode80
tools/run-tests.py:80: # This needs to stay in sync with test/default.isolate.
On 2017/04/11 09:42:38, Michael Starzinger wrote:
> Likewise.

Done.

[Michael Starzinger, 2017-04-11 10:01:44]

LGTM from my side. Thanks! Please wait for sign-off from Michael Achenbach as
well.

[Michael Achenbach, 2017-04-11 10:53:49]

You'll also need the executable in swarming, e.g. an equivalent to
https://cs.chromium.org/chromium/src/v8/src/d8.isolate?q=d8.isolate+package:%...
- which you can also add to the isolate in the test suite.

You'll still need something like
https://cs.chromium.org/chromium/src/v8/test/BUILD.gn?l=13 - see inspector
there. And for gyp something like:
https://cs.chromium.org/chromium/src/v8/test/inspector/inspector.gyp?l=31

[Michael Achenbach, 2017-04-11 10:56:18]

https://codereview.chromium.org/2809653003/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2809653003/diff/40001/BUILD.gn#newcode145
BUILD.gn:145: v8_generated_heap_constants = "$target_gen_dir/v8heapconst.py"
Who's reading this?

[Yang, 2017-04-12 10:32:38]

machenbach@: please take another look!

https://codereview.chromium.org/2809653003/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2809653003/diff/40001/BUILD.gn#newcode145
BUILD.gn:145: v8_generated_heap_constants = "$target_gen_dir/v8heapconst.py"
On 2017/04/11 10:56:17, Michael Achenbach wrote:
> Who's reading this?

Removed. I had a run_mkgrokdump target at some point that I removed.

[Michael Achenbach, 2017-04-12 12:33:42]

Trying to run a trybot to check how this looks...

https://codereview.chromium.org/2809653003/diff/60001/test/BUILD.gn
File test/BUILD.gn (right):

https://codereview.chromium.org/2809653003/diff/60001/test/BUILD.gn#newcode152
test/BUILD.gn:152: v8_isolate_run("message") {
You might need an entry v8_isolate_run for this too? Similar to this but with
deps pointing to the mkgrokdump target instead.

I'm a bit puzzled right now why I don't see this for debugger, hmmmm.

[Michael Achenbach, 2017-04-12 12:37:42]

On 2017/04/12 12:33:42, Michael Achenbach wrote:
> Trying to run a trybot to check how this looks...
> 
> https://codereview.chromium.org/2809653003/diff/60001/test/BUILD.gn
> File test/BUILD.gn (right):
> 
> https://codereview.chromium.org/2809653003/diff/60001/test/BUILD.gn#newcode152
> test/BUILD.gn:152: v8_isolate_run("message") {
> You might need an entry v8_isolate_run for this too? Similar to this but with
> deps pointing to the mkgrokdump target instead.
> 
> I'm a bit puzzled right now why I don't see this for debugger, hmmmm.

Ah, maybe that's not necessary as long as bot_default_run target is used. Seems
like the single *_run targets are only necessary if you want to compile and use
them in isolation.

[Michael Achenbach, 2017-04-12 12:39:12]

https://codereview.chromium.org/2809653003/diff/60001/test/BUILD.gn
File test/BUILD.gn (right):

https://codereview.chromium.org/2809653003/diff/60001/test/BUILD.gn#newcode51
test/BUILD.gn:51: ":mkgrokdump_run",
See build failure: I assume :mkgrokdump_run can be removed, since the
mkgrokdump.isolate is included in default.isolate. Or add a v8_isolate_run
target for mkgrokdump in this file.

[Yang, 2017-04-13 12:00:57]

YES! Finally works! Look at what I did!

[Yang, 2017-04-13 12:03:12]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 12:03:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 12:11:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 12:11:53]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Michael Achenbach, 2017-04-13 12:12:35]

lgtm, lets also verify that the test ran, e.g. search it in the output of the
test step in one of the triggered bots.

https://codereview.chromium.org/2809653003/diff/140001/test/BUILD.gn
File test/BUILD.gn (right):

https://codereview.chromium.org/2809653003/diff/140001/test/BUILD.gn#newcode201
test/BUILD.gn:201: v8_isolate_run("mkgrokdump") {
nit: The others are somewhat alpha sorted. Maybe move up?

[Yang, 2017-04-13 12:27:55]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 12:28:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-04-13 12:28:45]

On 2017/04/13 12:12:35, Michael Achenbach wrote:
> lgtm, lets also verify that the test ran, e.g. search it in the output of the
> test step in one of the triggered bots.

One triggered x64 bot failed because the test worked. Updating test
expectations.

> 
> https://codereview.chromium.org/2809653003/diff/140001/test/BUILD.gn
> File test/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2809653003/diff/140001/test/BUILD.gn#newcode201
> test/BUILD.gn:201: v8_isolate_run("mkgrokdump") {
> nit: The others are somewhat alpha sorted. Maybe move up?

Done.

[commit-bot: I haz the power, 2017-04-13 12:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 12:29:31]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/20953)

[Yang, 2017-04-13 12:31:40]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 12:31:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 12:39:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 12:39:25]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Yang, 2017-04-18 09:01:45]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 09:01:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-04-18 09:16:33]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 09:16:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-04-18 09:33:24]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 09:33:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 10:03:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 10:03:14]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[Yang, 2017-04-18 13:12:23]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 13:12:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2017-04-18 13:14:16]

The CQ bit was unchecked by yangguo@chromium.org

[Yang, 2017-04-18 13:20:30]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 13:20:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 13:46:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 13:46:07]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-04-18 14:02:28]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-04-18 14:02:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2809653003/#ps350001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-18 14:02:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 14:05:28]

CQ is committing da patch.

Bot data: {"patchset_id": 350001, "attempt_start_ts": 1492524148364360,
"parent_rev": "81a0104540000e35e6837da0f4f399a6532c465c", "commit_rev":
"0cc0c130fa56f129c90c2a74cb01bda85df5e42a"}

[commit-bot: I haz the power, 2017-04-18 14:05:34]

Description was changed from

==========
Introduce mkgrokdump to update tools/v8heapconst.py.

- Migrate make grokdump to GYP and GN
- Move code from d8 into stand-alone execution
- Add test case to ensure it's up-to-date
==========

to

==========
Introduce mkgrokdump to update tools/v8heapconst.py.

- Migrate make grokdump to GYP and GN
- Move code from d8 into stand-alone execution
- Add test case to ensure it's up-to-date

Review-Url: https://codereview.chromium.org/2809653003
Cr-Commit-Position: refs/heads/master@{#44687}
Committed:
https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df...
==========

[commit-bot: I haz the power, 2017-04-18 14:05:35]

Committed patchset #19 (id:350001) as
https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df...

[Yang, 2017-04-18 14:40:56]

A revert of this CL (patchset #19 id:350001) has been created in
https://codereview.chromium.org/2824853003/ by yangguo@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/17063/steps/....

[Yang, 2017-04-19 05:17:14]

Description was changed from

==========
Introduce mkgrokdump to update tools/v8heapconst.py.

- Migrate make grokdump to GYP and GN
- Move code from d8 into stand-alone execution
- Add test case to ensure it's up-to-date

Review-Url: https://codereview.chromium.org/2809653003
Cr-Commit-Position: refs/heads/master@{#44687}
Committed:
https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df...
==========

to

==========
Introduce mkgrokdump to update tools/v8heapconst.py.

- Migrate make grokdump to GYP and GN
- Move code from d8 into stand-alone execution
- Add test case to ensure it's up-to-date

Review-Url: https://codereview.chromium.org/2809653003
Cr-Commit-Position: refs/heads/master@{#44687}
Committed:
https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df...
==========

[Yang, 2017-04-19 05:42:42]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-04-19 05:42:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2809653003/#ps390001
(title: "attempted fix")

[commit-bot: I haz the power, 2017-04-19 05:42:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 06:10:16]

CQ is committing da patch.

Bot data: {"patchset_id": 390001, "attempt_start_ts": 1492580562733630,
"parent_rev": "07e163bd5ac87cfb9539dfe3c2b0b1337e97985a", "commit_rev":
"477f00557458d383bd9ebef281890ba485ee882a"}

[commit-bot: I haz the power, 2017-04-19 06:10:23]

Description was changed from

==========
Introduce mkgrokdump to update tools/v8heapconst.py.

- Migrate make grokdump to GYP and GN
- Move code from d8 into stand-alone execution
- Add test case to ensure it's up-to-date

Review-Url: https://codereview.chromium.org/2809653003
Cr-Commit-Position: refs/heads/master@{#44687}
Committed:
https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df...
==========

to

==========
Introduce mkgrokdump to update tools/v8heapconst.py.

- Migrate make grokdump to GYP and GN
- Move code from d8 into stand-alone execution
- Add test case to ensure it's up-to-date

Review-Url: https://codereview.chromium.org/2809653003
Cr-Original-Commit-Position: refs/heads/master@{#44687}
Committed:
https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df...
Review-Url: https://codereview.chromium.org/2809653003
Cr-Commit-Position: refs/heads/master@{#44710}
Committed:
https://chromium.googlesource.com/v8/v8/+/477f00557458d383bd9ebef281890ba485e...
==========

[commit-bot: I haz the power, 2017-04-19 06:10:24]

Committed patchset #21 (id:390001) as
https://chromium.googlesource.com/v8/v8/+/477f00557458d383bd9ebef281890ba485e...

[Michael Achenbach, 2017-04-19 07:02:43]

A revert of this CL (patchset #21 id:390001) has been created in
https://codereview.chromium.org/2826743003/ by machenbach@chromium.org.

The reason for reverting is: Test driver runs into assert:
https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/17082.

[Michael Achenbach, 2017-04-19 07:04:29]

https://codereview.chromium.org/2809653003/diff/390001/test/mkgrokdump/testcf...
File test/mkgrokdump/testcfg.py (right):

https://codereview.chromium.org/2809653003/diff/390001/test/mkgrokdump/testcf...
test/mkgrokdump/testcfg.py:33: assert "generated from a shipping build" in
output.stdout
Don't use assert statements here as they bypass the standard pass/fail logic of
the test driver. Rather return True and add useful output.

[Yang, 2017-04-19 07:51:51]

Description was changed from

==========
Introduce mkgrokdump to update tools/v8heapconst.py.

- Migrate make grokdump to GYP and GN
- Move code from d8 into stand-alone execution
- Add test case to ensure it's up-to-date

Review-Url: https://codereview.chromium.org/2809653003
Cr-Original-Commit-Position: refs/heads/master@{#44687}
Committed:
https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df...
Review-Url: https://codereview.chromium.org/2809653003
Cr-Commit-Position: refs/heads/master@{#44710}
Committed:
https://chromium.googlesource.com/v8/v8/+/477f00557458d383bd9ebef281890ba485e...
==========

to

==========
Introduce mkgrokdump to update tools/v8heapconst.py.

- Migrate make grokdump to GYP and GN
- Move code from d8 into stand-alone execution
- Add test case to ensure it's up-to-date

Review-Url: https://codereview.chromium.org/2809653003
Cr-Original-Commit-Position: refs/heads/master@{#44687}
Committed:
https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df...
Review-Url: https://codereview.chromium.org/2809653003
Cr-Commit-Position: refs/heads/master@{#44710}
Committed:
https://chromium.googlesource.com/v8/v8/+/477f00557458d383bd9ebef281890ba485e...
==========

[Yang, 2017-04-20 05:16:21]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-04-20 05:16:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2809653003/#ps520001
(title: "remove infra hack")

[commit-bot: I haz the power, 2017-04-20 05:16:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 06:14:54]

CQ is committing da patch.

Bot data: {"patchset_id": 520001, "attempt_start_ts": 1492665381864650,
"parent_rev": "6b8f22bab3062f9c5d6bc5a0f8e178a04d32dcb6", "commit_rev":
"d8797d917c782884fa23626ce446bba4a49ef846"}

[commit-bot: I haz the power, 2017-04-20 06:15:03]

CQ is committing da patch.

Bot data: {"patchset_id": 520001, "attempt_start_ts": 1492665381864650,
"parent_rev": "08d5729ad9bbe581825ab37bcc6993195cde0e4b", "commit_rev":
"9d71683e115d3ec9a99552580b47531b7147d626"}

[commit-bot: I haz the power, 2017-04-20 06:15:09]

Description was changed from

==========
Introduce mkgrokdump to update tools/v8heapconst.py.

- Migrate make grokdump to GYP and GN
- Move code from d8 into stand-alone execution
- Add test case to ensure it's up-to-date

Review-Url: https://codereview.chromium.org/2809653003
Cr-Original-Commit-Position: refs/heads/master@{#44687}
Committed:
https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df...
Review-Url: https://codereview.chromium.org/2809653003
Cr-Commit-Position: refs/heads/master@{#44710}
Committed:
https://chromium.googlesource.com/v8/v8/+/477f00557458d383bd9ebef281890ba485e...
==========

to

==========
Introduce mkgrokdump to update tools/v8heapconst.py.

- Migrate make grokdump to GYP and GN
- Move code from d8 into stand-alone execution
- Add test case to ensure it's up-to-date

Review-Url: https://codereview.chromium.org/2809653003
Cr-Original-Original-Commit-Position: refs/heads/master@{#44687}
Committed:
https://chromium.googlesource.com/v8/v8/+/0cc0c130fa56f129c90c2a74cb01bda85df...
Review-Url: https://codereview.chromium.org/2809653003
Cr-Original-Commit-Position: refs/heads/master@{#44710}
Committed:
https://chromium.googlesource.com/v8/v8/+/477f00557458d383bd9ebef281890ba485e...
Review-Url: https://codereview.chromium.org/2809653003
Cr-Commit-Position: refs/heads/master@{#44738}
Committed:
https://chromium.googlesource.com/v8/v8/+/9d71683e115d3ec9a99552580b47531b714...
==========

[commit-bot: I haz the power, 2017-04-20 06:15:10]

Committed patchset #28 (id:520001) as
https://chromium.googlesource.com/v8/v8/+/9d71683e115d3ec9a99552580b47531b714...