Fix recursion in handling touch input events acks.

Fix recursion in handling touch input events acks.

Event ack notification could cause some issues due to recursion. Add a
test ensuring that the recursion doesn't occur.

BUG=711325
Review-Url: https://codereview.chromium.org/2826673005
Cr-Commit-Position: refs/heads/master@{#465367}
Committed: https://chromium.googlesource.com/chromium/src/+/7df0af6216babebfbe1a71090bac6b8397d9ae7c

[dtapuska, 2017-04-18 17:30:30]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 17:31:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 18:22:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 18:22:55]

Dry run: This issue passed the CQ dry run.

[dtapuska, 2017-04-18 18:33:40]

Description was changed from

==========
Fix recursion in handling touch input events acks.

Event ack notification could cause some issues due to recursion. Add a
test ensuring that the recursion doesn't occur.

BUG=711325
==========

to

==========
Fix recursion in handling touch input events acks.

Event ack notification could cause some issues due to recursion. Add a
test ensuring that the recursion doesn't occur.

BUG=711325
==========

[dtapuska, 2017-04-18 18:33:40]

dtapuska@chromium.org changed reviewers:
+ tdresser@chromium.org

[tdresser, 2017-04-18 18:57:03]

LGTM, thanks!

https://codereview.chromium.org/2826673005/diff/20001/content/browser/rendere...
File
content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc
(right):

https://codereview.chromium.org/2826673005/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc:773:
SendTouchEventAckLast(INPUT_EVENT_ACK_STATE_CONSUMED);
Can you comment that this will ack the touchmove, leaving it blocked behind the
touchstart?

https://codereview.chromium.org/2826673005/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc:781:
// Note, this will be triggered by all subsequent touch acks.
I don't quite understand "this will be triggered by all subsequent touch acks".

Won't it be triggered by _the_ subsequent touch ack?

https://codereview.chromium.org/2826673005/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc:818:
;
While you're here, can you remove this extra ; ?

[dtapuska, 2017-04-18 19:56:52]

https://codereview.chromium.org/2826673005/diff/20001/content/browser/rendere...
File
content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc
(right):

https://codereview.chromium.org/2826673005/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc:773:
SendTouchEventAckLast(INPUT_EVENT_ACK_STATE_CONSUMED);
On 2017/04/18 18:57:02, tdresser wrote:
> Can you comment that this will ack the touchmove, leaving it blocked behind
the
> touchstart?

Done.

https://codereview.chromium.org/2826673005/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc:781:
// Note, this will be triggered by all subsequent touch acks.
On 2017/04/18 18:57:02, tdresser wrote:
> I don't quite understand "this will be triggered by all subsequent touch
acks".
> 
> Won't it be triggered by _the_ subsequent touch ack?

Done.

https://codereview.chromium.org/2826673005/diff/20001/content/browser/rendere...
content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc:818:
;
On 2017/04/18 18:57:03, tdresser wrote:
> While you're here, can you remove this extra ; ?

Done.

[dtapuska, 2017-04-18 19:57:03]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2017-04-18 19:57:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2826673005/#ps40001
(title: "Fix nits")

[commit-bot: I haz the power, 2017-04-18 19:57:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 20:57:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492545423174240,
"parent_rev": "573a8dbbbe14ecb45fd0cb850f682721b906b25c", "commit_rev":
"7df0af6216babebfbe1a71090bac6b8397d9ae7c"}

[commit-bot: I haz the power, 2017-04-18 20:57:21]

Description was changed from

==========
Fix recursion in handling touch input events acks.

Event ack notification could cause some issues due to recursion. Add a
test ensuring that the recursion doesn't occur.

BUG=711325
==========

to

==========
Fix recursion in handling touch input events acks.

Event ack notification could cause some issues due to recursion. Add a
test ensuring that the recursion doesn't occur.

BUG=711325

Review-Url: https://codereview.chromium.org/2826673005
Cr-Commit-Position: refs/heads/master@{#465367}
Committed:
https://chromium.googlesource.com/chromium/src/+/7df0af6216babebfbe1a71090bac...
==========

[commit-bot: I haz the power, 2017-04-18 20:57:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7df0af6216babebfbe1a71090bac...