Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2822293002: Fix latency info tracking for coalesced events. (Closed)

Created:
3 years, 8 months ago by dtapuska
Modified:
3 years, 8 months ago
Reviewers:
tdresser
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix latency info tracking for coalesced events. Keep the oldest touch event id so the latency info will be associated with that object. Don't adjust the dispatch type for an event that gets coalesced since it it should carry the same type as the touch id ack. BUG=711325 Review-Url: https://codereview.chromium.org/2822293002 Cr-Commit-Position: refs/heads/master@{#465457} Committed: https://chromium.googlesource.com/chromium/src/+/401d48085b5a5db8bab875c9a6732f61f23a42b1

Patch Set 1 #

Patch Set 2 : Write a legible comment #

Patch Set 3 : Fix unittest #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M content/renderer/input/main_thread_event_queue.cc View 1 2 chunks +4 lines, -5 lines 1 comment Download
M content/renderer/input/main_thread_event_queue_unittest.cc View 1 2 2 chunks +7 lines, -8 lines 0 comments Download
M ui/events/blink/blink_event_util.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (11 generated)
dtapuska
PTAL
3 years, 8 months ago (2017-04-18 20:03:05 UTC) #4
tdresser
LGTM https://codereview.chromium.org/2822293002/diff/40001/content/renderer/input/main_thread_event_queue.cc File content/renderer/input/main_thread_event_queue.cc (left): https://codereview.chromium.org/2822293002/diff/40001/content/renderer/input/main_thread_event_queue.cc#oldcode95 content/renderer/input/main_thread_event_queue.cc:95: originally_cancelable_ = other_event.originally_cancelable_; Is this correct? I would ...
3 years, 8 months ago (2017-04-18 20:43:39 UTC) #8
dtapuska
On 2017/04/18 20:43:39, tdresser wrote: > LGTM > > https://codereview.chromium.org/2822293002/diff/40001/content/renderer/input/main_thread_event_queue.cc > File content/renderer/input/main_thread_event_queue.cc (left): > ...
3 years, 8 months ago (2017-04-18 20:54:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822293002/40001
3 years, 8 months ago (2017-04-19 01:24:35 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 01:28:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/401d48085b5a5db8bab875c9a673...

Powered by Google App Engine
This is Rietveld 408576698