Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2826593003: Fix reload in AutoReload (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix reload in AutoReload When the -reload method of tab was removed, AutoReloadBridge was not updated. This CL uses the new method to reload the tab. BUG=712614 Review-Url: https://codereview.chromium.org/2826593003 Cr-Commit-Position: refs/heads/master@{#465527} Committed: https://chromium.googlesource.com/chromium/src/+/156fad6be9bcf46c9c312fa7da92fd97b48e4bc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ios/chrome/browser/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/web/auto_reload_bridge.mm View 2 chunks +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
gambard
PTAL. This was probably caused by https://codereview.chromium.org/2741413007
3 years, 8 months ago (2017-04-18 11:37:45 UTC) #2
sdefresne
On 2017/04/18 11:37:45, gambard wrote: > PTAL. This was probably caused by https://codereview.chromium.org/2741413007 BTW, the ...
3 years, 8 months ago (2017-04-18 14:27:32 UTC) #3
sdefresne
lgtm
3 years, 8 months ago (2017-04-18 14:27:46 UTC) #5
Eugene But (OOO till 7-30)
lgtm, thank you for fixing this!
3 years, 8 months ago (2017-04-18 15:48:54 UTC) #6
liaoyuke
On 2017/04/18 15:48:54, Eugene But wrote: > lgtm, thank you for fixing this! lgtm, thanks ...
3 years, 8 months ago (2017-04-18 21:35:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826593003/1
3 years, 8 months ago (2017-04-19 06:46:36 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 08:12:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/156fad6be9bcf46c9c312fa7da92...

Powered by Google App Engine
This is Rietveld 408576698