[ObjC ARC] Converts ios/chrome/browser/web:web_internal to ARC.

[ObjC ARC] Converts ios/chrome/browser/web:web_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2823953004
Cr-Commit-Position: refs/heads/master@{#466277}
Committed: https://chromium.googlesource.com/chromium/src/+/bbdc3a57db54f6c15e343173885ba78b49b60730

[gambard, 2017-04-18 11:54:28]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 11:54:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 12:53:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 12:53:04]

Dry run: This issue passed the CQ dry run.

[gambard, 2017-04-18 13:20:59]

gambard@chromium.org changed reviewers:
+ eugenebut@chromium.org, stkhapugin@chromium.org

[gambard, 2017-04-18 13:21:00]

PTAL.

[Eugene But (OOO till 7-30), 2017-04-18 15:44:44]

lgtm

https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/erro...
File ios/chrome/browser/web/error_page_generator.mm (right):

https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/erro...
ios/chrome/browser/web/error_page_generator.mm:27: NSString* html_;
Since you touching this, would you mind s/html_/_HTML ?

[stkhapugin, 2017-04-19 16:42:34]

https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/auto...
File ios/chrome/browser/web/auto_reload_bridge.mm (right):

https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/auto...
ios/chrome/browser/web/auto_reload_bridge.mm:49: AutoReloadBridge* bridge_;
This went from __unsafe_unretained to __strong, is this desired?

https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/auto...
File ios/chrome/browser/web/auto_reload_controller.mm (right):

https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/auto...
ios/chrome/browser/web/auto_reload_controller.mm:34: id<AutoReloadDelegate>
_delegate;
This should be __weak

[gambard, 2017-04-20 08:25:48]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 08:26:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gambard, 2017-04-20 08:31:40]

C++ code under ARC have the same behavior as objective C (i.e. strong reference
on Objective-C ivar)?

https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/auto...
File ios/chrome/browser/web/auto_reload_bridge.mm (right):

https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/auto...
ios/chrome/browser/web/auto_reload_bridge.mm:49: AutoReloadBridge* bridge_;
On 2017/04/19 16:42:34, stkhapugin wrote:
> This went from __unsafe_unretained to __strong, is this desired?

Done.

https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/auto...
File ios/chrome/browser/web/auto_reload_controller.mm (right):

https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/auto...
ios/chrome/browser/web/auto_reload_controller.mm:34: id<AutoReloadDelegate>
_delegate;
On 2017/04/19 16:42:34, stkhapugin wrote:
> This should be __weak

Done.

https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/erro...
File ios/chrome/browser/web/error_page_generator.mm (right):

https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/erro...
ios/chrome/browser/web/error_page_generator.mm:27: NSString* html_;
On 2017/04/18 15:44:43, Eugene But wrote:
> Since you touching this, would you mind s/html_/_HTML ?

Done.

[sdefresne, 2017-04-20 09:26:30]

On 2017/04/20 08:31:40, gambard wrote:
> C++ code under ARC have the same behavior as objective C (i.e. strong
reference
> on Objective-C ivar)?

C++ does not know about Objective-C objects (in fact this is invalid C++ code).
Objective-C++ behaves like Objective-C with or without ARC.

>
https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/auto...
> File ios/chrome/browser/web/auto_reload_bridge.mm (right):
> 
>
https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/auto...
> ios/chrome/browser/web/auto_reload_bridge.mm:49: AutoReloadBridge* bridge_;
> On 2017/04/19 16:42:34, stkhapugin wrote:
> > This went from __unsafe_unretained to __strong, is this desired?
> 
> Done.
> 
>
https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/auto...
> File ios/chrome/browser/web/auto_reload_controller.mm (right):
> 
>
https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/auto...
> ios/chrome/browser/web/auto_reload_controller.mm:34: id<AutoReloadDelegate>
> _delegate;
> On 2017/04/19 16:42:34, stkhapugin wrote:
> > This should be __weak
> 
> Done.
> 
>
https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/erro...
> File ios/chrome/browser/web/error_page_generator.mm (right):
> 
>
https://codereview.chromium.org/2823953004/diff/1/ios/chrome/browser/web/erro...
> ios/chrome/browser/web/error_page_generator.mm:27: NSString* html_;
> On 2017/04/18 15:44:43, Eugene But wrote:
> > Since you touching this, would you mind s/html_/_HTML ?
> 
> Done.

[commit-bot: I haz the power, 2017-04-20 09:28:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 09:28:58]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-04-20 15:48:56]

lgtm

[gambard, 2017-04-21 07:01:05]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-04-21 07:01:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2823953004/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2017-04-21 07:01:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 07:05:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492758065652240,
"parent_rev": "abe917c952a135427bec96cd62d8b7c174d79734", "commit_rev":
"bbdc3a57db54f6c15e343173885ba78b49b60730"}

[commit-bot: I haz the power, 2017-04-21 07:06:03]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/web:web_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/web:web_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2823953004
Cr-Commit-Position: refs/heads/master@{#466277}
Committed:
https://chromium.googlesource.com/chromium/src/+/bbdc3a57db54f6c15e343173885b...
==========

[commit-bot: I haz the power, 2017-04-21 07:06:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bbdc3a57db54f6c15e343173885b...