Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2826533002: Merge to M59: Only skip certain hidden elements at MHTML serialization (Closed)

Created:
3 years, 8 months ago by jianli
Modified:
3 years, 8 months ago
Reviewers:
svaldez
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge to M59: Only skip certain hidden elements at MHTML serialization 1) Elements with hidden attributes 2) Hidden form elements We orginally tried to act more aggresively by skipping all possible hidden elements. But this does break certain web sites that uses nth CSS selectors. BUG=697970 TEST=tests updated TBR=svaldez@chromium.org Review-Url: https://codereview.chromium.org/2819723003 Cr-Commit-Position: refs/heads/master@{#464856} (cherry picked from commit 2ddf990431d6b7977a94e5da69f18a1a3d220a52) Review-Url: https://codereview.chromium.org/2826533002 . Cr-Commit-Position: refs/branch-heads/3071@{#25} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/41faf4c8bb4cab7999d14e0a0195cc132beac4e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -26 lines) Patch
M chrome/browser/download/save_page_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializer.cpp View 2 chunks +8 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/tests/data/frameserialization/remove_elements.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
jianli
3 years, 8 months ago (2017-04-17 21:19:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
41faf4c8bb4cab7999d14e0a0195cc132beac4e1.

Powered by Google App Engine
This is Rietveld 408576698