Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2819723003: Only skip certain hidden elements at MHTML serialization (Closed)

Created:
3 years, 8 months ago by jianli
Modified:
3 years, 8 months ago
Reviewers:
tkent, svaldez
CC:
blink-reviews, chromium-reviews, dcheng, kinuko+watch, mlamouri+watch-blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only skip certain hidden elements at MHTML serialization 1) Elements with hidden attributes 2) Hidden form elements We orginally tried to act more aggresively by skipping all possible hidden elements. But this does break certain web sites that uses nth CSS selectors. BUG=697970 TEST=tests updated TBR=svaldez@chromium.org Review-Url: https://codereview.chromium.org/2819723003 Cr-Commit-Position: refs/heads/master@{#464856} Committed: https://chromium.googlesource.com/chromium/src/+/2ddf990431d6b7977a94e5da69f18a1a3d220a52

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Fix one more test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -26 lines) Patch
M chrome/browser/download/save_page_browsertest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameSerializer.cpp View 2 chunks +8 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/tests/data/frameserialization/remove_elements.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (21 generated)
jianli
3 years, 8 months ago (2017-04-14 01:01:52 UTC) #5
tkent
lgtm
3 years, 8 months ago (2017-04-14 01:06:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819723003/20001
3 years, 8 months ago (2017-04-14 21:54:20 UTC) #15
jianli
TBR svaldez for trivial test change
3 years, 8 months ago (2017-04-14 23:58:37 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819723003/40001
3 years, 8 months ago (2017-04-14 23:59:07 UTC) #24
commit-bot: I haz the power
3 years, 8 months ago (2017-04-15 03:13:14 UTC) #27
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2ddf990431d6b7977a94e5da69f1...

Powered by Google App Engine
This is Rietveld 408576698