Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Issue 2826313006: views: remove PlatformStyle combobox hooks (Closed)

Created:
3 years, 8 months ago by Elly Fong-Jones
Modified:
3 years, 8 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

views: remove PlatformStyle combobox hooks These are no longer needed since views on Mac is Harmony-only. BUG=629958 Review-Url: https://codereview.chromium.org/2826313006 Cr-Commit-Position: refs/heads/master@{#466377} Committed: https://chromium.googlesource.com/chromium/src/+/9bc80e246d791df3e093bf2b98986e7fab36934a

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove icons also #

Patch Set 3 : remove BUILD lines for deleted icons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -102 lines) Patch
M ui/views/BUILD.gn View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M ui/views/controls/combobox/combobox.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/combobox/combobox.cc View 1 3 chunks +5 lines, -10 lines 0 comments Download
M ui/views/style/platform_style.h View 3 chunks +0 lines, -12 lines 0 comments Download
M ui/views/style/platform_style.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/views/style/platform_style_mac.mm View 2 chunks +0 lines, -20 lines 0 comments Download
D ui/views/vector_icons/combobox_arrow_mac_disabled.icon View 1 1 chunk +0 lines, -17 lines 0 comments Download
D ui/views/vector_icons/combobox_arrow_mac_enabled.icon View 1 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Elly Fong-Jones
tapted: ptal? :)
3 years, 8 months ago (2017-04-20 21:04:25 UTC) #3
tapted
lgtm with a nit and the .icon files removed https://codereview.chromium.org/2826313006/diff/1/ui/views/controls/combobox/combobox.cc File ui/views/controls/combobox/combobox.cc (right): https://codereview.chromium.org/2826313006/diff/1/ui/views/controls/combobox/combobox.cc#newcode1011 ui/views/controls/combobox/combobox.cc:1011: ...
3 years, 8 months ago (2017-04-21 00:31:10 UTC) #4
Elly Fong-Jones
https://codereview.chromium.org/2826313006/diff/1/ui/views/controls/combobox/combobox.cc File ui/views/controls/combobox/combobox.cc (right): https://codereview.chromium.org/2826313006/diff/1/ui/views/controls/combobox/combobox.cc#newcode1011 ui/views/controls/combobox/combobox.cc:1011: const int kMdPaddingWidth = 8; On 2017/04/21 00:31:10, tapted ...
3 years, 8 months ago (2017-04-21 15:23:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826313006/20001
3 years, 8 months ago (2017-04-21 15:23:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/402204)
3 years, 8 months ago (2017-04-21 15:40:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826313006/40001
3 years, 8 months ago (2017-04-21 16:17:36 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 17:27:55 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9bc80e246d791df3e093bf2b9898...

Powered by Google App Engine
This is Rietveld 408576698