views: remove PlatformStyle combobox hooks

views: remove PlatformStyle combobox hooks

These are no longer needed since views on Mac is Harmony-only.

BUG=629958
Review-Url: https://codereview.chromium.org/2826313006
Cr-Commit-Position: refs/heads/master@{#466377}
Committed: https://chromium.googlesource.com/chromium/src/+/9bc80e246d791df3e093bf2b98986e7fab36934a

[Elly Fong-Jones, 2017-04-20 21:03:21]

Description was changed from

==========
views: remove PlatformStyle combobox hooks

These are no longer needed since views on Mac is Harmony-only.

BUG=629958
==========

to

==========
views: remove PlatformStyle combobox hooks

These are no longer needed since views on Mac is Harmony-only.

BUG=629958
==========

[Elly Fong-Jones, 2017-04-20 21:03:22]

ellyjones@chromium.org changed reviewers:
+ tapted@chromium.org

[Elly Fong-Jones, 2017-04-20 21:04:25]

tapted: ptal? :)

[tapted, 2017-04-21 00:31:10]

lgtm with a nit and the .icon files removed

https://codereview.chromium.org/2826313006/diff/1/ui/views/controls/combobox/...
File ui/views/controls/combobox/combobox.cc (right):

https://codereview.chromium.org/2826313006/diff/1/ui/views/controls/combobox/...
ui/views/controls/combobox/combobox.cc:1011: const int kMdPaddingWidth = 8;
nit: constexpr for these

https://codereview.chromium.org/2826313006/diff/1/ui/views/style/platform_sty...
File ui/views/style/platform_style_mac.mm (left):

https://codereview.chromium.org/2826313006/diff/1/ui/views/style/platform_sty...
ui/views/style/platform_style_mac.mm:59: is_enabled ?
kComboboxArrowMacEnabledIcon : kComboboxArrowMacDisabledIcon,
Can these two .icon files be deleted as well?

[Elly Fong-Jones, 2017-04-21 15:23:24]

https://codereview.chromium.org/2826313006/diff/1/ui/views/controls/combobox/...
File ui/views/controls/combobox/combobox.cc (right):

https://codereview.chromium.org/2826313006/diff/1/ui/views/controls/combobox/...
ui/views/controls/combobox/combobox.cc:1011: const int kMdPaddingWidth = 8;
On 2017/04/21 00:31:10, tapted (OOO soon) wrote:
> nit: constexpr for these

Done.

https://codereview.chromium.org/2826313006/diff/1/ui/views/style/platform_sty...
File ui/views/style/platform_style_mac.mm (left):

https://codereview.chromium.org/2826313006/diff/1/ui/views/style/platform_sty...
ui/views/style/platform_style_mac.mm:59: is_enabled ?
kComboboxArrowMacEnabledIcon : kComboboxArrowMacDisabledIcon,
On 2017/04/21 00:31:10, tapted (OOO soon) wrote:
> Can these two .icon files be deleted as well?

Yep!

[Elly Fong-Jones, 2017-04-21 15:23:35]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2017-04-21 15:23:36]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2826313006/#ps20001
(title: "remove icons also")

[commit-bot: I haz the power, 2017-04-21 15:23:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 15:40:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 15:40:11]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Elly Fong-Jones, 2017-04-21 16:17:17]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2017-04-21 16:17:17]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2826313006/#ps40001
(title: "remove BUILD lines for deleted icons")

[commit-bot: I haz the power, 2017-04-21 16:17:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 17:27:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492791437130870,
"parent_rev": "6ffce94e929ce46e50e364b726e07e2b4773c82b", "commit_rev":
"9bc80e246d791df3e093bf2b98986e7fab36934a"}

[commit-bot: I haz the power, 2017-04-21 17:27:54]

Description was changed from

==========
views: remove PlatformStyle combobox hooks

These are no longer needed since views on Mac is Harmony-only.

BUG=629958
==========

to

==========
views: remove PlatformStyle combobox hooks

These are no longer needed since views on Mac is Harmony-only.

BUG=629958

Review-Url: https://codereview.chromium.org/2826313006
Cr-Commit-Position: refs/heads/master@{#466377}
Committed:
https://chromium.googlesource.com/chromium/src/+/9bc80e246d791df3e093bf2b9898...
==========

[commit-bot: I haz the power, 2017-04-21 17:27:55]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9bc80e246d791df3e093bf2b9898...