views: remove PlatformStyle combobox hooks

ui/views/style/platform_style_mac.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/style/platform_style.h"
 
 #include "base/memory/ptr_util.h"
-#include "ui/base/resource/resource_bundle.h"
 #include "ui/base/ui_features.h"
 #include "ui/gfx/color_utils.h"
-#include "ui/gfx/paint_vector_icon.h"
-#include "ui/resources/grit/ui_resources.h"
 #include "ui/views/controls/button/label_button.h"
 #import "ui/views/controls/scrollbar/cocoa_scroll_bar.h"
-#include "ui/views/vector_icons.h"
 
 #import <Cocoa/Cocoa.h>
 
 namespace views {
 
-const int PlatformStyle::kComboboxNormalArrowPadding = 0;
 const int PlatformStyle::kMinLabelButtonWidth = 32;
 const int PlatformStyle::kMinLabelButtonHeight = 30;
 const bool PlatformStyle::kDefaultLabelButtonHasBoldFont = false;
 const bool PlatformStyle::kDialogDefaultButtonCanBeCancel = false;
 const bool PlatformStyle::kSelectWordOnRightClick = true;
 const bool PlatformStyle::kSelectAllOnRightClickWhenUnfocused = true;
 const bool PlatformStyle::kTreeViewSelectionPaintsEntireRow = true;
 const bool PlatformStyle::kTreeViewUsesOpenIcon = false;
 const bool PlatformStyle::kUseRipples = false;
 
 // On Mac, the Cocoa browser window does not flip its UI in RTL (e.g. bookmark
 // star remains on the right, padlock on the left). So bubbles should open in
 // the same direction as in LTR by default, unless the entire browser is views.
 const bool PlatformStyle::kMirrorBubbleArrowInRTLByDefault =
     BUILDFLAG(MAC_VIEWS_BROWSER);
 
 const CustomButton::NotifyAction PlatformStyle::kMenuNotifyActivationAction =
     CustomButton::NOTIFY_ON_PRESS;
 
 const CustomButton::KeyClickAction PlatformStyle::kKeyClickActionOnSpace =
     CustomButton::CLICK_ON_KEY_PRESS;
 
 // On Mac, the Return key is used to perform the default action even when a
 // control is focused.
 const bool PlatformStyle::kReturnClicksFocusedControl = false;
 
 // static
-gfx::ImageSkia PlatformStyle::CreateComboboxArrow(bool is_enabled,
-                                                  Combobox::Style style) {
-  // TODO(ellyjones): IDR_MENU_DROPARROW is a cross-platform image that doesn't
-  // look right on Mac. See https://crbug.com/384071.
-  if (style == Combobox::STYLE_ACTION) {
-    ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
-    return *rb.GetImageSkiaNamed(IDR_MENU_DROPARROW);
-  }
-  const int kComboboxArrowWidth = 24;
-  return gfx::CreateVectorIcon(
-      is_enabled ? kComboboxArrowMacEnabledIcon : kComboboxArrowMacDisabledIcon,

[tapted, 2017/04/21 00:31:10]

Can these two .icon files be deleted as well?

[Elly Fong-Jones, 2017/04/21 15:23:24]

Yep!

-      kComboboxArrowWidth, SK_ColorBLACK);
-}
-
-// static
 std::unique_ptr<ScrollBar> PlatformStyle::CreateScrollBar(bool is_horizontal) {
   return base::MakeUnique<CocoaScrollBar>(is_horizontal);
 }
 
 // static
 SkColor PlatformStyle::TextColorForButton(
     const ButtonColorByState& color_by_state,
     const LabelButton& button) {
   Button::ButtonState state = button.state();
   if (button.style() == Button::STYLE_BUTTON && button.is_default()) {
@@ skipping 11 matching lines @@
   ButtonColorByState& colors = *color_by_state;
   colors[Button::STATE_PRESSED] = SK_ColorWHITE;
 }
 
 // static
 void PlatformStyle::OnTextfieldEditFailed() {
   NSBeep();
 }
 
 }  // namespace views