cros: Use SessionController in UserMetricsRecorder to get login status

cros: Use SessionController in UserMetricsRecorder to get login status

* Reduces the number of calls to SystemTrayDelegate::GetUserLoginStatus(),
which we want to eliminate
* Allows TestSystemTrayDelegate::SetLoginStatus() to be removed

See discussion on https://codereview.chromium.org/2829813002/

BUG=none
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2826313002
Cr-Commit-Position: refs/heads/master@{#465817}
Committed: https://chromium.googlesource.com/chromium/src/+/76c1b7af9080fc7e1c14b14aef7d1b8f3b4ac828

[James Cook, 2017-04-19 22:55:13]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2017-04-19 22:55:28]

jamescook@chromium.org changed reviewers:
+ xiyuan@chromium.org

[James Cook, 2017-04-19 22:55:28]

xiyuan, please take a look.

[commit-bot: I haz the power, 2017-04-19 22:56:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 23:03:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 23:03:14]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[xiyuan, 2017-04-19 23:08:54]

lgtm

Thanks for the clean up. And rebase needed with your just-landed other CL. :)

https://codereview.chromium.org/2826313002/diff/1/ash/metrics/user_metrics_re...
File ash/metrics/user_metrics_recorder_unittest.cc (right):

https://codereview.chromium.org/2826313002/diff/1/ash/metrics/user_metrics_re...
ash/metrics/user_metrics_recorder_unittest.cc:84:
client->AddUserSession("user1@test.com", user_manager::USER_TYPE_KIOSK_APP);
nit: "user1@test.com" -> "app@kiosk-apps.device-local.localhost" to make it more
like an app. 

https://cs.chromium.org/chromium/src/chrome/browser/chromeos/policy/device_lo...

https://codereview.chromium.org/2826313002/diff/1/ash/metrics/user_metrics_re...
ash/metrics/user_metrics_recorder_unittest.cc:91:
user_manager::USER_TYPE_ARC_KIOSK_APP);
nit: "user1@test.com" -> "app@arc-kiosk-apps.device-local.localhost"

[James Cook, 2017-04-19 23:26:59]

Thanks again for a quick review.

https://codereview.chromium.org/2826313002/diff/1/ash/metrics/user_metrics_re...
File ash/metrics/user_metrics_recorder_unittest.cc (right):

https://codereview.chromium.org/2826313002/diff/1/ash/metrics/user_metrics_re...
ash/metrics/user_metrics_recorder_unittest.cc:84:
client->AddUserSession("user1@test.com", user_manager::USER_TYPE_KIOSK_APP);
On 2017/04/19 23:08:54, xiyuan wrote:
> nit: mailto:"user1@test.com" -> mailto:"app@kiosk-apps.device-local.localhost"
to make it more
> like an app. 
> 
>
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/policy/device_lo...

Done.

https://codereview.chromium.org/2826313002/diff/1/ash/metrics/user_metrics_re...
ash/metrics/user_metrics_recorder_unittest.cc:91:
user_manager::USER_TYPE_ARC_KIOSK_APP);
On 2017/04/19 23:08:54, xiyuan wrote:
> nit: mailto:"user1@test.com" ->
mailto:"app@arc-kiosk-apps.device-local.localhost"

Done.

[James Cook, 2017-04-19 23:27:03]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2017-04-19 23:27:03]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2826313002/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2017-04-19 23:27:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 00:06:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492644423235600,
"parent_rev": "a8a9ea03f2476826e9b3a6ad6e9c08b465ac1535", "commit_rev":
"76c1b7af9080fc7e1c14b14aef7d1b8f3b4ac828"}

[commit-bot: I haz the power, 2017-04-20 00:08:06]

Description was changed from

==========
cros: Use SessionController in UserMetricsRecorder to get login status

* Reduces the number of calls to SystemTrayDelegate::GetUserLoginStatus(),
which we want to eliminate
* Allows TestSystemTrayDelegate::SetLoginStatus() to be removed

See discussion on https://codereview.chromium.org/2829813002/

BUG=none
TEST=ash_unittests
==========

to

==========
cros: Use SessionController in UserMetricsRecorder to get login status

* Reduces the number of calls to SystemTrayDelegate::GetUserLoginStatus(),
which we want to eliminate
* Allows TestSystemTrayDelegate::SetLoginStatus() to be removed

See discussion on https://codereview.chromium.org/2829813002/

BUG=none
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2826313002
Cr-Commit-Position: refs/heads/master@{#465817}
Committed:
https://chromium.googlesource.com/chromium/src/+/76c1b7af9080fc7e1c14b14aef7d...
==========

[commit-bot: I haz the power, 2017-04-20 00:08:07]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/76c1b7af9080fc7e1c14b14aef7d...