Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2513)

Unified Diff: ash/test/test_system_tray_delegate.h

Issue 2826313002: cros: Use SessionController in UserMetricsRecorder to get login status (Closed)
Patch Set: review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/metrics/user_metrics_recorder_unittest.cc ('k') | ash/test/test_system_tray_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/test/test_system_tray_delegate.h
diff --git a/ash/test/test_system_tray_delegate.h b/ash/test/test_system_tray_delegate.h
index 659dfe1a791a5bfd4cfc96ca15f0594f196077c3..1a4cf6aaa67f742e908ae824b03dfb645d01f2d5 100644
--- a/ash/test/test_system_tray_delegate.h
+++ b/ash/test/test_system_tray_delegate.h
@@ -18,14 +18,6 @@ class TestSystemTrayDelegate : public SystemTrayDelegate {
TestSystemTrayDelegate();
~TestSystemTrayDelegate() override;
- // Changes the current login status in the test. This also invokes
- // UpdateAfterLoginStatusChange(). Usually this is called in the test code to
- // set up a login status. This will fit to most of the test cases, but this
- // cannot be set during the initialization. To test the initialization,
- // consider using SetInitialLoginStatus() instead.
- // TODO(jamescook): Eliminate this method and |login_status_|.
- void SetLoginStatus(LoginStatus login_status);
-
// Updates the session length limit so that the limit will come from now in
// |new_limit|.
void SetSessionLengthLimitForTest(const base::TimeDelta& new_limit);
@@ -48,9 +40,8 @@ class TestSystemTrayDelegate : public SystemTrayDelegate {
void GetAvailableIMEList(IMEInfoList* list) override;
private:
- LoginStatus login_status_;
base::TimeDelta session_length_limit_;
- bool session_length_limit_set_;
+ bool session_length_limit_set_ = false;
IMEInfo current_ime_;
IMEInfoList ime_list_;
« no previous file with comments | « ash/metrics/user_metrics_recorder_unittest.cc ('k') | ash/test/test_system_tray_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698