Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2826283004: Add MetalayerToolTest (Closed)

Created:
3 years, 8 months ago by Vladislav Kaznacheev
Modified:
3 years, 7 months ago
Reviewers:
stevenjb, oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add MetalayerToolTest Unit tests for the recently added MetalayerMode. Bug: b:37165189 Test: ash_unittests --gtest_filter=MetalayerToolTest* Review-Url: https://codereview.chromium.org/2826283004 Cr-Commit-Position: refs/heads/master@{#468695} Committed: https://chromium.googlesource.com/chromium/src/+/1497d50c10ce8a82a419dc82331a6cf0d2a3f4fe

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -2 lines) Patch
M ash/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ash/system/palette/tools/metalayer_unittest.cc View 1 chunk +79 lines, -0 lines 0 comments Download
M ash/test/test_palette_delegate.h View 2 chunks +11 lines, -0 lines 3 comments Download
M ash/test/test_palette_delegate.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Vladislav Kaznacheev
Please review. This is a followup for https://codereview.chromium.org/2824703006/
3 years, 8 months ago (2017-04-20 23:07:56 UTC) #2
stevenjb
Please have someone familiar with the feature review this. I'm happy to provide an owner ...
3 years, 8 months ago (2017-04-26 17:21:06 UTC) #3
Vladislav Kaznacheev
3 years, 7 months ago (2017-04-28 21:18:33 UTC) #5
oshima
lgtm https://codereview.chromium.org/2826283004/diff/1/ash/test/test_palette_delegate.h File ash/test/test_palette_delegate.h (right): https://codereview.chromium.org/2826283004/diff/1/ash/test/test_palette_delegate.h#newcode49 ash/test/test_palette_delegate.h:49: base::Closure metalayer_closed() const { return metalayer_closed_; } On ...
3 years, 7 months ago (2017-04-28 21:47:34 UTC) #6
stevenjb
lgtm https://codereview.chromium.org/2826283004/diff/1/ash/test/test_palette_delegate.h File ash/test/test_palette_delegate.h (right): https://codereview.chromium.org/2826283004/diff/1/ash/test/test_palette_delegate.h#newcode49 ash/test/test_palette_delegate.h:49: base::Closure metalayer_closed() const { return metalayer_closed_; } On ...
3 years, 7 months ago (2017-04-28 21:49:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826283004/1
3 years, 7 months ago (2017-04-28 21:54:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/442116)
3 years, 7 months ago (2017-04-28 23:03:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826283004/1
3 years, 7 months ago (2017-05-02 15:41:40 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 17:16:37 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1497d50c10ce8a82a419dc82331a...

Powered by Google App Engine
This is Rietveld 408576698