Add MetalayerToolTest

Add MetalayerToolTest

Unit tests for the recently added MetalayerMode.

Bug: b:37165189
Test: ash_unittests --gtest_filter=MetalayerToolTest*
Review-Url: https://codereview.chromium.org/2826283004
Cr-Commit-Position: refs/heads/master@{#468695}
Committed: https://chromium.googlesource.com/chromium/src/+/1497d50c10ce8a82a419dc82331a6cf0d2a3f4fe

[Vladislav Kaznacheev, 2017-04-20 23:07:55]

kaznacheev@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Vladislav Kaznacheev, 2017-04-20 23:07:56]

Please review. This is a followup for
https://codereview.chromium.org/2824703006/

[stevenjb, 2017-04-26 17:21:06]

Please have someone familiar with the feature review this. I'm happy to provide
an owner stamp at that point of needed.

https://codereview.chromium.org/2826283004/diff/1/ash/test/test_palette_deleg...
File ash/test/test_palette_delegate.h (right):

https://codereview.chromium.org/2826283004/diff/1/ash/test/test_palette_deleg...
ash/test/test_palette_delegate.h:49: base::Closure metalayer_closed() const {
return metalayer_closed_; }
If these are only used for testing, please append for_test to each method.

[Vladislav Kaznacheev, 2017-04-28 21:18:33]

kaznacheev@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2017-04-28 21:47:34]

lgtm

https://codereview.chromium.org/2826283004/diff/1/ash/test/test_palette_deleg...
File ash/test/test_palette_delegate.h (right):

https://codereview.chromium.org/2826283004/diff/1/ash/test/test_palette_deleg...
ash/test/test_palette_delegate.h:49: base::Closure metalayer_closed() const {
return metalayer_closed_; }
On 2017/04/26 17:21:05, stevenjb wrote:
> If these are only used for testing, please append for_test to each method.

this is a test delegate, so this is fine. :)

[stevenjb, 2017-04-28 21:49:11]

lgtm

https://codereview.chromium.org/2826283004/diff/1/ash/test/test_palette_deleg...
File ash/test/test_palette_delegate.h (right):

https://codereview.chromium.org/2826283004/diff/1/ash/test/test_palette_deleg...
ash/test/test_palette_delegate.h:49: base::Closure metalayer_closed() const {
return metalayer_closed_; }
On 2017/04/28 21:47:34, oshima wrote:
> On 2017/04/26 17:21:05, stevenjb wrote:
> > If these are only used for testing, please append for_test to each method.
> 
> this is a test delegate, so this is fine. :)

Oh, yeah, never mind :)

[Vladislav Kaznacheev, 2017-04-28 21:54:13]

The CQ bit was checked by kaznacheev@chromium.org

[commit-bot: I haz the power, 2017-04-28 21:54:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 23:03:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 23:03:46]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Vladislav Kaznacheev, 2017-05-02 15:41:16]

The CQ bit was checked by kaznacheev@chromium.org

[commit-bot: I haz the power, 2017-05-02 15:41:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 17:16:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493739676004720, "parent_rev":
"75f1b32c79000f26e11dad3be9f4420589893e18", "commit_rev":
"1497d50c10ce8a82a419dc82331a6cf0d2a3f4fe"}

[commit-bot: I haz the power, 2017-05-02 17:16:36]

Description was changed from

==========
Add MetalayerToolTest

Unit tests for the recently added MetalayerMode.

Bug: b:37165189
Test: ash_unittests --gtest_filter=MetalayerToolTest*
==========

to

==========
Add MetalayerToolTest

Unit tests for the recently added MetalayerMode.

Bug: b:37165189
Test: ash_unittests --gtest_filter=MetalayerToolTest*
Review-Url: https://codereview.chromium.org/2826283004
Cr-Commit-Position: refs/heads/master@{#468695}
Committed:
https://chromium.googlesource.com/chromium/src/+/1497d50c10ce8a82a419dc82331a...
==========

[commit-bot: I haz the power, 2017-05-02 17:16:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1497d50c10ce8a82a419dc82331a...