Add MetalayerMode to the palette.

Add MetalayerMode to the palette.

This tool shows/hides the "metalayer" overlay on the
containter side.

The tool name string is temporary, as well as the
palette icons (reusing the icons from "Capture region").

Still keeping around the temporary Shift-Search-A
shortcut and the repurposed "Capture region" tool.

BUG=b:37165189
TEST="Metalayer mode" stylus tool toggles the metalayer.

Review-Url: https://codereview.chromium.org/2824703006
Cr-Commit-Position: refs/heads/master@{#466167}
Committed: https://chromium.googlesource.com/chromium/src/+/466e48c8e7f8fbfc3ba625000881094dd864a8da

[Vladislav Kaznacheev, 2017-04-18 23:44:45]

Description was changed from

==========
Add MetalayerMode to the palette.

This tool shows/hides the "metalayer" overlay on the
containter side.

The tool name string is temporary, as well as the
palette icons (reusing the icons from "Capture region").

Still keeping around the temporary Shift-Search-A
shortcut and the repurposed "Capture region" tool.

BUG=b:37165189
TEST="Metalayer mode" stylus tool toggles the metalayer.
==========

to

==========
Add MetalayerMode to the palette.

This tool shows/hides the "metalayer" overlay on the
containter side.

The tool name string is temporary, as well as the
palette icons (reusing the icons from "Capture region").

Still keeping around the temporary Shift-Search-A
shortcut and the repurposed "Capture region" tool.

BUG=b:37165189
TEST="Metalayer mode" stylus tool toggles the metalayer.
==========

[Vladislav Kaznacheev, 2017-04-18 23:44:46]

kaznacheev@chromium.org changed reviewers:
+ estark@chromium.org, lhchavez@chromium.org, oshima@chromium.org,
xiaohuic@chromium.org

[Luis Héctor Chávez, 2017-04-19 15:48:29]

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
(right):

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:82:
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (!metalayer_closed_callback_.is_null())
  base::ResetAndReturn(&metalayer_closed_callback_).Run();
instance_ready_ = false; // if you end up keeping it.

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:144:
metalayer_complete_.Run();
nit: base::ResetAndReturn(&metalayer_closed_callback_).Run();

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:175:
DCHECK(framework_instance);
substitute this with

if (visible && !framework_instance)
  base::ResetAndReturn(&metalayer_closed_callback_).Run();
if (!framework_instance)
  return;

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h
(right):

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h:58:
void ShowMetalayer(bool visible);
please choose a different name to distinguish between the other ShowMetalayer().

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h:62:
base::Closure metalayer_complete_;
maybe metalayer_closed_callback_?

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/ui/ash/palet...
File chrome/browser/ui/ash/palette_delegate_chromeos.cc (right):

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/ui/ash/palet...
chrome/browser/ui/ash/palette_delegate_chromeos.cc:209: if
(!arc::IsArcAllowedForProfile(profile_))
Don't we also want to check
arc::ArcVoiceInteractionFrameworkService::IsVoiceInteractionEnabled() here?

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/ui/ash/palet...
chrome/browser/ui/ash/palette_delegate_chromeos.cc:219:
arc::ArcVoiceInteractionFrameworkService* service =
If the container dies just prior to this being called, |done| will never get
resolved and that would cause the palette to never be closed (IIUC). That sounds
racy.

How about you get rid of the arc::ArcVoiceInteractionFrameworkService::IsReady()
check in HasMetalayer() altogether, and instead immediately resolve the callback
(in arc::ArcVoiceInteractionFrameworkService) when it's not ready?

Maybe also have |done| be a base::Callback<void(bool)> to be able to notify the
caller that the operation failed? (not so sure about this, it seems that the
caller does not care about it, only that it's gone).

https://codereview.chromium.org/2824703006/diff/1/components/arc/common/voice...
File components/arc/common/voice_interaction_framework.mojom (right):

https://codereview.chromium.org/2824703006/diff/1/components/arc/common/voice...
components/arc/common/voice_interaction_framework.mojom:22:
[MinVersion=2]OnMetalayerComplete@2();
maybe OnMetalayerVisibilityUpdated?

https://codereview.chromium.org/2824703006/diff/1/components/arc/common/voice...
components/arc/common/voice_interaction_framework.mojom:38: [MinVersion=1]
ToggleMetalayer@3();
You don't need to deprecate this :D

[MinVersion=1] SetMetalayerVisibility@3([MinVersion=2] bool visible);

[Vladislav Kaznacheev, 2017-04-19 23:42:59]

PTAL

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
(right):

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:82:
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
On 2017/04/19 15:48:28, Luis Héctor Chávez wrote:
> if (!metalayer_closed_callback_.is_null())
>   base::ResetAndReturn(&metalayer_closed_callback_).Run();
> instance_ready_ = false; // if you end up keeping it.

Done.

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:144:
metalayer_complete_.Run();
On 2017/04/19 15:48:28, Luis Héctor Chávez wrote:
> nit: base::ResetAndReturn(&metalayer_closed_callback_).Run();

Done.

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:175:
DCHECK(framework_instance);
On 2017/04/19 15:48:28, Luis Héctor Chávez wrote:
> substitute this with
> 
> if (visible && !framework_instance)
>   base::ResetAndReturn(&metalayer_closed_callback_).Run();
> if (!framework_instance)
>   return;

Substituted with a slight change.

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
File
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h
(right):

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h:58:
void ShowMetalayer(bool visible);
On 2017/04/19 15:48:28, Luis Héctor Chávez wrote:
> please choose a different name to distinguish between the other
ShowMetalayer().

Done.

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h:62:
base::Closure metalayer_complete_;
On 2017/04/19 15:48:28, Luis Héctor Chávez wrote:
> maybe metalayer_closed_callback_?

Done.

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/ui/ash/palet...
File chrome/browser/ui/ash/palette_delegate_chromeos.cc (right):

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/ui/ash/palet...
chrome/browser/ui/ash/palette_delegate_chromeos.cc:209: if
(!arc::IsArcAllowedForProfile(profile_))
On 2017/04/19 15:48:29, Luis Héctor Chávez wrote:
> Don't we also want to check
> arc::ArcVoiceInteractionFrameworkService::IsVoiceInteractionEnabled() here?

ArcVoiceInteractionFrameworkService instantiation is guarded by this exact
condition. If this check is false, service below would be null.

https://codereview.chromium.org/2824703006/diff/1/chrome/browser/ui/ash/palet...
chrome/browser/ui/ash/palette_delegate_chromeos.cc:219:
arc::ArcVoiceInteractionFrameworkService* service =
On 2017/04/19 15:48:29, Luis Héctor Chávez wrote:
> If the container dies just prior to this being called, |done| will never get
> resolved and that would cause the palette to never be closed (IIUC). That
sounds
> racy.

Replaced DCHECK with closure resolution and return. 
 
> How about you get rid of the
arc::ArcVoiceInteractionFrameworkService::IsReady()
> check in HasMetalayer() altogether, and instead immediately resolve the
callback
> (in arc::ArcVoiceInteractionFrameworkService) when it's not ready?

The purpose of IsReady is to propagate through a delegate to the palette code
which will not surface the Metalayer tool if this call returns false. I have
renamed it to HasMetalayer and instead of looking at the flag (now removed)
it is trying to get hold the framework instance.

> Maybe also have |done| be a base::Callback<void(bool)> to be able to notify
the
> caller that the operation failed? (not so sure about this, it seems that the
> caller does not care about it, only that it's gone).

For the palette UI it does not really matter if the Metalayer failed to
open or closed soon after opening. I will make sure that on the container
calls OnMetalayerComplete if it sees that Metalayer has not started.

https://codereview.chromium.org/2824703006/diff/1/components/arc/common/voice...
File components/arc/common/voice_interaction_framework.mojom (right):

https://codereview.chromium.org/2824703006/diff/1/components/arc/common/voice...
components/arc/common/voice_interaction_framework.mojom:22:
[MinVersion=2]OnMetalayerComplete@2();
On 2017/04/19 15:48:29, Luis Héctor Chávez wrote:
> maybe OnMetalayerVisibilityUpdated?

This is only required to notify the host that the metalayer has been closed on
the container side due to a user action (or possibly due to a failure to start).
If the visibility changed to true successfully, the host really does not want to
know.

https://codereview.chromium.org/2824703006/diff/1/components/arc/common/voice...
components/arc/common/voice_interaction_framework.mojom:38: [MinVersion=1]
ToggleMetalayer@3();
On 2017/04/19 15:48:29, Luis Héctor Chávez wrote:
> You don't need to deprecate this :D
> 
> [MinVersion=1] SetMetalayerVisibility@3([MinVersion=2] bool visible);

Done.

[estark, 2017-04-20 00:06:45]

Sorry, what am I supposed to be reviewing in this CL?

[Vladislav Kaznacheev, 2017-04-20 00:53:01]

On 2017/04/20 00:06:45, estark wrote:
> Sorry, what am I supposed to be reviewing in this CL?

My bad, I should have included that in the original review request:

estark@ *.mojom
lhchavez@ components/arc
xiahuic@ chrome/browser/chromeos/arc/voice_interaction
oshima@ chrome/browser/ui/ash

My choice of *.mojom reviewer is based on ipc/SECURITY_OWNERS linked from
components/arc/mojom/OWNERS

[Luis Héctor Chávez, 2017-04-20 16:03:26]

https://codereview.chromium.org/2824703006/diff/1/components/arc/common/voice...
File components/arc/common/voice_interaction_framework.mojom (right):

https://codereview.chromium.org/2824703006/diff/1/components/arc/common/voice...
components/arc/common/voice_interaction_framework.mojom:22:
[MinVersion=2]OnMetalayerComplete@2();
On 2017/04/19 23:42:59, Vladislav Kaznacheev wrote:
> On 2017/04/19 15:48:29, Luis Héctor Chávez wrote:
> > maybe OnMetalayerVisibilityUpdated?
> 
> This is only required to notify the host that the metalayer has been closed on
> the container side due to a user action (or possibly due to a failure to
start).
> If the visibility changed to true successfully, the host really does not want
to
> know.

Still, "MetalayerComplete" seems like an odd name. MetalayerClosed?
MetalayerInteractionComplete? Please also update the comment above for
consistency.

https://codereview.chromium.org/2824703006/diff/20001/ash/palette_delegate.h
File ash/palette_delegate.h (right):

https://codereview.chromium.org/2824703006/diff/20001/ash/palette_delegate.h#...
ash/palette_delegate.h:61: virtual void ShowMetalayer(const base::Closure& done)
= 0;
maybe s/done/closed/ or s/done/interaction_done/ in all ShowMetalayer()
decls/impls?

also, please mention that |closed| is invoked if the metalayer could not be
shown, or when the interaction with the metalayer is done / the metalayer is
closed.

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
(right):

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:147:
void ArcVoiceInteractionFrameworkService::OnMetalayerComplete() {
nit: DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:152:
bool ArcVoiceInteractionFrameworkService::HasMetalayer() {
nit: DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:161:
const base::Closure& done) {
nit: DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:170:
void ArcVoiceInteractionFrameworkService::HideMetalayer() {
nit: DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:179:
void ArcVoiceInteractionFrameworkService::SetMetalayerVisibility(bool visible) {
nit: DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h
(right):

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h:47:
bool HasMetalayer();
maybe IsMetalayerSupported?

https://codereview.chromium.org/2824703006/diff/20001/components/arc/common/v...
File components/arc/common/voice_interaction_framework.mojom (right):

https://codereview.chromium.org/2824703006/diff/20001/components/arc/common/v...
components/arc/common/voice_interaction_framework.mojom:26: // Next method ID: 5
nit: Next method ID: 4 (you didn't end up needing to bump this up).

[Vladislav Kaznacheev, 2017-04-20 17:54:56]

PTAL

https://codereview.chromium.org/2824703006/diff/1/components/arc/common/voice...
File components/arc/common/voice_interaction_framework.mojom (right):

https://codereview.chromium.org/2824703006/diff/1/components/arc/common/voice...
components/arc/common/voice_interaction_framework.mojom:22:
[MinVersion=2]OnMetalayerComplete@2();
On 2017/04/20 16:03:26, Luis Héctor Chávez wrote:
> On 2017/04/19 23:42:59, Vladislav Kaznacheev wrote:
> > On 2017/04/19 15:48:29, Luis Héctor Chávez wrote:
> > > maybe OnMetalayerVisibilityUpdated?
> > 
> > This is only required to notify the host that the metalayer has been closed
on
> > the container side due to a user action (or possibly due to a failure to
> start).
> > If the visibility changed to true successfully, the host really does not
want
> to
> > know.
> 
> Still, "MetalayerComplete" seems like an odd name. MetalayerClosed?
> MetalayerInteractionComplete? Please also update the comment above for
> consistency.

Done.

https://codereview.chromium.org/2824703006/diff/20001/ash/palette_delegate.h
File ash/palette_delegate.h (right):

https://codereview.chromium.org/2824703006/diff/20001/ash/palette_delegate.h#...
ash/palette_delegate.h:61: virtual void ShowMetalayer(const base::Closure& done)
= 0;
On 2017/04/20 16:03:26, Luis Héctor Chávez wrote:
> maybe s/done/closed/ or s/done/interaction_done/ in all ShowMetalayer()
> decls/impls?
> 
> also, please mention that |closed| is invoked if the metalayer could not be
> shown, or when the interaction with the metalayer is done / the metalayer is
> closed.

going with interaction_done. Added a comment.

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
(right):

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:147:
void ArcVoiceInteractionFrameworkService::OnMetalayerComplete() {
On 2017/04/20 16:03:26, Luis Héctor Chávez wrote:
> nit: DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

Done.

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:152:
bool ArcVoiceInteractionFrameworkService::HasMetalayer() {
On 2017/04/20 16:03:26, Luis Héctor Chávez wrote:
> nit: DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

Done.

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:161:
const base::Closure& done) {
On 2017/04/20 16:03:26, Luis Héctor Chávez wrote:
> nit: DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

Done.

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:170:
void ArcVoiceInteractionFrameworkService::HideMetalayer() {
On 2017/04/20 16:03:26, Luis Héctor Chávez wrote:
> nit: DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

Done.

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:179:
void ArcVoiceInteractionFrameworkService::SetMetalayerVisibility(bool visible) {
On 2017/04/20 16:03:26, Luis Héctor Chávez wrote:
> nit: DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

Done.

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
File
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h
(right):

https://codereview.chromium.org/2824703006/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h:47:
bool HasMetalayer();
On 2017/04/20 16:03:26, Luis Héctor Chávez wrote:
> maybe IsMetalayerSupported?

Renamed here and in PaletteDelegate for consistency

https://codereview.chromium.org/2824703006/diff/20001/components/arc/common/v...
File components/arc/common/voice_interaction_framework.mojom (right):

https://codereview.chromium.org/2824703006/diff/20001/components/arc/common/v...
components/arc/common/voice_interaction_framework.mojom:26: // Next method ID: 5
On 2017/04/20 16:03:26, Luis Héctor Chávez wrote:
> nit: Next method ID: 4 (you didn't end up needing to bump this up).

Done.

[Luis Héctor Chávez, 2017-04-20 18:17:54]

lgtm

thanks!

[xiaohuic, 2017-04-20 18:54:03]

xiaohuic@google.com changed reviewers:
+ xiaohuic@google.com

[xiaohuic, 2017-04-20 18:54:04]

lgtm

[oshima, 2017-04-20 19:56:58]

lgtm

https://codereview.chromium.org/2824703006/diff/40001/ash/system/palette/tool...
File ash/system/palette/tools/metalayer_mode.h (right):

https://codereview.chromium.org/2824703006/diff/40001/ash/system/palette/tool...
ash/system/palette/tools/metalayer_mode.h:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
nit: 2017

[estark, 2017-04-20 20:07:32]

mojom changes lgtm

[estark, 2017-04-20 20:07:33]

mojom changes lgtm

[Vladislav Kaznacheev, 2017-04-20 20:09:55]

https://codereview.chromium.org/2824703006/diff/40001/ash/system/palette/tool...
File ash/system/palette/tools/metalayer_mode.h (right):

https://codereview.chromium.org/2824703006/diff/40001/ash/system/palette/tool...
ash/system/palette/tools/metalayer_mode.h:1: // Copyright 2016 The Chromium
Authors. All rights reserved.
On 2017/04/20 19:56:58, oshima wrote:
> nit: 2017

Done.

[Vladislav Kaznacheev, 2017-04-20 20:10:00]

The CQ bit was checked by kaznacheev@chromium.org

[Vladislav Kaznacheev, 2017-04-20 20:10:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org, oshima@chromium.org, xiaohuic@google.com
Link to the patchset: https://codereview.chromium.org/2824703006/#ps60001
(title: "Fixed copyright year")

[commit-bot: I haz the power, 2017-04-20 20:10:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 21:25:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 21:25:36]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Vladislav Kaznacheev, 2017-04-20 21:39:08]

The CQ bit was checked by kaznacheev@chromium.org

[commit-bot: I haz the power, 2017-04-20 21:39:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 22:35:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492724348215230,
"parent_rev": "abefb698e5e6ad81853ffdd0560c9efa4740464d", "commit_rev":
"466e48c8e7f8fbfc3ba625000881094dd864a8da"}

[commit-bot: I haz the power, 2017-04-20 22:35:36]

Description was changed from

==========
Add MetalayerMode to the palette.

This tool shows/hides the "metalayer" overlay on the
containter side.

The tool name string is temporary, as well as the
palette icons (reusing the icons from "Capture region").

Still keeping around the temporary Shift-Search-A
shortcut and the repurposed "Capture region" tool.

BUG=b:37165189
TEST="Metalayer mode" stylus tool toggles the metalayer.
==========

to

==========
Add MetalayerMode to the palette.

This tool shows/hides the "metalayer" overlay on the
containter side.

The tool name string is temporary, as well as the
palette icons (reusing the icons from "Capture region").

Still keeping around the temporary Shift-Search-A
shortcut and the repurposed "Capture region" tool.

BUG=b:37165189
TEST="Metalayer mode" stylus tool toggles the metalayer.

Review-Url: https://codereview.chromium.org/2824703006
Cr-Commit-Position: refs/heads/master@{#466167}
Committed:
https://chromium.googlesource.com/chromium/src/+/466e48c8e7f8fbfc3ba625000881...
==========

[commit-bot: I haz the power, 2017-04-20 22:35:37]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/466e48c8e7f8fbfc3ba625000881...

[Vladislav Kaznacheev, 2017-04-20 23:04:09]

Patchset #5 (id:80001) has been deleted