Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 2826193002: Revert of Disables RendererDebugURLsDontSwap on Mac in combination with ASAN (part 2) (Closed)

Created:
3 years, 8 months ago by nasko
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disables RendererDebugURLsDontSwap on Mac in combination with ASAN (part 2) (patchset #1 id:1 of https://codereview.chromium.org/2733963004/ ) Reason for revert: Looks like the symbolization issue on the Mac is fixed, so reverting this disabling of the test. Original issue's description: > Disables RendererDebugURLsDontSwap on Mac in combination with ASAN (part 2) > > Now excludes the test in combination with ADDRESS_SANITIZER instead of THREAD_SANITIZER > > > NOTRY=TRUE > TBR=nasko > BUG=699062 > > Review-Url: https://codereview.chromium.org/2733963004 > Cr-Commit-Position: refs/heads/master@{#455058} > Committed: https://chromium.googlesource.com/chromium/src/+/f455b044581f319a0c039a1ba091a435e3c25a73 TBR=henrika@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=699062 Review-Url: https://codereview.chromium.org/2826193002 Cr-Commit-Position: refs/heads/master@{#465687} Committed: https://chromium.googlesource.com/chromium/src/+/907ff687dc1602164ce1f7f713a3b6c8adc883b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
nasko
Created Revert of Disables RendererDebugURLsDontSwap on Mac in combination with ASAN (part 2)
3 years, 8 months ago (2017-04-19 18:14:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826193002/1
3 years, 8 months ago (2017-04-19 18:14:43 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 19:02:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/907ff687dc1602164ce1f7f713a3...

Powered by Google App Engine
This is Rietveld 408576698