Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2733963004: Disables RendererDebugURLsDontSwap on Mac in combination with ASAN (part 2) (Closed)

Created:
3 years, 9 months ago by henrika (OOO until Aug 14)
Modified:
3 years, 9 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disables RendererDebugURLsDontSwap on Mac in combination with ASAN (part 2) Now excludes the test in combination with ADDRESS_SANITIZER instead of THREAD_SANITIZER NOTRY=TRUE TBR=nasko BUG=699062 Review-Url: https://codereview.chromium.org/2733963004 Cr-Commit-Position: refs/heads/master@{#455058} Committed: https://chromium.googlesource.com/chromium/src/+/f455b044581f319a0c039a1ba091a435e3c25a73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733963004/1
3 years, 9 months ago (2017-03-07 12:58:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f455b044581f319a0c039a1ba091a435e3c25a73
3 years, 9 months ago (2017-03-07 13:03:26 UTC) #8
nasko
3 years, 8 months ago (2017-04-19 18:14:05 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2826193002/ by nasko@chromium.org.

The reason for reverting is: Looks like the symbolization issue on the Mac is
fixed, so reverting this disabling of the test..

Powered by Google App Engine
This is Rietveld 408576698