Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2826093002: Revert of customtabs: Add a test for external app redirection. (Closed)

Created:
3 years, 8 months ago by Michael van Ouwerkerk
Modified:
3 years, 8 months ago
Reviewers:
Yusuf, Benoit L
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of customtabs: Add a test for external app redirection. (patchset #4 id:60001 of https://codereview.chromium.org/2805763003/ ) Reason for revert: The new testExternalApplicationLink test is failing on https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%2064%20bit%20Tester Sample log: I 369.668s run_tests_on_device(003c650bbb893852) detected failure in org.chromium.chrome.browser.customtabs.CustomTabExternalNavigationTest#testExternalApplicationLink. raw output: I 369.668s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS: numtests=1 I 369.668s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS: stream= I 369.668s run_tests_on_device(003c650bbb893852) org.chromium.chrome.browser.customtabs.CustomTabExternalNavigationTest: I 369.668s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS: id=InstrumentationTestRunner I 369.668s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS: test=testExternalApplicationLink I 369.668s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.customtabs.CustomTabExternalNavigationTest I 369.669s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS: current=1 I 369.669s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS_CODE: 1 I 369.669s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS: numtests=1 I 369.669s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS: stream= I 369.669s run_tests_on_device(003c650bbb893852) Failure in testExternalApplicationLink: I 369.669s run_tests_on_device(003c650bbb893852) junit.framework.AssertionFailedError: External Activity not launched. I 369.669s run_tests_on_device(003c650bbb893852) at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79) I 369.669s run_tests_on_device(003c650bbb893852) at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:117) I 369.669s run_tests_on_device(003c650bbb893852) at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:138) I 369.669s run_tests_on_device(003c650bbb893852) at org.chromium.chrome.browser.customtabs.CustomTabExternalNavigationTest.testExternalApplicationLink(CustomTabExternalNavigationTest.java:112) I 369.669s run_tests_on_device(003c650bbb893852) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) I 369.669s run_tests_on_device(003c650bbb893852) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) I 369.669s run_tests_on_device(003c650bbb893852) at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) I 369.669s run_tests_on_device(003c650bbb893852) at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758) I 369.669s run_tests_on_device(003c650bbb893852) at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) I 369.669s run_tests_on_device(003c650bbb893852) at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) I 369.669s run_tests_on_device(003c650bbb893852) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) I 369.669s run_tests_on_device(003c650bbb893852) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) I 369.669s run_tests_on_device(003c650bbb893852) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) I 369.669s run_tests_on_device(003c650bbb893852) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879) I 369.669s run_tests_on_device(003c650bbb893852) I 369.669s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS: id=InstrumentationTestRunner I 369.669s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS: test=testExternalApplicationLink I 369.669s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.customtabs.CustomTabExternalNavigationTest I 369.669s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS: stack=junit.framework.AssertionFailedError: External Activity not launched. I 369.669s run_tests_on_device(003c650bbb893852) at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79) I 369.669s run_tests_on_device(003c650bbb893852) at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:117) I 369.669s run_tests_on_device(003c650bbb893852) at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:138) I 369.669s run_tests_on_device(003c650bbb893852) at org.chromium.chrome.browser.customtabs.CustomTabExternalNavigationTest.testExternalApplicationLink(CustomTabExternalNavigationTest.java:112) I 369.669s run_tests_on_device(003c650bbb893852) at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) I 369.669s run_tests_on_device(003c650bbb893852) at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) I 369.670s run_tests_on_device(003c650bbb893852) at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) I 369.670s run_tests_on_device(003c650bbb893852) at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758) I 369.670s run_tests_on_device(003c650bbb893852) at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) I 369.670s run_tests_on_device(003c650bbb893852) at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) I 369.670s run_tests_on_device(003c650bbb893852) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) I 369.670s run_tests_on_device(003c650bbb893852) at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) I 369.670s run_tests_on_device(003c650bbb893852) at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) I 369.670s run_tests_on_device(003c650bbb893852) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879) I 369.670s run_tests_on_device(003c650bbb893852) I 369.670s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS: current=1 I 369.670s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_STATUS_CODE: -2 I 369.670s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_RESULT: stream= I 369.670s run_tests_on_device(003c650bbb893852) Test results for ChromeInstrumentationTestRunner=.F I 369.670s run_tests_on_device(003c650bbb893852) Time: 4.437 I 369.670s run_tests_on_device(003c650bbb893852) I 369.670s run_tests_on_device(003c650bbb893852) FAILURES!!! I 369.670s run_tests_on_device(003c650bbb893852) Tests run: 1, Failures: 1, Errors: 0 I 369.670s run_tests_on_device(003c650bbb893852) I 369.670s run_tests_on_device(003c650bbb893852) I 369.670s run_tests_on_device(003c650bbb893852) INSTRUMENTATION_CODE: -1 Original issue's description: > customtabs: Add a test for external app redirection. > > BUG=673577 > > Review-Url: https://codereview.chromium.org/2805763003 > Cr-Commit-Position: refs/heads/master@{#465548} > Committed: https://chromium.googlesource.com/chromium/src/+/bab2fc9315672da22c940b01a66d0e74a89dcda0 TBR=yusufo@chromium.org,lizeb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=673577 Review-Url: https://codereview.chromium.org/2826093002 Cr-Commit-Position: refs/heads/master@{#465605} Committed: https://chromium.googlesource.com/chromium/src/+/2855bedba4174c9ec04b30fb487d7e11e38abb4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -120 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 6 chunks +54 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java View 3 chunks +1 line, -71 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java View 4 chunks +21 lines, -44 lines 0 comments Download
M chrome/test/data/android/google.html View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael van Ouwerkerk
Created Revert of customtabs: Add a test for external app redirection.
3 years, 8 months ago (2017-04-19 15:03:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826093002/1
3 years, 8 months ago (2017-04-19 15:04:37 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 15:05:15 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2855bedba4174c9ec04b30fb487d...

Powered by Google App Engine
This is Rietveld 408576698