customtabs: Add a test for external app redirection.

customtabs: Add a test for external app redirection.

BUG=673577
Review-Url: https://codereview.chromium.org/2805763003
Cr-Commit-Position: refs/heads/master@{#465548}
Committed: https://chromium.googlesource.com/chromium/src/+/bab2fc9315672da22c940b01a66d0e74a89dcda0

[Benoit L, 2017-04-07 15:27:38]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 15:27:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 17:03:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 17:03:47]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Benoit L, 2017-04-10 08:32:51]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 08:33:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 10:25:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 10:25:59]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Benoit L, 2017-04-10 11:11:41]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[Benoit L, 2017-04-10 11:11:53]

lizeb@chromium.org changed reviewers:
+ yusufo@chromium.org

[commit-bot: I haz the power, 2017-04-10 11:11:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 13:30:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 13:30:15]

Dry run: This issue passed the CQ dry run.

[Benoit L, 2017-04-13 09:00:34]

On 2017/04/10 11:11:54, Benoit L wrote:

ping :-)

[Benoit L, 2017-04-18 16:15:00]

On 2017/04/13 09:00:34, Benoit L wrote:
> On 2017/04/10 11:11:54, Benoit L wrote:
> 
> ping :-)

ping2 :-)

[Yusuf, 2017-04-18 17:33:54]

sorry for the delay.

lgtm with styling nits

https://codereview.chromium.org/2805763003/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java
(right):

https://codereview.chromium.org/2805763003/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java:136:
protected CustomTabsConnection warmUpAndWait() {
javadoc, now that it is protected

https://codereview.chromium.org/2805763003/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java
(right):

https://codereview.chromium.org/2805763003/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java:131:
instanceof CustomTabNavigationDelegate);
indentation off here

https://codereview.chromium.org/2805763003/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java:133:
customTabDelegateFactory.getExternalNavigationDelegate();
indentation?

[Benoit L, 2017-04-19 09:18:46]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2017-04-19 09:18:47]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/2805763003/#ps60001
(title: "Address comments.")

[Benoit L, 2017-04-19 09:19:09]

https://codereview.chromium.org/2805763003/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java
(right):

https://codereview.chromium.org/2805763003/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java:136:
protected CustomTabsConnection warmUpAndWait() {
On 2017/04/18 17:33:54, Yusuf wrote:
> javadoc, now that it is protected

Done.

https://codereview.chromium.org/2805763003/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java
(right):

https://codereview.chromium.org/2805763003/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java:131:
instanceof CustomTabNavigationDelegate);
On 2017/04/18 17:33:54, Yusuf wrote:
> indentation off here

git cl format made me do it :-)
And the presubmit checks insist on it.

I guess that's different because it's in a single expression or something...

https://codereview.chromium.org/2805763003/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabExternalNavigationTest.java:133:
customTabDelegateFactory.getExternalNavigationDelegate();
On 2017/04/18 17:33:54, Yusuf wrote:
> indentation?

ditto.

[commit-bot: I haz the power, 2017-04-19 09:19:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 10:42:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492593526819790,
"parent_rev": "a9c70fe4e42df88f817cb00cbc13a98b7727d99f", "commit_rev":
"bab2fc9315672da22c940b01a66d0e74a89dcda0"}

[commit-bot: I haz the power, 2017-04-19 10:43:09]

Description was changed from

==========
customtabs: Add a test for external app redirection.

BUG=673577
==========

to

==========
customtabs: Add a test for external app redirection.

BUG=673577

Review-Url: https://codereview.chromium.org/2805763003
Cr-Commit-Position: refs/heads/master@{#465548}
Committed:
https://chromium.googlesource.com/chromium/src/+/bab2fc9315672da22c940b01a66d...
==========

[commit-bot: I haz the power, 2017-04-19 10:43:10]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bab2fc9315672da22c940b01a66d...

[Michael van Ouwerkerk, 2017-04-19 15:03:54]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2826093002/ by mvanouwerkerk@chromium.org.

The reason for reverting is: The new testExternalApplicationLink test is failing
on
https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%...

Sample log:
I  369.668s run_tests_on_device(003c650bbb893852)  detected failure in
org.chromium.chrome.browser.customtabs.CustomTabExternalNavigationTest#testExternalApplicationLink.
raw output:
I  369.668s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_STATUS:
numtests=1
I  369.668s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_STATUS:
stream=
I  369.668s run_tests_on_device(003c650bbb893852)   
org.chromium.chrome.browser.customtabs.CustomTabExternalNavigationTest:
I  369.668s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_STATUS:
id=InstrumentationTestRunner
I  369.668s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_STATUS:
test=testExternalApplicationLink
I  369.668s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_STATUS:
class=org.chromium.chrome.browser.customtabs.CustomTabExternalNavigationTest
I  369.669s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_STATUS:
current=1
I  369.669s run_tests_on_device(003c650bbb893852)   
INSTRUMENTATION_STATUS_CODE: 1
I  369.669s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_STATUS:
numtests=1
I  369.669s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_STATUS:
stream=
I  369.669s run_tests_on_device(003c650bbb893852)    Failure in
testExternalApplicationLink:
I  369.669s run_tests_on_device(003c650bbb893852)   
junit.framework.AssertionFailedError: External Activity not launched.
I  369.669s run_tests_on_device(003c650bbb893852)    	at
org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:117)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:138)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
org.chromium.chrome.browser.customtabs.CustomTabExternalNavigationTest.testExternalApplicationLink(CustomTabExternalNavigationTest.java:112)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
I  369.669s run_tests_on_device(003c650bbb893852)    
I  369.669s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_STATUS:
id=InstrumentationTestRunner
I  369.669s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_STATUS:
test=testExternalApplicationLink
I  369.669s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_STATUS:
class=org.chromium.chrome.browser.customtabs.CustomTabExternalNavigationTest
I  369.669s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_STATUS:
stack=junit.framework.AssertionFailedError: External Activity not launched.
I  369.669s run_tests_on_device(003c650bbb893852)    	at
org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:117)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:138)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
org.chromium.chrome.browser.customtabs.CustomTabExternalNavigationTest.testExternalApplicationLink(CustomTabExternalNavigationTest.java:112)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
I  369.669s run_tests_on_device(003c650bbb893852)    	at
android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
I  369.670s run_tests_on_device(003c650bbb893852)    	at
android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
I  369.670s run_tests_on_device(003c650bbb893852)    	at
org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758)
I  369.670s run_tests_on_device(003c650bbb893852)    	at
org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
I  369.670s run_tests_on_device(003c650bbb893852)    	at
org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
I  369.670s run_tests_on_device(003c650bbb893852)    	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
I  369.670s run_tests_on_device(003c650bbb893852)    	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
I  369.670s run_tests_on_device(003c650bbb893852)    	at
android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
I  369.670s run_tests_on_device(003c650bbb893852)    	at
android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
I  369.670s run_tests_on_device(003c650bbb893852)    
I  369.670s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_STATUS:
current=1
I  369.670s run_tests_on_device(003c650bbb893852)   
INSTRUMENTATION_STATUS_CODE: -2
I  369.670s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_RESULT:
stream=
I  369.670s run_tests_on_device(003c650bbb893852)    Test results for
ChromeInstrumentationTestRunner=.F
I  369.670s run_tests_on_device(003c650bbb893852)    Time: 4.437
I  369.670s run_tests_on_device(003c650bbb893852)    
I  369.670s run_tests_on_device(003c650bbb893852)    FAILURES!!!
I  369.670s run_tests_on_device(003c650bbb893852)    Tests run: 1,  Failures: 1,
 Errors: 0
I  369.670s run_tests_on_device(003c650bbb893852)    
I  369.670s run_tests_on_device(003c650bbb893852)    
I  369.670s run_tests_on_device(003c650bbb893852)    INSTRUMENTATION_CODE: -1.