Chromium Code Reviews
Help | Chromium Project | Sign in
(8)

Issue 2825963003: Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/extensions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 3 days ago by tzik
Modified:
1 week, 2 days ago
Reviewers:
Ken Rockot
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, kinuko+fileapi, miu+watch_chromium.org, nhiroki, tfarina, tzik, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/extensions This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters. The tool rewrites base::Bind to base::BindOnce where the resulting Callback is immediately converted to OnceCallback. E.g.: base::PostTask(FROM_HERE, base::Bind(&Foo)); is rewritten to: base::PostTask(FROM_HERE, base::BindOnce(&Foo)); In terms of the behavior change after the rewrite, the OnceCallback implementation moves out the bound argument to the target function, unlike Callback. BUG=554299 Review-Url: https://codereview.chromium.org/2825963003 Cr-Commit-Position: refs/heads/master@{#466094} Committed: https://chromium.googlesource.com/chromium/src/+/8d880eec4559e9763ad13cbbf85f62e9d0c17e2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+634 lines, -746 lines) Patch
M chrome/browser/extensions/activity_log/activity_log.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_policy.h View 1 chunk +6 lines, -9 lines 0 comments Download
M chrome/browser/extensions/activity_log/counting_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_apitest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 5 chunks +19 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/entry_picker.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/extension_info_generator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_api.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 8 chunks +34 lines, -47 lines 0 comments Download
M chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc View 3 chunks +9 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/image_writer_private_apitest.cc View 1 chunk +12 lines, -19 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation.cc View 6 chunks +26 lines, -46 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager.cc View 5 chunks +11 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_unittest.cc View 5 chunks +17 lines, -22 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/removable_storage_provider.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_file_operation.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_url_operation.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/messaging/message_property_provider.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_port.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id_linux.cc View 2 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_api.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/passwords_private/passwords_private_api.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/settings_private/settings_private_event_router.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/socket/udp_socket_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/managed_value_store_cache.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/storage/sync_value_store_cache.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc View 6 chunks +28 lines, -34 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 8 chunks +26 lines, -30 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc View 10 chunks +37 lines, -34 lines 0 comments Download
M chrome/browser/extensions/app_background_page_apitest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/app_data_migrator.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/background_xhr_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/blacklist.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/extensions/blacklist_state_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/extensions/content_verifier_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/extensions/event_router_forwarder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/event_router_forwarder_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_action_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_bindings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_cookie_monster_delegate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_ui.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_garbage_collector.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_messages_apitest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 6 chunks +15 lines, -20 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_storage_monitor.cc View 6 chunks +22 lines, -34 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_install_error.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_pref_loader.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/fake_safe_browsing_database_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/pack_extension_job.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/extensions/signin/gaia_auth_extension_loader.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/startup_helper.cc View 2 chunks +9 lines, -12 lines 0 comments Download
M chrome/browser/extensions/test_blacklist.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_prefs.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 4 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/extensions/updater/extension_cache_fake.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/user_script_listener.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/zipfile_installer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/zipfile_installer_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
Trybot results:  linux_chromium_rel_ng   win_clang   win_chromium_x64_rel_ng   win_chromium_compile_dbg_ng   win_chromium_rel_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-simulator   ios-device-xcode-clang   linux_chromium_tsan_rel_ng   ios-device   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_asan_rel_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   cast_shell_android   linux_android_rel_ng   android_cronet   android_n5x_swarming_rel   android_clang_dbg_recipe   android_compile_dbg   android_arm64_dbg_recipe   win_chromium_x64_rel_ng   win_clang   win_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   mac_chromium_rel_ng   ios-simulator   ios-simulator-xcode-clang   ios-device-xcode-clang   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_asan_rel_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   linux_android_rel_ng   cast_shell_linux   cast_shell_android   android_cronet   android_n5x_swarming_rel   android_compile_dbg   android_clang_dbg_recipe   android_arm64_dbg_recipe 
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (8 generated)
tzik
PTAL
1 week, 3 days ago (2017-04-19 13:32:33 UTC) #6
Ken Rockot
rs lgtm
1 week, 2 days ago (2017-04-20 15:45:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825963003/1
1 week, 2 days ago (2017-04-20 18:07:45 UTC) #9
commit-bot: I haz the power
1 week, 2 days ago (2017-04-20 19:46:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8d880eec4559e9763ad13cbbf85f...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46