chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc - Issue 2825963003: Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc

Issue 2825963003: Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/extensions (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc ('k') | chrome/browser/extensions/api/settings_private/settings_private_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc

diff --git a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc

index 7205a5f0ccb53a98abd246f810e5801222e9e063..3a52e931e0c5228f56b8d984c218b18bd805b01e 100644

--- a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc

+++ b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate_unittest.cc

@@ -109,11 +109,12 @@ class DownloaderTestDelegate : public ExtensionDownloaderTestDelegate {

no_updates_.erase(no_update);

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

- base::Bind(&ExtensionDownloaderDelegate::OnExtensionDownloadFailed,

- base::Unretained(delegate), id,

- ExtensionDownloaderDelegate::NO_UPDATE_AVAILABLE,

- ExtensionDownloaderDelegate::PingResult(),

- fetch_data->request_ids()));

+ base::BindOnce(

+ &ExtensionDownloaderDelegate::OnExtensionDownloadFailed,

+ base::Unretained(delegate), id,

+ ExtensionDownloaderDelegate::NO_UPDATE_AVAILABLE,

+ ExtensionDownloaderDelegate::PingResult(),

+ fetch_data->request_ids()));

continue;

}

auto update = updates_.find(id);

@@ -123,7 +124,7 @@ class DownloaderTestDelegate : public ExtensionDownloaderTestDelegate {

updates_.erase(update);

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

- base::Bind(

+ base::BindOnce(

&ExtensionDownloaderDelegate::OnExtensionDownloadFinished,

base::Unretained(delegate), info,

false /* file_ownership_passed */, GURL(), version,