Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2825793003: Compile metadata_box_controller and quick_view_controller in gyp v2 (Closed)

Created:
3 years, 8 months ago by oka
Modified:
3 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile metadata_box_controller and quick_view_controller in gyp v2 BUG=636289 TEST=run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2825793003 Cr-Commit-Position: refs/heads/master@{#466260} Committed: https://chromium.googlesource.com/chromium/src/+/cdb8d85e00d3406b80e06c5540791bac335d2176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp View 2 chunks +29 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
oka
PTAL
3 years, 8 months ago (2017-04-19 03:50:09 UTC) #6
oka
Friendly ping?
3 years, 8 months ago (2017-04-21 02:18:51 UTC) #10
fukino
lgtm
3 years, 8 months ago (2017-04-21 02:23:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825793003/1
3 years, 8 months ago (2017-04-21 04:18:18 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 04:46:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cdb8d85e00d3406b80e06c554079...

Powered by Google App Engine
This is Rietveld 408576698