Compile file_selection and some other Files app files in gyp v2

Compile file_selection and some other Files app files in gyp v2

Removed dependency from file_selection to file_manager_commands via
observer pattern, and compiled file_selection.
Also compiles some other targets which depends on file_selection.

BUG=636289
TEST=run_compiler. Manually confirmed when selection is changed and
updateFileSelectionAsync_ is called, the commands are updated.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2828633002
Cr-Commit-Position: refs/heads/master@{#466253}
Committed: https://chromium.googlesource.com/chromium/src/+/5fdf6911aa0ae645b60fdbf58e501d550f86fbba

[oka, 2017-04-19 03:01:30]

Description was changed from

==========
Compile file_selection and other Files app files in gyp v2.

Removed dependency from file_selection to file_manager_commands via
observer pattern, and compiled file_selection.
Also compiles some other targets which depends on file_selection.

BUG=636289
TEST=run_compiler, try, manually confirmed when selection is changed and
updateFileSelectionAsync_ is called, the commands are updated.
==========

to

==========
Compile file_selection and other Files app files in gyp v2.

Removed dependency from file_selection to file_manager_commands via
observer pattern, and compiled file_selection.
Also compiles some other targets which depends on file_selection.

BUG=636289
TEST=run_compiler, try, manually confirmed when selection is changed and
updateFileSelectionAsync_ is called, the commands are updated.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-19 03:01:38]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 03:02:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-04-19 03:02:23]

Description was changed from

==========
Compile file_selection and other Files app files in gyp v2.

Removed dependency from file_selection to file_manager_commands via
observer pattern, and compiled file_selection.
Also compiles some other targets which depends on file_selection.

BUG=636289
TEST=run_compiler, try, manually confirmed when selection is changed and
updateFileSelectionAsync_ is called, the commands are updated.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile file_selection and other Files app files in gyp v2.

Removed dependency from file_selection to file_manager_commands via
observer pattern, and compiled file_selection.
Also compiles some other targets which depends on file_selection.

BUG=636289
TEST=run_compiler. Manually confirmed when selection is changed and
updateFileSelectionAsync_ is called, the commands are updated.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-19 03:02:23]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2017-04-19 03:02:38]

Description was changed from

==========
Compile file_selection and other Files app files in gyp v2.

Removed dependency from file_selection to file_manager_commands via
observer pattern, and compiled file_selection.
Also compiles some other targets which depends on file_selection.

BUG=636289
TEST=run_compiler. Manually confirmed when selection is changed and
updateFileSelectionAsync_ is called, the commands are updated.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile file_selection and some other Files app files in gyp v2

Removed dependency from file_selection to file_manager_commands via
observer pattern, and compiled file_selection.
Also compiles some other targets which depends on file_selection.

BUG=636289
TEST=run_compiler. Manually confirmed when selection is changed and
updateFileSelectionAsync_ is called, the commands are updated.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-19 03:02:46]

PTAL.

[oka, 2017-04-19 03:07:43]

.

[oka, 2017-04-19 03:08:36]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 03:08:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-04-19 03:12:06]

Remove an unused assignment.

[oka, 2017-04-19 03:12:10]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 03:12:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-04-19 03:20:04]

Compile main_window_component

[oka, 2017-04-21 02:18:59]

Friendly ping?

[fukino, 2017-04-21 02:28:44]

lgtm with nits.

https://codereview.chromium.org/2828633002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp (right):

https://codereview.chromium.org/2828633002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:152:
'../../background/js/compiled_resources2.gyp:file_operation_manager',
Could you create extern files for background object instead of including them
directory?
Including background scripts in foreground targets will make it difficult to
ship compiled code.

It is OK to do it in a separate patch.

https://codereview.chromium.org/2828633002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:179: #       
'../../background/js/compiled_resources2.gyp:file_operation_manager',
ditto

[oka, 2017-04-21 03:32:41]

Add TODO to depend on externs/ instead of background/.

[oka, 2017-04-21 03:34:07]

Thanks. Will create a change to depend on externs/ instead of background/ as a
separate patch.

https://codereview.chromium.org/2828633002/diff/60001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp (right):

https://codereview.chromium.org/2828633002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:152:
'../../background/js/compiled_resources2.gyp:file_operation_manager',
On 2017/04/21 02:28:44, fukino wrote:
> Could you create extern files for background object instead of including them
> directory?
> Including background scripts in foreground targets will make it difficult to
> ship compiled code.
> 
> It is OK to do it in a separate patch.

Added TODO to use extern/.

https://codereview.chromium.org/2828633002/diff/60001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp:179: #       
'../../background/js/compiled_resources2.gyp:file_operation_manager',
On 2017/04/21 02:28:44, fukino wrote:
> ditto


Added TODO to use extern/.

[oka, 2017-04-21 03:34:21]

The CQ bit was checked by oka@chromium.org

[oka, 2017-04-21 03:34:21]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2828633002/#ps80001
(title: "Add TODO to depend on externs/ instead of background/.")

[commit-bot: I haz the power, 2017-04-21 03:34:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 04:05:39]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492745661193520,
"parent_rev": "23d995ef161f8ed3b4bd84a436655f9e104667f3", "commit_rev":
"5fdf6911aa0ae645b60fdbf58e501d550f86fbba"}

[commit-bot: I haz the power, 2017-04-21 04:06:36]

Description was changed from

==========
Compile file_selection and some other Files app files in gyp v2

Removed dependency from file_selection to file_manager_commands via
observer pattern, and compiled file_selection.
Also compiles some other targets which depends on file_selection.

BUG=636289
TEST=run_compiler. Manually confirmed when selection is changed and
updateFileSelectionAsync_ is called, the commands are updated.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile file_selection and some other Files app files in gyp v2

Removed dependency from file_selection to file_manager_commands via
observer pattern, and compiled file_selection.
Also compiles some other targets which depends on file_selection.

BUG=636289
TEST=run_compiler. Manually confirmed when selection is changed and
updateFileSelectionAsync_ is called, the commands are updated.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2828633002
Cr-Commit-Position: refs/heads/master@{#466253}
Committed:
https://chromium.googlesource.com/chromium/src/+/5fdf6911aa0ae645b60fdbf58e50...
==========

[commit-bot: I haz the power, 2017-04-21 04:06:37]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5fdf6911aa0ae645b60fdbf58e50...