Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 2825713002: Revert of [inspector] avoid cloning of async call chains (Closed)

Created:
3 years, 8 months ago by Michael Achenbach
Modified:
3 years, 8 months ago
Reviewers:
kozy, dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] avoid cloning of async call chains (patchset #7 id:120001 of https://codereview.chromium.org/2816043006/ ) Reason for revert: Speculative revert. Seems to block the roll: https://codereview.chromium.org/2822983004/ Might require changing a browser test first? Original issue's description: > [inspector] avoid cloning of async call chains > > - separated V8StackTraceImpl and AsyncStackTrace, > - V8Debugger owns all AsyncStackTrace and cleanup half of them when limit is reached (first created - first cleaned), > - V8StackTraceImpl, AsyncStackTrace and async-task-related tables in V8Debugger have weak reference to other async stack traces. > - async tasks are cleared with related async stacks. > > BUG=v8:6189 > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2816043006 > Cr-Commit-Position: refs/heads/master@{#44670} > Committed: https://chromium.googlesource.com/v8/v8/+/1bca73bc832c645138bd3e0306fcaa8bb44dad04 TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6189 Review-Url: https://codereview.chromium.org/2825713002 Cr-Commit-Position: refs/heads/master@{#44678} Committed: https://chromium.googlesource.com/v8/v8/+/6fac39b33378511b0ba18c86cf08118e62861957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+675 lines, -918 lines) Patch
M src/inspector/v8-console.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/v8-debugger.h View 7 chunks +11 lines, -21 lines 0 comments Download
M src/inspector/v8-debugger.cc View 12 chunks +74 lines, -80 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/inspector/v8-debugger-agent-impl.cc View 4 chunks +6 lines, -11 lines 0 comments Download
M src/inspector/v8-stack-trace-impl.h View 1 chunk +59 lines, -81 lines 0 comments Download
M src/inspector/v8-stack-trace-impl.cc View 4 chunks +219 lines, -228 lines 0 comments Download
A test/inspector/debugger/async-stacks-limit.js View 1 chunk +164 lines, -0 lines 0 comments Download
A test/inspector/debugger/async-stacks-limit-expected.txt View 1 chunk +140 lines, -0 lines 0 comments Download
D test/inspector/debugger/collect-old-async-call-chains.js View 1 chunk +0 lines, -171 lines 0 comments Download
D test/inspector/debugger/collect-old-async-call-chains-expected.txt View 1 chunk +0 lines, -211 lines 0 comments Download
D test/inspector/debugger/set-async-call-stack-depth.js View 1 chunk +0 lines, -77 lines 0 comments Download
D test/inspector/debugger/set-async-call-stack-depth-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [inspector] avoid cloning of async call chains
3 years, 8 months ago (2017-04-18 10:17:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825713002/1
3 years, 8 months ago (2017-04-18 10:17:23 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 10:17:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6fac39b33378511b0ba18c86cf08118e628...

Powered by Google App Engine
This is Rietveld 408576698