[inspector] avoid cloning of async call chains

[inspector] avoid cloning of async call chains

- separated V8StackTraceImpl and AsyncStackTrace,
- V8Debugger owns all AsyncStackTrace and cleanup half of them when limit is reached (first created - first cleaned),
- V8StackTraceImpl, AsyncStackTrace and async-task-related tables in V8Debugger have weak reference to other async stack traces.
- async tasks are cleared with related async stacks.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2816043006
Cr-Original-Commit-Position: refs/heads/master@{#44670}
Committed: https://chromium.googlesource.com/v8/v8/+/1bca73bc832c645138bd3e0306fcaa8bb44dad04
Review-Url: https://codereview.chromium.org/2816043006
Cr-Commit-Position: refs/heads/master@{#44694}
Committed: https://chromium.googlesource.com/v8/v8/+/38be4a17c198a93154b1dfa1908e955f929ca825

[kozy, 2017-04-16 07:58:48]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-16 07:58:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-16 08:02:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-16 08:02:07]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/26069)

[kozy, 2017-04-17 07:07:11]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 07:07:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-04-17 07:10:56]

Description was changed from

==========
[inspector] better stacks

BUG=
==========

to

==========
[inspector] avoid cloning of async call chains

- separated V8StackTraceImpl and AsyncStackTrace,
- V8Debugger owns all AsyncStackTrace and cleanup half of them when limit is
reached (first created - first cleaned),
- V8StackTraceImpl, AsyncStackTrace and async-task-related tables in V8Debugger
have weak reference to other async stack traces.
- async tasks are cleared with related async stacks.

BUG=v8:6189
R=dgozman@chromium.org
==========

[kozy, 2017-04-17 07:10:56]

kozyatinskiy@chromium.org changed reviewers:
+ dgozman@chromium.org

[kozy, 2017-04-17 07:11:43]

Dmitry, please take a look. Another attempt.

[commit-bot: I haz the power, 2017-04-17 07:34:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 07:34:53]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-17 17:49:09]

Looks reasonable!

While reading V8StackTraceImpl, I thought that it could make sense to extract
SyncStackTrace (just a vector of frames), and have an instance inside both
V8StackTraceImpl and AsyncStackTrace. Not sure it would be cleaner, but maybe?

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-debugg...
File src/inspector/v8-debugger.cc (left):

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger.cc:872: // Passing one as maxStackSize forces no async
chain for the new stack and
Leave this comment about passing one.

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-debugg...
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger.cc:653: v8::Context::Scope contextScope(context);
Why new scope?

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger.cc:890: std::shared_ptr<AsyncStackTrace> chain =
nit: chain -> asyncStack

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
File src/inspector/v8-stack-trace-impl.cc (left):

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.cc:30: if (!sourceNameValue.IsEmpty())
Where did all IsEmpty checks go?

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
File src/inspector/v8-stack-trace-impl.cc (right):

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.cc:99: int maxAsyncDepth;
= 0;

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.cc:232: std::shared_ptr<AsyncStackTrace>
AsyncStackTrace::capture(
Can we extract common logic from this and V8StackTraceImpl::create into a helper
method?

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.cc:299:
AsyncStackTrace::buildInspectorObject(AsyncStackTrace* asyncCreation,
Same for buildInspectorObject.

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
File src/inspector/v8-stack-trace-impl.h (right):

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.h:33: int contextGroupId,
Isn't contextGroupId === debugger->CurrentContextGroupId() ?

https://codereview.chromium.org/2816043006/diff/40001/test/inspector/debugger...
File test/inspector/debugger/async-stacks-limit-expected.txt (left):

https://codereview.chromium.org/2816043006/diff/40001/test/inspector/debugger...
test/inspector/debugger/async-stacks-limit-expected.txt:30: -- Promise.resolve
--
Not sure why this has changed. Perhaps, we need to change the test as well?

[kozy, 2017-04-17 21:32:52]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 21:33:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-04-17 21:34:18]

All done. Please take another look.

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-debugg...
File src/inspector/v8-debugger.cc (left):

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger.cc:872: // Passing one as maxStackSize forces no async
chain for the new stack and
On 2017/04/17 17:49:08, dgozman wrote:
> Leave this comment about passing one.

But it's not a true - we don't grow exponentially, I will left lighter version
of this comment.

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-debugg...
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger.cc:653: v8::Context::Scope contextScope(context);
On 2017/04/17 17:49:08, dgozman wrote:
> Why new scope?

It wasn't new - moved from v8::debug::kDebugPromiseCreated. But the reason is we
enter debugger context before calling this delegate method on v8 side. I removed
this entering there and currently we don't need this scope at all :)

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-debugg...
src/inspector/v8-debugger.cc:890: std::shared_ptr<AsyncStackTrace> chain =
On 2017/04/17 17:49:08, dgozman wrote:
> nit: chain -> asyncStack

Done.

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
File src/inspector/v8-stack-trace-impl.cc (left):

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.cc:30: if (!sourceNameValue.IsEmpty())
On 2017/04/17 17:49:08, dgozman wrote:
> Where did all IsEmpty checks go?

Our toProtocolString function checks it internally.

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
File src/inspector/v8-stack-trace-impl.cc (right):

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.cc:99: int maxAsyncDepth;
On 2017/04/17 17:49:08, dgozman wrote:
> = 0;

Done.

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.cc:232: std::shared_ptr<AsyncStackTrace>
AsyncStackTrace::capture(
On 2017/04/17 17:49:08, dgozman wrote:
> Can we extract common logic from this and V8StackTraceImpl::create into a
helper
> method?

Done.

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.cc:299:
AsyncStackTrace::buildInspectorObject(AsyncStackTrace* asyncCreation,
On 2017/04/17 17:49:08, dgozman wrote:
> Same for buildInspectorObject.

Done.

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
File src/inspector/v8-stack-trace-impl.h (right):

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.h:33: int contextGroupId,
On 2017/04/17 17:49:08, dgozman wrote:
> Isn't contextGroupId === debugger->CurrentContextGroupId() ?

Not always, I think someone can call captureStacktrace without current context
to get async history.

https://codereview.chromium.org/2816043006/diff/40001/test/inspector/debugger...
File test/inspector/debugger/async-stacks-limit-expected.txt (left):

https://codereview.chromium.org/2816043006/diff/40001/test/inspector/debugger...
test/inspector/debugger/async-stacks-limit-expected.txt:30: -- Promise.resolve
--
On 2017/04/17 17:49:08, dgozman wrote:
> Not sure why this has changed. Perhaps, we need to change the test as well?

Added better test.

[kozy, 2017-04-17 21:42:17]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 21:42:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 22:06:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 22:06:29]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-17 23:03:16]

lgtm

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
File src/inspector/v8-stack-trace-impl.h (right):

https://codereview.chromium.org/2816043006/diff/40001/src/inspector/v8-stack-...
src/inspector/v8-stack-trace-impl.h:33: int contextGroupId,
On 2017/04/17 21:34:17, kozy wrote:
> On 2017/04/17 17:49:08, dgozman wrote:
> > Isn't contextGroupId === debugger->CurrentContextGroupId() ?
> 
> Not always, I think someone can call captureStacktrace without current context
> to get async history.

We should fix that in a follow-up!

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
src/inspector/v8-debugger-agent-impl.cc:1038:
m_debugger->maxAsyncCallChainDepth() - 1);
Why -1? Should we turn the parameter into maxChainLength (including the top)?

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
src/inspector/v8-debugger.cc:647: if (type == v8::debug::kDebugPromiseCollected)
{
Undo this part now.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
src/inspector/v8-debugger.cc:1023: m_maxAsyncCallStacks / 2 +
m_maxAsyncCallStacks % 2) {
nit: extract a variable for this.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
File src/inspector/v8-debugger.h (right):

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
src/inspector/v8-debugger.h:199: std::list<std::shared_ptr<AsyncStackTrace>>
m_allAsyncStacks;
Let's comment that this owns all the stacks, while most of the other references
are weak, which allows to collect some stacks when there are too many.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
File src/inspector/v8-stack-trace-impl.cc (right):

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
src/inspector/v8-stack-trace-impl.cc:70: std::shared_ptr<AsyncStackTrace>
asyncParent,
For more efficiency:
const shared_ptr<>&

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
src/inspector/v8-stack-trace-impl.cc:182: m_maxAsyncDepth(maxAsyncDepth),
That's a pity...

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
src/inspector/v8-stack-trace-impl.cc:275: return
std::shared_ptr<AsyncStackTrace>(new AsyncStackTrace(
return asyncParent ?

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
File src/inspector/v8-stack-trace-impl.h (right):

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
src/inspector/v8-stack-trace-impl.h:45: // 1-based.
nit: you can put this comment on next line after override.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
src/inspector/v8-stack-trace-impl.h:55: class Frame {
I think we should turn this into a top-level struct in a follow-up.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
src/inspector/v8-stack-trace-impl.h:86: int m_maxAsyncDepth;
Is this total length or async chain length?

https://codereview.chromium.org/2816043006/diff/100001/test/inspector/debugge...
File test/inspector/debugger/collect-old-async-call-chains-expected.txt (right):

https://codereview.chromium.org/2816043006/diff/100001/test/inspector/debugge...
test/inspector/debugger/collect-old-async-call-chains-expected.txt:76: actual
async chain len: 0
Why zero everywhere?

[kozy, 2017-04-18 01:04:21]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 01:04:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-04-18 01:04:39]

thanks! all done.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
File src/inspector/v8-debugger-agent-impl.cc (right):

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
src/inspector/v8-debugger-agent-impl.cc:1038:
m_debugger->maxAsyncCallChainDepth() - 1);
On 2017/04/17 23:03:15, dgozman wrote:
> Why -1? Should we turn the parameter into maxChainLength (including the top)?

I'd like to have this value aligned with maxDepth passed to protocol method and
maxChainLength = 0 doesn't have any sense - we always report sync stack trace.

Here it's -1 because this argument describe maximum amount of async chain in
addition to current stack trace.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
src/inspector/v8-debugger.cc:647: if (type == v8::debug::kDebugPromiseCollected)
{
On 2017/04/17 23:03:15, dgozman wrote:
> Undo this part now.

Done.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
src/inspector/v8-debugger.cc:1023: m_maxAsyncCallStacks / 2 +
m_maxAsyncCallStacks % 2) {
On 2017/04/17 23:03:15, dgozman wrote:
> nit: extract a variable for this.

Done.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
File src/inspector/v8-debugger.h (right):

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-debug...
src/inspector/v8-debugger.h:199: std::list<std::shared_ptr<AsyncStackTrace>>
m_allAsyncStacks;
On 2017/04/17 23:03:15, dgozman wrote:
> Let's comment that this owns all the stacks, while most of the other
references
> are weak, which allows to collect some stacks when there are too many.

Done.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
File src/inspector/v8-stack-trace-impl.cc (right):

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
src/inspector/v8-stack-trace-impl.cc:70: std::shared_ptr<AsyncStackTrace>
asyncParent,
On 2017/04/17 23:03:16, dgozman wrote:
> For more efficiency:
> const shared_ptr<>&

Done.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
src/inspector/v8-stack-trace-impl.cc:182: m_maxAsyncDepth(maxAsyncDepth),
On 2017/04/17 23:03:16, dgozman wrote:
> That's a pity...

:(

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
src/inspector/v8-stack-trace-impl.cc:275: return
std::shared_ptr<AsyncStackTrace>(new AsyncStackTrace(
On 2017/04/17 23:03:16, dgozman wrote:
> return asyncParent ?

yep.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
File src/inspector/v8-stack-trace-impl.h (right):

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
src/inspector/v8-stack-trace-impl.h:45: // 1-based.
On 2017/04/17 23:03:16, dgozman wrote:
> nit: you can put this comment on next line after override.

Done.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
src/inspector/v8-stack-trace-impl.h:55: class Frame {
On 2017/04/17 23:03:16, dgozman wrote:
> I think we should turn this into a top-level struct in a follow-up.

Acknowledged.

https://codereview.chromium.org/2816043006/diff/100001/src/inspector/v8-stack...
src/inspector/v8-stack-trace-impl.h:86: int m_maxAsyncDepth;
On 2017/04/17 23:03:16, dgozman wrote:
> Is this total length or async chain length?

it's async chain length.

https://codereview.chromium.org/2816043006/diff/100001/test/inspector/debugge...
File test/inspector/debugger/collect-old-async-call-chains-expected.txt (right):

https://codereview.chromium.org/2816043006/diff/100001/test/inspector/debugge...
test/inspector/debugger/collect-old-async-call-chains-expected.txt:76: actual
async chain len: 0
On 2017/04/17 23:03:16, dgozman wrote:
> Why zero everywhere?

When we collect old stacks we removed all except current one, current one has
two stacks: creation and parent.

[commit-bot: I haz the power, 2017-04-18 01:28:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 01:28:23]

Dry run: This issue passed the CQ dry run.

[kozy, 2017-04-18 01:40:51]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-04-18 01:40:52]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2816043006/#ps120001
(title: "added a test")

[commit-bot: I haz the power, 2017-04-18 01:41:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 01:42:36]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492479651570480,
"parent_rev": "71cf4890d0a2bc3ac47597d724676df871a572d5", "commit_rev":
"1bca73bc832c645138bd3e0306fcaa8bb44dad04"}

[commit-bot: I haz the power, 2017-04-18 01:42:43]

Description was changed from

==========
[inspector] avoid cloning of async call chains

- separated V8StackTraceImpl and AsyncStackTrace,
- V8Debugger owns all AsyncStackTrace and cleanup half of them when limit is
reached (first created - first cleaned),
- V8StackTraceImpl, AsyncStackTrace and async-task-related tables in V8Debugger
have weak reference to other async stack traces.
- async tasks are cleared with related async stacks.

BUG=v8:6189
R=dgozman@chromium.org
==========

to

==========
[inspector] avoid cloning of async call chains

- separated V8StackTraceImpl and AsyncStackTrace,
- V8Debugger owns all AsyncStackTrace and cleanup half of them when limit is
reached (first created - first cleaned),
- V8StackTraceImpl, AsyncStackTrace and async-task-related tables in V8Debugger
have weak reference to other async stack traces.
- async tasks are cleared with related async stacks.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2816043006
Cr-Commit-Position: refs/heads/master@{#44670}
Committed:
https://chromium.googlesource.com/v8/v8/+/1bca73bc832c645138bd3e0306fcaa8bb44...
==========

[commit-bot: I haz the power, 2017-04-18 01:42:44]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/1bca73bc832c645138bd3e0306fcaa8bb44...

[Michael Achenbach, 2017-04-18 10:17:15]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2825713002/ by machenbach@chromium.org.

The reason for reverting is: Speculative revert. Seems to block the roll:
https://codereview.chromium.org/2822983004/

Might require changing a browser test first?.

[kozy, 2017-04-18 14:42:29]

Description was changed from

==========
[inspector] avoid cloning of async call chains

- separated V8StackTraceImpl and AsyncStackTrace,
- V8Debugger owns all AsyncStackTrace and cleanup half of them when limit is
reached (first created - first cleaned),
- V8StackTraceImpl, AsyncStackTrace and async-task-related tables in V8Debugger
have weak reference to other async stack traces.
- async tasks are cleared with related async stacks.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2816043006
Cr-Commit-Position: refs/heads/master@{#44670}
Committed:
https://chromium.googlesource.com/v8/v8/+/1bca73bc832c645138bd3e0306fcaa8bb44...
==========

to

==========
[inspector] avoid cloning of async call chains

- separated V8StackTraceImpl and AsyncStackTrace,
- V8Debugger owns all AsyncStackTrace and cleanup half of them when limit is
reached (first created - first cleaned),
- V8StackTraceImpl, AsyncStackTrace and async-task-related tables in V8Debugger
have weak reference to other async stack traces.
- async tasks are cleared with related async stacks.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2816043006
Cr-Commit-Position: refs/heads/master@{#44670}
Committed:
https://chromium.googlesource.com/v8/v8/+/1bca73bc832c645138bd3e0306fcaa8bb44...
==========

[kozy, 2017-04-18 15:29:09]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-04-18 15:29:09]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2816043006/#ps140001
(title: "lines and columns in stack string should be 1-based")

[commit-bot: I haz the power, 2017-04-18 15:29:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 15:53:08]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1492529349302490,
"parent_rev": "7fcf658a7b1c82041931046d306eb74ad8aae474", "commit_rev":
"38be4a17c198a93154b1dfa1908e955f929ca825"}

[commit-bot: I haz the power, 2017-04-18 15:53:16]

Description was changed from

==========
[inspector] avoid cloning of async call chains

- separated V8StackTraceImpl and AsyncStackTrace,
- V8Debugger owns all AsyncStackTrace and cleanup half of them when limit is
reached (first created - first cleaned),
- V8StackTraceImpl, AsyncStackTrace and async-task-related tables in V8Debugger
have weak reference to other async stack traces.
- async tasks are cleared with related async stacks.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2816043006
Cr-Commit-Position: refs/heads/master@{#44670}
Committed:
https://chromium.googlesource.com/v8/v8/+/1bca73bc832c645138bd3e0306fcaa8bb44...
==========

to

==========
[inspector] avoid cloning of async call chains

- separated V8StackTraceImpl and AsyncStackTrace,
- V8Debugger owns all AsyncStackTrace and cleanup half of them when limit is
reached (first created - first cleaned),
- V8StackTraceImpl, AsyncStackTrace and async-task-related tables in V8Debugger
have weak reference to other async stack traces.
- async tasks are cleared with related async stacks.

BUG=v8:6189
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2816043006
Cr-Original-Commit-Position: refs/heads/master@{#44670}
Committed:
https://chromium.googlesource.com/v8/v8/+/1bca73bc832c645138bd3e0306fcaa8bb44...
Review-Url: https://codereview.chromium.org/2816043006
Cr-Commit-Position: refs/heads/master@{#44694}
Committed:
https://chromium.googlesource.com/v8/v8/+/38be4a17c198a93154b1dfa1908e955f929...
==========

[commit-bot: I haz the power, 2017-04-18 15:53:17]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/v8/v8/+/38be4a17c198a93154b1dfa1908e955f929...