Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2825703002: Make a use counter name 1 char shorter to avoid line wrapping (Closed)

Created:
3 years, 8 months ago by foolip
Modified:
3 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-frames_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make a use counter name 1 char shorter to avoid line wrapping This line became wrapped in The Blink Rename: https://chromium-review.googlesource.com/472192 Use the DOM spelling of cancelable to get 1 char back: https://dom.spec.whatwg.org/#dom-event-cancelable This should avoid the need to make update_use_counter_feature_enum.py more clever about parsing. BUG=711205 R=haraken@chromium.org NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2825703002 Cr-Commit-Position: refs/heads/master@{#465189} Committed: https://chromium.googlesource.com/chromium/src/+/37ab82a26af3aa8755c1ab245240ce92e6b9896c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M third_party/WebKit/Source/core/events/TouchEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/TouchEventTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
foolip
3 years, 8 months ago (2017-04-18 07:38:06 UTC) #1
haraken
LGTM
3 years, 8 months ago (2017-04-18 07:39:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825703002/1
3 years, 8 months ago (2017-04-18 07:53:27 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 09:36:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/37ab82a26af3aa8755c1ab245240...

Powered by Google App Engine
This is Rietveld 408576698