Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: third_party/WebKit/Source/core/events/TouchEventTest.cpp

Issue 2825703002: Make a use counter name 1 char shorter to avoid line wrapping (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/events/TouchEvent.h" 5 #include "core/events/TouchEvent.h"
6 6
7 #include "core/frame/FrameConsole.h" 7 #include "core/frame/FrameConsole.h"
8 #include "core/frame/UseCounter.h" 8 #include "core/frame/UseCounter.h"
9 #include "core/loader/EmptyClients.h" 9 #include "core/loader/EmptyClients.h"
10 #include "core/testing/DummyPageHolder.h" 10 #include "core/testing/DummyPageHolder.h"
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 79
80 EXPECT_THAT(Messages(), ElementsAre()); 80 EXPECT_THAT(Messages(), ElementsAre());
81 event->preventDefault(); 81 event->preventDefault();
82 EXPECT_THAT(Messages(), 82 EXPECT_THAT(Messages(),
83 ElementsAre("Ignored attempt to cancel a touchstart event with " 83 ElementsAre("Ignored attempt to cancel a touchstart event with "
84 "cancelable=false, for example because scrolling is " 84 "cancelable=false, for example because scrolling is "
85 "in progress and cannot be interrupted.")); 85 "in progress and cannot be interrupted."));
86 EXPECT_THAT(MessageSources(), ElementsAre(kJSMessageSource)); 86 EXPECT_THAT(MessageSources(), ElementsAre(kJSMessageSource));
87 87
88 EXPECT_TRUE(UseCounter::IsCounted( 88 EXPECT_TRUE(UseCounter::IsCounted(
89 GetDocument(), UseCounter::kUncancellableTouchEventPreventDefaulted)); 89 GetDocument(), UseCounter::kUncancelableTouchEventPreventDefaulted));
90 EXPECT_FALSE(UseCounter::IsCounted( 90 EXPECT_FALSE(UseCounter::IsCounted(
91 GetDocument(), 91 GetDocument(),
92 UseCounter:: 92 UseCounter::
93 kUncancellableTouchEventDueToMainThreadResponsivenessPreventDefaulted) ); 93 kUncancelableTouchEventDueToMainThreadResponsivenessPreventDefaulted)) ;
94 } 94 }
95 95
96 TEST_F(TouchEventTest, 96 TEST_F(TouchEventTest,
97 PreventDefaultUncancelableDueToMainThreadResponsiveness) { 97 PreventDefaultUncancelableDueToMainThreadResponsiveness) {
98 TouchEvent* event = EventWithDispatchType( 98 TouchEvent* event = EventWithDispatchType(
99 WebInputEvent::kListenersForcedNonBlockingDueToMainThreadResponsiveness); 99 WebInputEvent::kListenersForcedNonBlockingDueToMainThreadResponsiveness);
100 event->SetHandlingPassive(Event::PassiveMode::kNotPassiveDefault); 100 event->SetHandlingPassive(Event::PassiveMode::kNotPassiveDefault);
101 101
102 EXPECT_THAT(Messages(), ElementsAre()); 102 EXPECT_THAT(Messages(), ElementsAre());
103 event->preventDefault(); 103 event->preventDefault();
104 EXPECT_THAT(Messages(), 104 EXPECT_THAT(Messages(),
105 ElementsAre("Ignored attempt to cancel a touchstart event with " 105 ElementsAre("Ignored attempt to cancel a touchstart event with "
106 "cancelable=false. This event was forced to be " 106 "cancelable=false. This event was forced to be "
107 "non-cancellable because the page was too busy to " 107 "non-cancellable because the page was too busy to "
108 "handle the event promptly.")); 108 "handle the event promptly."));
109 EXPECT_THAT(MessageSources(), ElementsAre(kInterventionMessageSource)); 109 EXPECT_THAT(MessageSources(), ElementsAre(kInterventionMessageSource));
110 110
111 EXPECT_TRUE(UseCounter::IsCounted( 111 EXPECT_TRUE(UseCounter::IsCounted(
112 GetDocument(), UseCounter::kUncancellableTouchEventPreventDefaulted)); 112 GetDocument(), UseCounter::kUncancelableTouchEventPreventDefaulted));
113 EXPECT_TRUE(UseCounter::IsCounted( 113 EXPECT_TRUE(UseCounter::IsCounted(
114 GetDocument(), 114 GetDocument(),
115 UseCounter:: 115 UseCounter::
116 kUncancellableTouchEventDueToMainThreadResponsivenessPreventDefaulted) ); 116 kUncancelableTouchEventDueToMainThreadResponsivenessPreventDefaulted)) ;
117 } 117 }
118 118
119 TEST_F(TouchEventTest, 119 TEST_F(TouchEventTest,
120 PreventDefaultPassiveDueToDocumentLevelScrollerIntervention) { 120 PreventDefaultPassiveDueToDocumentLevelScrollerIntervention) {
121 TouchEvent* event = 121 TouchEvent* event =
122 EventWithDispatchType(WebInputEvent::kListenersNonBlockingPassive); 122 EventWithDispatchType(WebInputEvent::kListenersNonBlockingPassive);
123 event->SetHandlingPassive(Event::PassiveMode::kPassiveForcedDocumentLevel); 123 event->SetHandlingPassive(Event::PassiveMode::kPassiveForcedDocumentLevel);
124 124
125 EXPECT_THAT(Messages(), ElementsAre()); 125 EXPECT_THAT(Messages(), ElementsAre());
126 event->preventDefault(); 126 event->preventDefault();
127 EXPECT_THAT( 127 EXPECT_THAT(
128 Messages(), 128 Messages(),
129 ElementsAre("Unable to preventDefault inside passive event listener due " 129 ElementsAre("Unable to preventDefault inside passive event listener due "
130 "to target being treated as passive. See " 130 "to target being treated as passive. See "
131 "https://www.chromestatus.com/features/5093566007214080")); 131 "https://www.chromestatus.com/features/5093566007214080"));
132 EXPECT_THAT(MessageSources(), ElementsAre(kInterventionMessageSource)); 132 EXPECT_THAT(MessageSources(), ElementsAre(kInterventionMessageSource));
133 } 133 }
134 134
135 class TouchEventTestNoFrame : public testing::Test {}; 135 class TouchEventTestNoFrame : public testing::Test {};
136 136
137 TEST_F(TouchEventTestNoFrame, PreventDefaultDoesntRequireFrame) { 137 TEST_F(TouchEventTestNoFrame, PreventDefaultDoesntRequireFrame) {
138 TouchEvent::Create()->preventDefault(); 138 TouchEvent::Create()->preventDefault();
139 } 139 }
140 140
141 } // namespace blink 141 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/events/TouchEvent.cpp ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698