Update ash phantom window aesthetics.

Update ash phantom window aesthetics.

The phantom windows show where a dragged window will be snapped. This
uses asset-less rendering and normal WM shadows instead of tiling a
shadow asset.

BUG=708212
Review-Url: https://codereview.chromium.org/2825613002
Cr-Commit-Position: refs/heads/master@{#465304}
Committed: https://chromium.googlesource.com/chromium/src/+/871d538390b1c6c394176894f8b855d8b775d109

[Evan Stade, 2017-04-17 23:26:38]

estade@chromium.org changed reviewers:
+ oshima@chromium.org

[Evan Stade, 2017-04-17 23:26:44]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 23:27:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 00:18:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 00:18:02]

Dry run: This issue passed the CQ dry run.

[oshima, 2017-04-18 05:02:48]

have you tested this with arc windows? just want to make sure it won't cause any
regression.

https://codereview.chromium.org/2825613002/diff/1/ash/wm/workspace/phantom_wi...
File ash/wm/workspace/phantom_window_controller.cc (right):

https://codereview.chromium.org/2825613002/diff/1/ash/wm/workspace/phantom_wi...
ash/wm/workspace/phantom_window_controller.cc:98: // const int kImages[] =
IMAGE_GRID(IDR_AURA_PHANTOM_WINDOW);
nit: remove this

https://codereview.chromium.org/2825613002/diff/1/ash/wm/workspace/phantom_wi...
ash/wm/workspace/phantom_window_controller.cc:101: SkColorSetA(SK_ColorWHITE,
0.4 * 255)));
do we still need content_view? if so, can we use solid color layer instead?

[oshima, 2017-04-18 05:04:03]

On 2017/04/18 05:02:48, oshima wrote:
> have you tested this with arc windows? just want to make sure it won't cause
any
> regression.

sorry, hit send too early. I was going to say, "If not, I'll test it tomorrow."

> 
>
https://codereview.chromium.org/2825613002/diff/1/ash/wm/workspace/phantom_wi...
> File ash/wm/workspace/phantom_window_controller.cc (right):
> 
>
https://codereview.chromium.org/2825613002/diff/1/ash/wm/workspace/phantom_wi...
> ash/wm/workspace/phantom_window_controller.cc:98: // const int kImages[] =
> IMAGE_GRID(IDR_AURA_PHANTOM_WINDOW);
> nit: remove this
> 
>
https://codereview.chromium.org/2825613002/diff/1/ash/wm/workspace/phantom_wi...
> ash/wm/workspace/phantom_window_controller.cc:101: SkColorSetA(SK_ColorWHITE,
> 0.4 * 255)));
> do we still need content_view? if so, can we use solid color layer instead?

[Evan Stade, 2017-04-18 14:35:54]

On 2017/04/18 05:04:03, oshima wrote:
> On 2017/04/18 05:02:48, oshima wrote:
> > have you tested this with arc windows? just want to make sure it won't cause
> any
> > regression.
> 
> sorry, hit send too early. I was going to say, "If not, I'll test it
tomorrow."

haven't tested on arc. That would be great; thanks! I don't expect it would
matter though since we aren't doing anything differently to the actual dragged
window.

https://codereview.chromium.org/2825613002/diff/1/ash/wm/workspace/phantom_wi...
File ash/wm/workspace/phantom_window_controller.cc (right):

https://codereview.chromium.org/2825613002/diff/1/ash/wm/workspace/phantom_wi...
ash/wm/workspace/phantom_window_controller.cc:98: // const int kImages[] =
IMAGE_GRID(IDR_AURA_PHANTOM_WINDOW);
On 2017/04/18 05:02:48, oshima wrote:
> nit: remove this

Done.

https://codereview.chromium.org/2825613002/diff/1/ash/wm/workspace/phantom_wi...
ash/wm/workspace/phantom_window_controller.cc:101: SkColorSetA(SK_ColorWHITE,
0.4 * 255)));
On 2017/04/18 05:02:48, oshima wrote:
> do we still need content_view? if so, can we use solid color layer instead?

good idea, done.

[Evan Stade, 2017-04-18 14:35:59]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 14:36:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 15:38:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 15:38:12]

Dry run: This issue passed the CQ dry run.

[oshima, 2017-04-18 18:11:31]

lgtm

[Evan Stade, 2017-04-18 18:19:26]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-04-18 18:20:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 18:51:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492539566277280,
"parent_rev": "2504c4da27a272a4906a7fd1bde697c8bdf7def1", "commit_rev":
"871d538390b1c6c394176894f8b855d8b775d109"}

[commit-bot: I haz the power, 2017-04-18 18:51:36]

Description was changed from

==========
Update ash phantom window aesthetics.

The phantom windows show where a dragged window will be snapped. This
uses asset-less rendering and normal WM shadows instead of tiling a
shadow asset.

BUG=708212
==========

to

==========
Update ash phantom window aesthetics.

The phantom windows show where a dragged window will be snapped. This
uses asset-less rendering and normal WM shadows instead of tiling a
shadow asset.

BUG=708212

Review-Url: https://codereview.chromium.org/2825613002
Cr-Commit-Position: refs/heads/master@{#465304}
Committed:
https://chromium.googlesource.com/chromium/src/+/871d538390b1c6c394176894f8b8...
==========

[commit-bot: I haz the power, 2017-04-18 18:51:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/871d538390b1c6c394176894f8b8...