Update update_histogram_enum.py and update_use_counter_feature_enum.py for Blink rename

Update update_histogram_enum.py and update_use_counter_feature_enum.py for Blink rename

This patch updates the scripts for keeping histograms.xml up-to-date so
that they work correctly after the recent Blink rename.

While all the feature enums are now written as kFooMetric, we'd prefer
to have them show as FooMetric in the histograms so support is added for
dropping a leading 'k'.

This patch also adds support for enums with super long names, such as
kUncancellableTouchEventDueToMainThreadResponsivenessPreventDefaulted,
which cause the enum initialization to end up on a separate line.

BUG=675877
Review-Url: https://codereview.chromium.org/2825573003
Cr-Commit-Position: refs/heads/master@{#465178}
Committed: https://chromium.googlesource.com/chromium/src/+/4b963a8aa430d5937da3f3cdc7bafcd614d36877

[Timothy Loh, 2017-04-18 05:22:59]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 05:23:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2017-04-18 05:26:10]

timloh@chromium.org changed reviewers:
+ dcheng@chromium.org, isherman@chromium.org

[Timothy Loh, 2017-04-18 05:26:11]

https://codereview.chromium.org/2825573003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/PRESUBMIT.py (right):

https://codereview.chromium.org/2825573003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/PRESUBMIT.py:75: start_marker = '^enum
Feature : uint32_t {'
pylint doesn't like it, I prefer to rename rather than disable pylint on the
lines. pylint considers top-level variables as constants, while this is in a
function so it doesn't want it to be upper case.

[dcheng, 2017-04-18 05:30:42]

blink lgtm

[Ilya Sherman, 2017-04-18 05:55:09]

Thanks!  LGTM % nits:

https://codereview.chromium.org/2825573003/diff/1/tools/metrics/histograms/up...
File tools/metrics/histograms/update_use_counter_feature_enum.py (right):

https://codereview.chromium.org/2825573003/diff/1/tools/metrics/histograms/up...
tools/metrics/histograms/update_use_counter_feature_enum.py:42: END_MARKER,
strip_k_prefix = True)
nit: Please omit the spaces around the = sign.

https://codereview.chromium.org/2825573003/diff/1/tools/metrics/histograms/up...
tools/metrics/histograms/update_use_counter_feature_enum.py:50: strip_k_prefix =
True)
nit: Please omit the spaces around the = sign.

[Timothy Loh, 2017-04-18 06:03:02]

The CQ bit was checked by timloh@chromium.org

[Timothy Loh, 2017-04-18 06:03:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2825573003/#ps20001
(title: "remove spaces")

[Timothy Loh, 2017-04-18 06:03:10]

https://codereview.chromium.org/2825573003/diff/1/tools/metrics/histograms/up...
File tools/metrics/histograms/update_use_counter_feature_enum.py (right):

https://codereview.chromium.org/2825573003/diff/1/tools/metrics/histograms/up...
tools/metrics/histograms/update_use_counter_feature_enum.py:42: END_MARKER,
strip_k_prefix = True)
On 2017/04/18 05:55:09, Ilya Sherman wrote:
> nit: Please omit the spaces around the = sign.

Done.

https://codereview.chromium.org/2825573003/diff/1/tools/metrics/histograms/up...
tools/metrics/histograms/update_use_counter_feature_enum.py:50: strip_k_prefix =
True)
On 2017/04/18 05:55:09, Ilya Sherman wrote:
> nit: Please omit the spaces around the = sign.

Done.

[commit-bot: I haz the power, 2017-04-18 06:03:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 08:42:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492495382245060,
"parent_rev": "c64ccfd0e457a5b54ac57ed095064b0f0bd59203", "commit_rev":
"4b963a8aa430d5937da3f3cdc7bafcd614d36877"}

[commit-bot: I haz the power, 2017-04-18 08:42:21]

Description was changed from

==========
Update update_histogram_enum.py and update_use_counter_feature_enum.py for Blink
rename

This patch updates the scripts for keeping histograms.xml up-to-date so
that they work correctly after the recent Blink rename.

While all the feature enums are now written as kFooMetric, we'd prefer
to have them show as FooMetric in the histograms so support is added for
dropping a leading 'k'.

This patch also adds support for enums with super long names, such as
kUncancellableTouchEventDueToMainThreadResponsivenessPreventDefaulted,
which cause the enum initialization to end up on a separate line.

BUG=675877
==========

to

==========
Update update_histogram_enum.py and update_use_counter_feature_enum.py for Blink
rename

This patch updates the scripts for keeping histograms.xml up-to-date so
that they work correctly after the recent Blink rename.

While all the feature enums are now written as kFooMetric, we'd prefer
to have them show as FooMetric in the histograms so support is added for
dropping a leading 'k'.

This patch also adds support for enums with super long names, such as
kUncancellableTouchEventDueToMainThreadResponsivenessPreventDefaulted,
which cause the enum initialization to end up on a separate line.

BUG=675877

Review-Url: https://codereview.chromium.org/2825573003
Cr-Commit-Position: refs/heads/master@{#465178}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b963a8aa430d5937da3f3cdc7ba...
==========

[commit-bot: I haz the power, 2017-04-18 08:42:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b963a8aa430d5937da3f3cdc7ba...