third_party/WebKit/Source/core/frame/PRESUBMIT.py - Issue 2825573003: Update update_histogram_enum.py and update_use_counter_feature_enum.py for Blink rename

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/PRESUBMIT.py

Issue 2825573003: Update update_histogram_enum.py and update_use_counter_feature_enum.py for Blink rename (Closed)

Patch Set: remove spaces Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/PRESUBMIT.py

diff --git a/third_party/WebKit/Source/core/frame/PRESUBMIT.py b/third_party/WebKit/Source/core/frame/PRESUBMIT.py

index 4d105e328fc03a94b751b30f0c66e27362aec11d..ec96ed48c28a962f47e9236a9d20c60028f324c5 100644

--- a/third_party/WebKit/Source/core/frame/PRESUBMIT.py

+++ b/third_party/WebKit/Source/core/frame/PRESUBMIT.py

@@ -72,13 +72,14 @@ def _RunUmaHistogramChecks(input_api, output_api):

else:

return []

- START_MARKER = '^enum Feature : uint32_t {'

- END_MARKER = '^NumberOfFeatures'

+ start_marker = '^enum Feature : uint32_t {'

+ end_marker = '^kNumberOfFeatures'

should_update_histogram, duplicated_values = update_histogram_enum.HistogramNeedsUpdate(

histogram_enum_name='FeatureObserver',

source_enum_path=source_path,

- start_marker=START_MARKER,

- end_marker=END_MARKER)

+ start_marker=start_marker,

+ end_marker=end_marker,

+ strip_k_prefix=True)

if duplicated_values:

return [output_api.PresubmitPromptWarning(

'UseCounter::Feature has been updated and there exists duplicated '

« no previous file with comments | « no previous file | tools/metrics/histograms/update_histogram_enum.py » ('j') | no next file with comments »