Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2825523004: Revert of Add suppresion of slop region touches in browser (Closed)

Created:
3 years, 8 months ago by ojan
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add suppresion of slop region touches in browser (patchset #3 id:40001 of https://codereview.chromium.org/2816613003/ ) Reason for revert: Caused layout test failures. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fevents%2Fpointerevents%2Fmulti-pointer-event-in-slop-region.html&testType=webkit_tests https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fevents%2Fpointerevents%2Fpointer-event-in-slop-region.html&testType=webkit_tests Original issue's description: > Add suppresion of slop region touches in browser > > This change tentaively adds back the touch slop > region suppression in browser. This will cause > the touch pointerevents stop firing while the > touch point is moving within the slop region. > But we would like to see whether it affects > our TouchToFirstScrollUpdateSwapBegin metric > or not. > > BUG=704935 > > Review-Url: https://codereview.chromium.org/2816613003 > Cr-Commit-Position: refs/heads/master@{#465252} > Committed: https://chromium.googlesource.com/chromium/src/+/b8126037096ad1da5aa13af72af5a5580cf22263 TBR=tdresser@chromium.org,dtapuska@chromium.org,nzolghadr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=704935 Review-Url: https://codereview.chromium.org/2825523004 Cr-Commit-Position: refs/heads/master@{#465312} Committed: https://chromium.googlesource.com/chromium/src/+/7a70faddc69db1f8018d3124d5b7fefbc6b311fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -79 lines) Patch
M content/browser/renderer_host/input/passthrough_touch_event_queue.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/passthrough_touch_event_queue.cc View 5 chunks +0 lines, -63 lines 0 comments Download
M content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc View 2 chunks +16 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
ojan
Created Revert of Add suppresion of slop region touches in browser
3 years, 8 months ago (2017-04-18 18:56:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825523004/1
3 years, 8 months ago (2017-04-18 18:57:39 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 18:58:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7a70faddc69db1f8018d3124d5b7...

Powered by Google App Engine
This is Rietveld 408576698