Issue 2825503002: Revert "Revert "Report error if the same uri appears in multiple summaries.""

Issue 2825503002: Revert "Revert "Report error if the same uri appears in multiple summaries."" (Closed)

Created:
3 years, 8 months ago by vsm

Modified:
3 years, 8 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Revert "Report error if the same uri appears in multiple summaries."" Relanding after fixing package_bundle_reader_test.dart. Note, original CL (already reviewed here: https://codereview.chromium.org/2781483007/) is patch set 1. Test fix is patch set #2. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/a3d2e49198a43640c93b7259df269db1d0cc546d

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -4 lines)			Patch
M	pkg/analyzer/lib/src/summary/package_bundle_reader.dart	View		5 chunks	+63 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/src/summary/package_bundle_reader_test.dart	View	1	2 chunks	+12 lines, -1 line	0 comments	Download
M	pkg/analyzer_cli/lib/src/build_mode.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/command.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/compiler.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/dev_compiler/test/worker/worker_test.dart	View		3 chunks	+60 lines, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

vsm

3 years, 8 months ago (2017-04-17 17:11:29 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
a3d2e49198a43640c93b7259df269db1d0cc546d (presubmit successful).