Revert "Revert "Report error if the same uri appears in multiple summaries.""

pkg/analyzer/lib/src/summary/package_bundle_reader.dart

 import 'dart:io' as io;
+import 'dart:math' show min;
 
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/context/cache.dart';
 import 'package:analyzer/src/context/context.dart';
 import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/resolver.dart' show TypeProvider;
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/src/generated/source_io.dart';
@@ skipping 287 matching lines @@
   }
 
   @override
   bool hasLibrarySummary(String uri) {
     LinkedLibrary linkedLibrary = _dataStore.linkedMap[uri];
     return linkedLibrary != null;
   }
 }
 
 /**
+ * A [ConflictingSummaryException] indicates that two different summaries
+ * provided to a [SummaryDataStore] conflict.
+ */
+class ConflictingSummaryException implements Exception {
+  final String duplicatedUri;
+  final String summary1Uri;
+  final String summary2Uri;
+  String _message;
+
+  ConflictingSummaryException(Iterable<String> summaryPaths, this.duplicatedUri,
+      this.summary1Uri, this.summary2Uri) {
+    // Paths are often quite long.  Find and extract out a common prefix to
+    // build a more readable error message.
+    var prefix = _commonPrefix(summaryPaths.toList());
+    _message = '''
+These summaries conflict because they overlap:
+- ${summary1Uri.substring(prefix)}
+- ${summary2Uri.substring(prefix)}
+Both contain the file: ${duplicatedUri}.
+This typically indicates an invalid build rule where two or more targets
+include the same source.
+  ''';
+  }
+
+  /// Given a set of file paths, find a common prefix.
+  int _commonPrefix(List<String> strings) {
+    if (strings.isEmpty) return 0;
+    var first = strings.first;
+    int common = first.length;
+    for (int i = 1; i < strings.length; ++i) {
+      var current = strings[i];
+      common = min(common, current.length);
+      for (int j = 0; j < common; ++j) {
+        if (first[j] != current[j]) {
+          common = j;
+          if (common == 0) return 0;
+          break;
+        }
+      }
+    }
+    // The prefix should end with a file separator.
+    var last =
+        first.substring(0, common).lastIndexOf(io.Platform.pathSeparator);
+    return last < 0 ? 0 : last + 1;
+  }
+
+  String toString() => _message;
+}
+
+/**
  * A [SummaryDataStore] is a container for the data extracted from a set of
  * summary package bundles.  It contains maps which can be used to find linked
  * and unlinked summaries by URI.
  */
 class SummaryDataStore {
   /**
    * List of all [PackageBundle]s.
    */
   final List<PackageBundle> bundles = <PackageBundle>[];
 
@@ skipping 16 matching lines @@
    * Map from the URI of a library to the linked summary of that library.
    */
   final Map<String, LinkedLibrary> linkedMap = <String, LinkedLibrary>{};
 
   /**
    * Map from the URI of a library to the summary path that contained it.
    */
   final Map<String, String> uriToSummaryPath = <String, String>{};
 
   /**
+   * List of summary paths.
+   */
+  final Iterable<String> _summaryPaths;
+
+  /**
    * Create a [SummaryDataStore] and populate it with the summaries in
    * [summaryPaths].  If [recordDependencyInfo] is `true`, record
    * [PackageDependencyInfo] for each summary, for later access via
    * [dependencies].
    */
   SummaryDataStore(Iterable<String> summaryPaths,
       {bool recordDependencyInfo: false, ResourceProvider resourceProvider})
-      : dependencies =
+      : _summaryPaths = summaryPaths,
+        dependencies =
             recordDependencyInfo ? <PackageDependencyInfoBuilder>[] : null {
     summaryPaths.forEach((String path) => _fillMaps(path, resourceProvider));
   }
 
   /**
    * Add the given [bundle] loaded from the file with the given [path].
    */
   void addBundle(String path, PackageBundle bundle) {
     bundles.add(bundle);
     if (dependencies != null) {
@@ skipping 14 matching lines @@
       }
       dependencies.add(new PackageDependencyInfoBuilder(
           includedPackageNames: includedPackageNames.toList()..sort(),
           includesDartUris: includesDartUris,
           includesFileUris: includesFileUris,
           apiSignature: bundle.apiSignature,
           summaryPath: path));
     }
     for (int i = 0; i < bundle.unlinkedUnitUris.length; i++) {
       String uri = bundle.unlinkedUnitUris[i];
+      if (uriToSummaryPath.containsKey(uri) &&
+          (uriToSummaryPath[uri] != path)) {
+        throw new ConflictingSummaryException(
+            _summaryPaths, uri, uriToSummaryPath[uri], path);
+      }
       uriToSummaryPath[uri] = path;
       addUnlinkedUnit(uri, bundle.unlinkedUnits[i]);
     }
     for (int i = 0; i < bundle.linkedLibraryUris.length; i++) {
       String uri = bundle.linkedLibraryUris[i];
       addLinkedLibrary(uri, bundle.linkedLibraries[i]);
     }
   }
 
   /**
@@ skipping 41 matching lines @@
       var file = resourceProvider.getFile(path);
       buffer = file.readAsBytesSync();
     } else {
       io.File file = new io.File(path);
       buffer = file.readAsBytesSync();
     }
     PackageBundle bundle = new PackageBundle.fromBuffer(buffer);
     addBundle(path, bundle);
   }
 }