Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: pkg/dev_compiler/lib/src/compiler/command.dart

Issue 2825503002: Revert "Revert "Report error if the same uri appears in multiple summaries."" (Closed)
Patch Set: Fix broken test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer_cli/lib/src/build_mode.dart ('k') | pkg/dev_compiler/lib/src/compiler/compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/command.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/command.dart b/pkg/dev_compiler/lib/src/compiler/command.dart
index 738837cea62097ebbca0c6277231580ee0f818b7..6170f6d85f7631e774f687cf7086b235ba7bd109 100644
--- a/pkg/dev_compiler/lib/src/compiler/command.dart
+++ b/pkg/dev_compiler/lib/src/compiler/command.dart
@@ -10,7 +10,7 @@ import 'package:analyzer/src/command_line/arguments.dart'
ignoreUnrecognizedFlagsFlag;
import 'package:analyzer/src/generated/source.dart' show Source;
import 'package:analyzer/src/summary/package_bundle_reader.dart'
- show InSummarySource;
+ show ConflictingSummaryException, InSummarySource;
import 'package:args/args.dart' show ArgParser, ArgResults;
import 'package:args/command_runner.dart' show UsageException;
import 'package:path/path.dart' as path;
@@ -63,6 +63,10 @@ int compile(List<String> args, {void printFn(Object obj)}) {
// Incorrect usage, input file not found, etc.
printFn(error);
return 64;
+ } on ConflictingSummaryException catch (error) {
+ // Same input file appears in multiple provided summaries.
+ printFn(error);
+ return 65;
} on CompileErrorException catch (error) {
// Code has error(s) and failed to compile.
printFn(error);
« no previous file with comments | « pkg/analyzer_cli/lib/src/build_mode.dart ('k') | pkg/dev_compiler/lib/src/compiler/compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698