[Payment Request] Protocol for payments items with accessoryType property

[Payment Request] Protocol for payments items with accessoryType property

Since CollectionViewItem  doesn't expose an accessoryType property, conforming to this protocol allows the payments CollectionViewControllers (CVC) to set the accessory type on instances of CollectionViewItem subclasses that are created in the mediators and provided to the CVC as a CollectionViewItem<PaymentsHasAccessoryType>.

BUG=602666
Review-Url: https://codereview.chromium.org/2825483002
Cr-Commit-Position: refs/heads/master@{#464937}
Committed: https://chromium.googlesource.com/chromium/src/+/930795ddf864dc42d755523e2e8d422897385643

[Moe, 2017-04-17 14:13:08]

Description was changed from

==========
[Payment Request] Protocol for payments items with accessoryType property

Signed-off-by: Mohamad Ahmadi <mahmadi@chromium.org>

[Payment Request] Adds a secondary text label to PaymentsTextCell

Adds a secondary text label to PaymentsTextCell and replaces instances
of CollectionViewTextItem with PaymentsTextItem

BUG=602666
==========

to

==========
[Payment Request] Protocol for payments items with accessoryType property

BUG=602666
==========

[Moe, 2017-04-17 14:31:36]

Patchset #1 (id:1) has been deleted

[Moe, 2017-04-17 14:51:56]

Patchset #1 (id:20001) has been deleted

[Moe, 2017-04-17 14:53:18]

mahmadi@chromium.org changed reviewers:
+ jdonnelly@chromium.org

[Moe, 2017-04-17 14:53:19]

Hi Justin, Please take a look at this CL.

[Moe, 2017-04-17 15:00:56]

Description was changed from

==========
[Payment Request] Protocol for payments items with accessoryType property

BUG=602666
==========

to

==========
[Payment Request] Protocol for payments items with accessoryType property

Conforming to this  allows the CollectionViewController (CVC) to set accessory
type on instances of CollectionViewItem subclasses that are created in the
mediators and provided to the CVC as
CollectionViewItem<PaymentsHasAccessoryType>

BUG=602666
==========

[Moe, 2017-04-17 15:02:51]

Description was changed from

==========
[Payment Request] Protocol for payments items with accessoryType property

Conforming to this  allows the CollectionViewController (CVC) to set accessory
type on instances of CollectionViewItem subclasses that are created in the
mediators and provided to the CVC as
CollectionViewItem<PaymentsHasAccessoryType>

BUG=602666
==========

to

==========
[Payment Request] Protocol for payments items with accessoryType property

Conforming to this protocol allows the CollectionViewController (CVC) to set
accessory type on instances of CollectionViewItem subclasses that are created in
the mediators and provided to the CVC as
CollectionViewItem<PaymentsHasAccessoryType>

BUG=602666
==========

[Justin Donnelly, 2017-04-17 15:21:59]

lgtm

[nit] Add a period to the end of the sentence in your description.

Also, I don't fully understand the description. Is this part of a refactor where
the existing controllers are being changed into a generic controller that won't
deal with the specific types? If this is part of some forthcoming change, it
would help to understand that.

https://codereview.chromium.org/2825483002/diff/40001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/cells/payments_has_accessory_type.h (right):

https://codereview.chromium.org/2825483002/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/cells/payments_has_accessory_type.h:12: @protocol
PaymentsHasAccessoryType
Does this name conform to some existing pattern? Like, are there other protocols
that expose a property named "Has<Property>"? It seems reasonable but since this
is probably a type of protocol used elsewhere I just want to make sure we're not
introducing a different way to refer to it.

[Moe, 2017-04-17 15:36:37]

Description was changed from

==========
[Payment Request] Protocol for payments items with accessoryType property

Conforming to this protocol allows the CollectionViewController (CVC) to set
accessory type on instances of CollectionViewItem subclasses that are created in
the mediators and provided to the CVC as
CollectionViewItem<PaymentsHasAccessoryType>

BUG=602666
==========

to

==========
[Payment Request] Protocol for payments items with accessoryType property

Conforming to this protocol allows the CollectionViewController (CVC) to set
accessory type on instances of CollectionViewItem subclasses that are created in
the mediators and provided to the CVC as
CollectionViewItem<PaymentsHasAccessoryType>.

BUG=602666
==========

[Moe, 2017-04-17 15:38:53]

Description was changed from

==========
[Payment Request] Protocol for payments items with accessoryType property

Conforming to this protocol allows the CollectionViewController (CVC) to set
accessory type on instances of CollectionViewItem subclasses that are created in
the mediators and provided to the CVC as
CollectionViewItem<PaymentsHasAccessoryType>.

BUG=602666
==========

to

==========
[Payment Request] Protocol for payments items with accessoryType property

Since CollectionViewItem  doesn't expose an accessoryType property, conforming
to this protocol allows the payments CollectionViewControllers (CVC) to set the
accessory type on instances of CollectionViewItem subclasses that are created in
the mediators and provided to the CVC as a
CollectionViewItem<PaymentsHasAccessoryType>.

BUG=602666
==========

[Moe, 2017-04-17 15:45:31]

Thank you.

This change is related to [1] which proposes using subclasses of
CollectionViewItem as a data holder for the ui layer which can be initialized in
the mediators and passed to the CollecitonViewController as an instance of
CollectionViewItem. However, since CollectionViewItem doesn't expose a
accessoryType property, this causes problems for some scenarios where the view
controller needs to set that property on the item. There's currently a cl [2]
that proposes adding that property. This work around allows the payments code to
move forward, while the jury is out on that CL. 

[1]:
https://docs.google.com/document/d/1RlI_-VwNdYErWcIIeXs7dpuxBbKJ4Wn81cKDkDaG5...

[2]: https://codereview.chromium.org/2814793003/

https://codereview.chromium.org/2825483002/diff/40001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/cells/payments_has_accessory_type.h (right):

https://codereview.chromium.org/2825483002/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/cells/payments_has_accessory_type.h:12: @protocol
PaymentsHasAccessoryType
On 2017/04/17 15:21:58, Justin Donnelly wrote:
> Does this name conform to some existing pattern? Like, are there other
protocols
> that expose a property named "Has<Property>"? It seems reasonable but since
this
> is probably a type of protocol used elsewhere I just want to make sure we're
not
> introducing a different way to refer to it.

I'm not following any convention in naming nor my search came up with any
existing "Has<Property>" protocol name. I simply came up with a name that made
sense.
Since the use of this protocol will remain within the /payments path, it should
be ok. If lpromero@ or @gambard object to the naming in the follow up CL i can
certainly rename it.

[Moe, 2017-04-17 15:46:02]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2017-04-17 15:46:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 17:16:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492443962609480,
"parent_rev": "c05e9d1b384c97d2ce389a745d61af5d347b22df", "commit_rev":
"930795ddf864dc42d755523e2e8d422897385643"}

[commit-bot: I haz the power, 2017-04-17 17:16:13]

Description was changed from

==========
[Payment Request] Protocol for payments items with accessoryType property

Since CollectionViewItem  doesn't expose an accessoryType property, conforming
to this protocol allows the payments CollectionViewControllers (CVC) to set the
accessory type on instances of CollectionViewItem subclasses that are created in
the mediators and provided to the CVC as a
CollectionViewItem<PaymentsHasAccessoryType>.

BUG=602666
==========

to

==========
[Payment Request] Protocol for payments items with accessoryType property

Since CollectionViewItem  doesn't expose an accessoryType property, conforming
to this protocol allows the payments CollectionViewControllers (CVC) to set the
accessory type on instances of CollectionViewItem subclasses that are created in
the mediators and provided to the CVC as a
CollectionViewItem<PaymentsHasAccessoryType>.

BUG=602666

Review-Url: https://codereview.chromium.org/2825483002
Cr-Commit-Position: refs/heads/master@{#464937}
Committed:
https://chromium.googlesource.com/chromium/src/+/930795ddf864dc42d755523e2e8d...
==========

[commit-bot: I haz the power, 2017-04-17 17:16:15]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/930795ddf864dc42d755523e2e8d...