ios/chrome/browser/payments/cells/payments_has_accessory_type.h - Issue 2825483002: [Payment Request] Protocol for payments items with accessoryType property

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/payments/cells/payments_has_accessory_type.h

Issue 2825483002: [Payment Request] Protocol for payments items with accessoryType property (Closed)

Patch Set: Initial Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_PAYMENTS_CELLS_PAYMENTS_HAS_ACCESSORY_TYPE_H_

	6 #define IOS_CHROME_BROWSER_PAYMENTS_CELLS_PAYMENTS_HAS_ACCESSORY_TYPE_H_

	7

	8 #import "ios/third_party/material_components_ios/src/components/CollectionCells/ src/MaterialCollectionCells.h"

	9

	10 // Protocol adopted by the payments collection view items that set the accessory

	11 // view type on their represented cells.

	12 @protocol PaymentsHasAccessoryType
	Justin Donnelly 2017/04/17 15:21:58 Does this name conform to some existing pattern? L Does this name conform to some existing pattern? Like, are there other protocols that expose a property named "Has<Property>"? It seems reasonable but since this is probably a type of protocol used elsewhere I just want to make sure we're not introducing a different way to refer to it. Moe 2017/04/17 15:45:30 I'm not following any convention in naming nor my Show quoted text On 2017/04/17 15:21:58, Justin Donnelly wrote: > Does this name conform to some existing pattern? Like, are there other protocols > that expose a property named "Has<Property>"? It seems reasonable but since this > is probably a type of protocol used elsewhere I just want to make sure we're not > introducing a different way to refer to it. I'm not following any convention in naming nor my search came up with any existing "Has<Property>" protocol name. I simply came up with a name that made sense. Since the use of this protocol will remain within the /payments path, it should be ok. If lpromero@ or @gambard object to the naming in the follow up CL i can certainly rename it.
	13

	14 // The accessory view type for the represented cell.

	15 @property(nonatomic) MDCCollectionViewCellAccessoryType accessoryType;

	16

	17 @end

	18

	19 #endif // IOS_CHROME_BROWSER_PAYMENTS_CELLS_PAYMENTS_HAS_ACCESSORY_TYPE_H_

OLD	NEW

« no previous file with comments | « ios/chrome/browser/payments/cells/payment_method_item.h ('k') | ios/chrome/browser/payments/cells/payments_text_item.h » ('j') | no next file with comments »